[NoQA] Add tests for switch to Expensify classic flow by hungvu193 · Pull Request #52754 · Expensify/App

hungvu193 · 2024-11-19T11:34:57Z

Explanation of Change

Add tests for recently added logic:

    if (shouldOpenBookACall) {
        Navigation.navigate(ROUTES.SETTINGS_EXIT_SURVERY_BOOK_CALL.route);
        return;
    }
    Navigation.navigate(ROUTES.SETTINGS_EXIT_SURVEY_CONFIRM.route);

Fixed Issues

$ #51703
PROPOSAL: N/A

Tests

From your root project, run the following command:

TZ=utc NODE_OPTIONS=--experimental-vm-modules jest tests/ui/InitialSettingPageTest.tsx

Verify that all the tests passed.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
No QA

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-22.at.13.52.01.mov

Android: mWeb Chrome

Screen.Recording.2024-11-22.at.13.52.01.mov

iOS: Native

Screen.Recording.2024-11-22.at.13.52.01.mov

iOS: mWeb Safari

Screen.Recording.2024-11-22.at.13.52.01.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-22.at.13.52.01.mov

MacOS: Desktop

Screen.Recording.2024-11-22.at.13.52.01.mov

tests/unit/InitialSettingPageTest.tsx

mountiny · 2024-11-21T17:46:01Z

@hungvu193 how is this going?

hungvu193 · 2024-11-22T02:00:59Z

Still stuck on the second test, I will raise a slack convo to get some helps.

melvin-bot · 2024-11-22T06:53:23Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2024-11-22T06:55:02Z

Oh weird. I think you can ignore this PR @Ollyws, I'm not sure why you're assigned, @shubham1206agra is the C+ on the linked issue, he will handle this one. Ty

shubham1206agra · 2024-11-22T06:59:24Z

@mountiny I don't think this test is helpful since it creates a function and tests the same function.

hungvu193 · 2024-11-22T07:03:33Z

My initial tests were:

Render the App
Go to Settings.
Trigger the Switch To Expensify Class Button.

However while debugging the tests, the logic inside action of Switch To Expensify Class Button was never triggered, which made me stuck there. Any suggestions?

shubham1206agra · 2024-11-22T07:20:31Z

My initial tests were:
1. Render the .

2. Go to Settings.

3. Trigger the `Switch To Expensify Class Button`.
However while debugging the tests, the logic inside action of Switch To Expensify Class Button was never triggered, which made me stuck there. Any suggestions?

@hungvu193 Can you check if action was mocked anywhere?

hungvu193 · 2024-11-22T07:25:59Z

@hungvu193 Can you check if action was mocked anywhere?

I don't think I mocked action, this is the old test btw
https://github.com/Expensify/App/blob/1fa2c4e15881b380ea7116f5166b834904a731c9/tests/unit/InitialSettingPageTest.tsx

hungvu193 · 2024-11-22T08:52:00Z

Updated the tests @shubham1206agra.

shubham1206agra · 2024-11-22T09:15:42Z

@hungvu193 Can you add this test to test suite so it will run in CI?

shubham1206agra · 2024-11-22T09:20:51Z

@hungvu193 Is there a reason why test takes 50 sec to run?

hungvu193 · 2024-11-22T09:29:29Z

@hungvu193 Can you add this test to test suite so it will run in CI?

How to do that? Sorry I'm new with this one.

@hungvu193 Is there a reason why test takes 50 sec to run?

Mine takes 4.5 seconds to run both tests. I think every test case needs to re-render and login the App (also wait for Onyx data..etc) it probably takes longer based on our connection?

shubham1206agra · 2024-11-22T09:36:35Z

@hungvu193 Can you add this test to test suite so it will run in CI?

How to do that? Sorry I'm new with this one.

Sorry, I got confused. Can you put this test under ui folder since test is related to UI?

@hungvu193 Is there a reason why test takes 50 sec to run?

Mine takes 4.5 seconds to run both tests. I think every test case needs to re-render and login the App (also wait for Onyx data..etc) it probably takes longer based on our connection?

Yeah, my system nows shows 5 sec to run the test.

hungvu193 · 2024-11-22T09:39:47Z

Sorry, I got confused. Can you put this test under ui folder since test is related to UI?

Done 😄

shubham1206agra · 2024-11-22T17:09:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

mountiny

Code looks good to me but its not clear to me why the test is name this way?

mountiny · 2024-11-25T13:49:35Z

tests/ui/InitialSettingPageTest.tsx

Is this a correct file name?

hungvu193 · 2024-11-25T13:55:02Z

Code looks good to me but its not clear to me why the test is name this way?

Do you have any suggestions? I was about to name it "SwitchToExpensifyClassicFlow" but then I changed my mind cause I think in the future we might add more tests to this file whenever we added new logic into InitialSettingPage.

…o followup/51703

mountiny

Thanks!

github-actions · 2024-11-26T16:41:00Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.67-0 🚀

platform	result
🤖 android 🤖	false ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-28T14:22:03Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.67-9 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

add test for switch to expensify classic flow

d28ff16

hungvu193 mentioned this pull request Nov 19, 2024

[HOLD for payment 2024-12-05] [HOLD for payment 2024-11-28] Update the Switch to Expensify Classic survey to drive better feedback #51703

Closed

hungvu193 added 2 commits November 19, 2024 18:38

rename file

e9128a5

improve test

1414082

mountiny assigned hungvu193 Nov 20, 2024

mountiny self-requested a review November 20, 2024 10:25

mountiny changed the title ~~Follow-up Add test for switch to Expensify classic flow~~ [NoQA] Add test for switch to Expensify classic flow Nov 20, 2024

hungvu193 commented Nov 21, 2024

View reviewed changes

tests/unit/InitialSettingPageTest.tsx Outdated Show resolved Hide resolved

fix lint

1fa2c4e

mountiny requested a review from shubham1206agra November 21, 2024 17:46

hungvu193 added 2 commits November 22, 2024 10:57

Merge remote-tracking branch 'origin/main' into followup/51703

87cb371

Update the testcase

f9edfa5

hungvu193 marked this pull request as ready for review November 22, 2024 06:53

hungvu193 requested a review from a team as a code owner November 22, 2024 06:53

melvin-bot bot requested review from Ollyws and removed request for a team November 22, 2024 06:53

remove unused mock

d64ccd6

hungvu193 changed the title ~~[NoQA] Add test for switch to Expensify classic flow~~ [NoQA] Add tests for switch to Expensify classic flow Nov 22, 2024

make tests running

279ea76

remove unused import

9cf8dc2

move to UI section

6df31df

shubham1206agra approved these changes Nov 22, 2024

View reviewed changes

Merge remote-tracking branch 'origin/main' into followup/51703

eaf700d

mountiny removed the request for review from Ollyws November 25, 2024 13:47

mountiny previously approved these changes Nov 25, 2024

View reviewed changes

tests/ui/InitialSettingPageTest.tsx

Copy link
Copy Markdown

Contributor

mountiny Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a correct file name?

hungvu193 added 2 commits November 25, 2024 22:08

rename test

8c71c3a

Merge branch 'followup/51703' of https://github.com/hungvu193/App int…

ff33d0a

…o followup/51703

hungvu193 dismissed mountiny’s stale review via ff33d0a November 25, 2024 15:09

mountiny approved these changes Nov 25, 2024

View reviewed changes

mountiny merged commit 70dfbb7 into Expensify:main Nov 25, 2024

github-actions bot mentioned this pull request Nov 26, 2024

Deploy Checklist: New Expensify 2024-11-26 #53142

Closed

75 tasks

Conversation

hungvu193 commented Nov 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

mountiny commented Nov 21, 2024

Uh oh!

hungvu193 commented Nov 22, 2024

Uh oh!

melvin-bot bot commented Nov 22, 2024

Uh oh!

hungvu193 commented Nov 22, 2024

Uh oh!

shubham1206agra commented Nov 22, 2024

Uh oh!

hungvu193 commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shubham1206agra commented Nov 22, 2024

Uh oh!

hungvu193 commented Nov 22, 2024

Uh oh!

hungvu193 commented Nov 22, 2024

Uh oh!

shubham1206agra commented Nov 22, 2024

Uh oh!

shubham1206agra commented Nov 22, 2024

Uh oh!

hungvu193 commented Nov 22, 2024

Uh oh!

shubham1206agra commented Nov 22, 2024

Uh oh!

hungvu193 commented Nov 22, 2024

Uh oh!

shubham1206agra commented Nov 22, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

hungvu193 commented Nov 25, 2024

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 26, 2024

Uh oh!

github-actions bot commented Nov 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hungvu193 commented Nov 19, 2024 •

edited

Loading

hungvu193 commented Nov 22, 2024 •

edited

Loading