[No QA]Change path to iOS and Android fastlane keys to fix production builds#52797
[No QA]Change path to iOS and Android fastlane keys to fix production builds#52797luacmartins merged 1 commit intomainfrom
Conversation
|
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| ENV["SUPPLY_UPLOAD_MAX_RETRIES"]="5" | ||
| google_play_track_version_codes( | ||
| package_name: "org.me.mobiexpensifyg", | ||
| json_key: './android/app/android-fastlane-json-key.json', |
There was a problem hiding this comment.
That path is still used on lines 222 and 227, does it need to be changed there too?
There was a problem hiding this comment.
I think Android worked with whats on main, so I don't think we have to update those: https://github.com/Expensify/App/actions/runs/11903865680/job/33171667755
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.65-0 🚀
|
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.65-5 🚀
|
Explanation of Change
HybridApp production deploys failed because of the key path, this should resolve the location of the file and enable production deploys.
Fixed Issues
Fixes https://expensify.slack.com/archives/C07J32337/p1732040905765199?thread_ts=1731977044.576979&cid=C07J32337
Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop