[vip-travel] Create Trip Details Screen#52823
[vip-travel] Create Trip Details Screen#52823stitesExpensify merged 85 commits intoExpensify:mainfrom
Conversation
…p content in ScrollView
This reverts commit 04d94db.
94cabfb to
2eb1bb9
Compare
…ervation data and sort by start date
…ation data and improve navigation handling
|
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.0.78-0 🚀
|
|
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.0.78-0 🚀
|
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.78-6 🚀
|
|
We forgot to handle an edge case where the url parameters are wrong. Caused #54537 |
| shouldShowRightIcon | ||
| onPress={() => { | ||
| setIsTripSupportLoading(true); | ||
| Link.openTravelDotLink(activePolicyID, CONST.TRIP_ID_PATH(tripID))?.finally(() => { |
There was a problem hiding this comment.
This should be linked to support page. Caused issue #54545
| personalDetails: OnyxEntry<PersonalDetails>; | ||
| }; | ||
|
|
||
| function CarTripDetails({reservation, personalDetails}: CarTripDetailsProps) { |
There was a problem hiding this comment.
I think we have not put up a cancellation policy row in this page. But it was due to missing requirement and data. This caused #54536
| const checkOutDate = DateUtils.getFormattedTransportDateAndHour(new Date(reservation.end.date)); | ||
| const cancellationText = reservation.cancellationDeadline | ||
| ? `${translate('travel.hotelDetails.cancellationUntil')} ${DateUtils.getFormattedTransportDateAndHour(new Date(reservation.cancellationDeadline)).date}` | ||
| : reservation.cancellationPolicy; |
There was a problem hiding this comment.
We forgot to translate hotel cancellation policy, which caused #56067
|
We forgot to pass prop |
| <MenuItem | ||
| title={translate('travel.modifyTrip')} | ||
| icon={Expensicons.Pencil} | ||
| iconFill={theme.iconSuccessFill} |
There was a problem hiding this comment.
We didn't to set iconFill since default color was the correct one: #58996
|
Different styling being used in Workspace Members page and other Workspace pages like Categories. Issue: #59498 |
Explanation of Change
We're adding a new Trip Details Modal in NewDot, allowing users to view travel details directly in the app instead of being redirected to Spotnana. This includes creating a new page and components to display trip information like flights, hotels, rails and cars seamlessly.
Fixed Issues
$ #37823
PROPOSAL: N/A
Tests
To prepare your account and environment for testing, follow these steps:
1. Configure Your Account for Testing
Navigate to OldDot (ideally create new account)
Run the following JavaScript snippet in the console before enabling travel in the account:
Verify that the test settings are successfully applied (
NVP.get('travelSettings')).Now you can enable travel in the account and proceed with testing (Search -> Trip -> book a trip)
Use stripe card ending in
4444for testing purposes (https://docs.stripe.com/testing)When reserving trips for testing purposes:
Example:
Flight Details
Hotel Details
Car Rental Details
Train/Rail Details
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.webm
Android: mWeb Chrome
android-web.webm
iOS: Native
ios.mp4
iOS: mWeb Safari
Nothing here 🤫
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov