Feat: Add placeholder thumbnail to expenses with no receipt by gijoe0295 · Pull Request #52848 · Expensify/App

gijoe0295 · 2024-11-20T20:26:14Z

Explanation of Change

Add empty receipt placeholders to expense/report previews without receipts
Update the Add receipt placeholder icon

Fixed Issues

$ #52638
PROPOSAL: #52638 (comment)

Tests

Create several expenses with and without receipts to a workspace
Verify the report preview shows empty receipt placeholders and receipt thumbnails in the order of the created expenses
Verify the figure in the corner shows the number of remaining expenses in the expense report (total expenses - 3 thumbnails)
Tap the report preview to open expense report
Verify expenses without receipt shows empty receipt placeholders
Tap the expense preview without receipt to open transaction details report
Verify Add receipt placeholder shows with a green plus icon
Tap the receipt placeholder
Verify app opens Upload receipt page
Tap FAB > Submit expense > Manual
Create an expense
In confirmation step, verify the Add receipt placeholder shows with a green plus icon

Verify that no errors appear in the JS console

Offline tests

QA Steps

Submit 2 manual expenses (without receipts) and 2 scan expenses (with receipt) to a workspace respectively
Verify the report preview shows 2 empty receipt placeholders and 2 receipt thumbnails respectively
Verify the figure in the corner shows the number of remaining expenses in the expense report (+1 in this case)
Tap the report preview to open expense report
Verify expenses without receipt shows empty receipt placeholders
Tap the expense preview without receipt to open transaction details report
Verify Add receipt placeholder shows with a green plus icon
Tap the receipt placeholder
Verify app opens Upload receipt page
Tap FAB > Submit expense > Manual
Create an expense
In confirmation step, verify the Add receipt placeholder shows with a green plus icon

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-11-21T17:16:29Z

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2024-11-21T20:21:09Z

It looks like we don't have perfectly even borders and a clean border radius here, any ideas what's happening?

brunovjk · 2024-11-22T12:14:27Z

@gijoe0295 I've noticed an issue: clicking a placeholder receipt in the request preview doesn’t redirect to the expense, unlike clicking a regular receipt preview:

52848_bug.mov

dannymcclain · 2024-11-22T14:31:01Z

Similar to Shawn's comment, it looks like the gap between placeholder thumbnails is too big.

The gap/border/whatever we call it should be equal on all sides and between thumbnails.

brunovjk · 2024-11-26T11:26:11Z

👋 @gijoe0295 Have you had a chance to look at the latest comments? Thanks.

gijoe0295 · 2024-11-26T12:10:26Z

Yeah I found the root cause. Will push the changes soon.

gijoe0295 · 2024-11-26T16:33:17Z

@brunovjk @dannymcclain I fixed the uneven borders & navigation press issues.

brunovjk · 2024-11-26T17:21:40Z

Sorry @gijoe0295, when it's ready for review, please let me know. Thank you :D

gijoe0295 · 2024-11-26T17:25:54Z

@brunovjk Sorry for the confusion. It's ready for review. I just forgot to push the last commit for fixing the onPress issue.

brunovjk · 2024-11-26T18:36:50Z

No worries 👊

brunovjk · 2024-11-26T18:37:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

52848_android_native.mov

Android: mWeb Chrome

52848_android_web.mov

iOS: Native

52848_ios_native.mov

iOS: mWeb Safari

52848_ios_web.mov

MacOS: Chrome / Safari

52848_web_chrome.mov

MacOS: Desktop

52848_web_desktop.mov

brunovjk · 2024-11-26T21:41:44Z

Looking good @gijoe0295, except for one detail: We need to show the receipt instead of the Add receipt placeholder after the user uploads a receipt. Let me know your thoughts. Thanks a lot.

Production

prod.mov

This PR

pr_bug.mov

brunovjk · 2024-11-28T12:02:09Z

@gijoe0295, did you have a chance to take a look at my last comment? Thanks.

…ng a receipt

gijoe0295 · 2024-12-01T10:36:41Z

@brunovjk I resolved it.

brunovjk

I noticed some unrelated issues, like warnings in native and bugs like duplicate preview creation or the scan confirmation modal not disappearing on desktop (though the expense is created). These were reported in Slack and are unrelated to this PR.

We need confirmation @Expensify/design. Other than that, everything seems good to me.

Additionally, @jasperhuangg, could you confirm if unit tests are required, should we include them here or address them in a separate PR? Thank you.

Reviewer Checklist

dannymcclain · 2024-12-02T19:10:33Z

Running a build to test this bad boy

github-actions · 2024-12-02T19:10:47Z

🚧 @dannymcclain has triggered a test build. You can view the workflow run here.

github-actions · 2024-12-02T19:36:32Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/52848/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/52848/NewExpensify.dmg	https://52848.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2024-12-02T20:13:53Z

Quick spin and it looks pretty good to me!

dannymcclain · 2024-12-02T20:18:59Z

Looking good to me too!

OSBotify · 2024-12-03T17:54:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-04T01:39:29Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.0.71-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-05T14:59:51Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.71-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

suneox · 2024-12-30T12:53:40Z

src/components/ReportActionItem/ReportPreview.tsx

+                            images={lastThreeReceipts}
+                            total={allTransactions.length}
+                            size={CONST.RECEIPT.MAX_REPORT_PREVIEW_RECEIPTS}
+                            onPress={openReportFromPreview}


Coming from checklist #53697, we don’t need to handle this action because the parent already handles it at https://github.com/abzokhattab/App/blob/ce344b5eef2ade348a24a9484c86e199e6ab8155/src/components/ReportActionItem/ReportPreview.tsx#L492.

brunovjk · 2025-01-06T15:16:35Z

Coming from the checklist here, we should have reviewed all instances of useOnyx in MoneyRequestPreviewContent.tsx where the fallback ID is needed. The app was crashing because we removed the fallback ID when chatReportID changed.

gijoe0295 added 4 commits November 16, 2024 02:25

add placeholder thumbnail to expenses with no receipt

f49c46f

Merge branch 'main' of https://github.com/gijoe0295/App into gijoe/52638

a33beab

Merge branch 'main' of https://github.com/gijoe0295/App into gijoe/52638

6a6820c

Merge branch 'main' of https://github.com/gijoe0295/App into gijoe/52638

b8cc99c

gijoe0295 changed the title ~~Feat: Add placeholder thumbnail to expenses with no receipt~~ [WIP] Feat: Add placeholder thumbnail to expenses with no receipt Nov 20, 2024

gijoe0295 added 2 commits November 21, 2024 23:03

add plus icon

1c54290

show receipt placeholder for money request preview

0580544

gijoe0295 changed the title ~~[WIP] Feat: Add placeholder thumbnail to expenses with no receipt~~ Feat: Add placeholder thumbnail to expenses with no receipt Nov 21, 2024

gijoe0295 marked this pull request as ready for review November 21, 2024 17:16

gijoe0295 requested review from a team as code owners November 21, 2024 17:16

melvin-bot bot requested review from brunovjk and removed request for a team November 21, 2024 17:16

Merge branch 'main' of https://github.com/gijoe0295/App into gijoe/52638

5425a6b

gijoe0295 added 2 commits November 26, 2024 23:05

Merge branch 'main' of https://github.com/gijoe0295/App into gijoe/52638

58a26bd

remove redundant border

b115402

This comment was marked as outdated.

Sign in to view

pass onPress to open report when pressing empty receipt

61171d0

This comment was marked as outdated.

Sign in to view

gijoe0295 added 2 commits December 1, 2024 17:18

Merge branch 'main' of https://github.com/gijoe0295/App into gijoe/52638

3063b25

fix add receipt placeholder shows in iou confirmation page after addi…

874c2e0

…ng a receipt

brunovjk approved these changes Dec 2, 2024

View reviewed changes

melvin-bot bot requested a review from jasperhuangg December 2, 2024 19:02

dannymcclain added the Ready To Build label Dec 2, 2024

jasperhuangg approved these changes Dec 3, 2024

View reviewed changes

jasperhuangg merged commit 1ead788 into Expensify:main Dec 3, 2024

github-actions bot mentioned this pull request Dec 4, 2024

Deploy Checklist: New Expensify 2024-12-04 #53504

Closed

35 tasks

shubham1206agra mentioned this pull request Dec 4, 2024

[HOLD for payment 2025-01-07] Expense - Receipt placeholder is blank without receipt icon when expense is deleted offline #53532

Closed

8 tasks

melvin-bot bot mentioned this pull request Dec 5, 2024

[HOLD for payment 2025-01-07] [$125] Add placeholder thumbnail to expenses with no receipt #52638

Closed

rojiphil mentioned this pull request Dec 11, 2024

[Awaiting Payment] [$250] Split & Invoice -Preview shows empty receipt placeholder when there is no way to add a receipt #53524

Closed

8 tasks

brunovjk mentioned this pull request Dec 12, 2024

fix: blank receipt holder when delete expense offline #54051

Merged

50 tasks

suneox reviewed Dec 30, 2024

View reviewed changes

brunovjk mentioned this pull request Jan 6, 2025

[HOLD for payment 2025-01-13] [HOLD for payment 2025-01-07] [$250] Track Expense - Website crashes when submitting a track expense. #54605

Closed

8 tasks

Conversation

gijoe0295 commented Nov 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 21, 2024

Uh oh!

shawnborton commented Nov 21, 2024

Uh oh!

brunovjk commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dannymcclain commented Nov 22, 2024

Uh oh!

brunovjk commented Nov 26, 2024

Uh oh!

gijoe0295 commented Nov 26, 2024

Uh oh!

gijoe0295 commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

brunovjk commented Nov 26, 2024

Uh oh!

gijoe0295 commented Nov 26, 2024

Uh oh!

brunovjk commented Nov 26, 2024

Uh oh!

brunovjk commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

This comment was marked as outdated.

brunovjk commented Nov 26, 2024

Uh oh!

brunovjk commented Nov 28, 2024

Uh oh!

gijoe0295 commented Dec 1, 2024

Uh oh!

brunovjk left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dannymcclain commented Dec 2, 2024

Uh oh!

github-actions bot commented Dec 2, 2024

Uh oh!

github-actions bot commented Dec 2, 2024

Uh oh!

shawnborton commented Dec 2, 2024

Uh oh!

dannymcclain commented Dec 2, 2024

Uh oh!

OSBotify commented Dec 3, 2024

Uh oh!

github-actions bot commented Dec 4, 2024

Uh oh!

github-actions bot commented Dec 5, 2024

Uh oh!

suneox Dec 30, 2024

Choose a reason for hiding this comment

Uh oh!

brunovjk commented Jan 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

gijoe0295 commented Nov 20, 2024 •

edited

Loading

brunovjk commented Nov 22, 2024 •

edited

Loading

gijoe0295 commented Nov 26, 2024 •

edited

Loading

brunovjk commented Nov 26, 2024 •

edited

Loading

brunovjk left a comment •

edited

Loading