Page do scroll to bottom when send message in public room by luckydaniel1993 · Pull Request #52955 · Expensify/App

luckydaniel1993 · 2024-11-22T11:52:56Z

@akinwale

Explanation of Change

I've wrapped the scrollToBottomForCurrentUserAction function with InteractionManager.runAfterInteractions.

Fixed Issues

$ #52208.
PROPOSAL: #52208 (comment)

Tests

Log in with gmail.
Open #expensify-roadmap public room (https://staging.new.expensify.com/r/2091104345528462)
Scroll to the top of the page
Send a message
Verify that: Page will scroll to bottom

Verify that no errors appear in the JS console

Offline tests

QA Steps

Log in with gmail.
Open #expensify-roadmap public room (https://staging.new.expensify.com/r/2091104345528462)
Scroll to the top of the page
Send a message
Verify that: Page will scroll to bottom

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

test.mp4

Android: mWeb Chrome

video1.mp4

iOS: Native

Recording.2024-12-08.183806.mp4

iOS: mWeb Safari

Recording.2024-12-08.190941.mp4

MacOS: Chrome / Safari

386153028-162ba043-9a48-42a8-bb62-41d66ed71dc7.mp4

MacOS: Desktop

Recording.2024-12-06.151751.mp4

…terInteractions

melvin-bot · 2024-11-22T11:53:02Z

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

akinwale · 2024-11-27T06:05:02Z

@anaslancer Please check all the boxes in the checklist.

akinwale · 2024-11-27T06:12:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

52955-android-native.mp4

Android: mWeb Chrome

52955-android-chrome.mp4

iOS: Native

52955-ios-native.mp4

iOS: mWeb Safari

52955-ios-safari.mp4

MacOS: Chrome / Safari

52208-web.mp4

MacOS: Desktop

52208-desktop.mp4

akinwale

LGTM.

akinwale

@anaslancer

You need to complete the following in the initial post.

Complete the checklist, meaning check all the boxes
Include your testing videos / screenshots for each platform

aldo-expensify · 2024-11-29T18:59:27Z

@anaslancer bump on #52955 (review)

aldo-expensify · 2024-12-04T18:31:32Z

Hey @anaslancer 👋 , are planning to finish the PR here?, it was pretty closed to be ready for merging, we just need you to follow the process of including the testing videos/screenshots.

luckydaniel1993 · 2024-12-04T18:39:10Z

@aldo-expensify I will add the videos in a few days. Thanks

aldo-expensify · 2024-12-04T18:47:12Z

@aldo-expensify I will add the videos in a few days. Thanks

Does a "few days" mean this week? or can it be longer

luckydaniel1993 · 2024-12-04T19:06:29Z

It will be this week, I am waiting my new mac.

aldo-expensify · 2024-12-04T20:41:14Z

It will be this week, I am waiting my new mac.

Ah, that is great, thanks for the information!

akinwale · 2024-12-13T06:29:02Z

@anaslancer Any updates here?

luckydaniel1993 · 2024-12-13T10:55:51Z

I am getting this error when npm run android;

Could not determine the dependencies of task ':react-native:packages:react-native:ReactAndroid:hermes-engine:configureBuildForHermes'.
> Could not create task ':react-native:packages:react-native:ReactAndroid:hermes-engine:installCMake'.
   > Could not find sdkmanager executable.

akinwale · 2024-12-13T11:01:19Z

I am getting this error when npm run android;

Could not determine the dependencies of task ':react-native:packages:react-native:ReactAndroid:hermes-engine:configureBuildForHermes'.
> Could not create task ':react-native:packages:react-native:ReactAndroid:hermes-engine:installCMake'.
   > Could not find sdkmanager executable.

@anaslancer Make sure you have your ANDROID_HOME environment variable set. You would also need to install the Android SDK build tools and platform tools (if not yet installed) on Android Studio. Launch Android Studio > Settings > Languages & Framework > Android SDK, select the SDK tools tab and then choose the missing dependencies to install.

luckydaniel1993 · 2024-12-13T11:05:37Z

luckydaniel1993 · 2024-12-13T11:07:41Z

akinwale · 2024-12-13T11:58:49Z

Check in the SDK Tools tab.

luckydaniel1993 · 2024-12-13T12:22:48Z

akinwale · 2024-12-13T13:58:53Z

@anaslancer You can ask for guidance on this in the #expensify-open-source Slack channel if you are unable to resolve the problem.

luckydaniel1993 · 2024-12-13T14:01:25Z

But I don't have slack account for Expensify

luckydaniel1993 · 2024-12-13T14:02:26Z

I requested before but they said they can't accept. Let me request again?

luckydaniel1993 · 2024-12-15T01:29:22Z

Finally, I figured out we can't use Windows for android. I built it on MacOS

luckydaniel1993 · 2024-12-16T10:56:23Z

@akinwale I've uploaded all videos.

akinwale

LGTM.

akinwale · 2024-12-16T11:52:37Z

@aldo-expensify All test videos have been uploaded. This is ready for your review.

aldo-expensify · 2024-12-16T13:27:41Z

Nice, thank you!

github-actions · 2024-12-18T13:37:02Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.0.77-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

izarutskaya · 2024-12-19T10:20:22Z

@anaslancer PR is failing with #54307, #52208

https://platform.applause.com/services/links/v1/external/b16e1117fd1bfbcbdf6666fb81b175a8d383bba5c40f2d6cc2abf21431fc3565

https://platform.applause.com/services/links/v1/external/4972c62cffd12297fc4c53e245993a44fefe4969795d8ba213aef3a6a1425298

luckydaniel1993 · 2024-12-19T12:32:49Z

@akinwale , after pulling the code from staging, I can't run on web. Do you know why? Seems like web socket error
cc @aldo-expensify

aldo-expensify · 2024-12-19T13:56:08Z

Not sure what it may be, can you post a screenshot?

luckydaniel1993 · 2024-12-19T14:03:12Z

aldo-expensify · 2024-12-19T14:13:28Z

Could you be missing a dependency? did you try running npm install?

luckydaniel1993 · 2024-12-19T14:18:15Z

Nope, I will try now

luckydaniel1993 · 2024-12-20T11:53:25Z

I am going to have a travel, and will fix once back.

github-actions · 2024-12-23T20:59:13Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.77-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

wrap scrollToBottomForCurrentUserAction with InteractionManager.runAf…

4628a5b

…terInteractions

luckydaniel1993 requested a review from a team as a code owner November 22, 2024 11:52

melvin-bot bot requested review from akinwale and removed request for a team November 22, 2024 11:53

akinwale approved these changes Nov 27, 2024

View reviewed changes

melvin-bot bot requested a review from aldo-expensify November 27, 2024 06:12

akinwale suggested changes Nov 27, 2024

View reviewed changes

aldo-expensify mentioned this pull request Nov 29, 2024

[HOLD for payment 2024-12-30] [$250] Room - Page does not scroll to bottom when send message in #expensify-roadmap public room #52208

Closed

8 tasks

luckydaniel1993 requested a review from akinwale December 16, 2024 11:21

akinwale approved these changes Dec 16, 2024

View reviewed changes

aldo-expensify approved these changes Dec 16, 2024

View reviewed changes

aldo-expensify merged commit 7d5bf75 into Expensify:main Dec 16, 2024

github-actions bot mentioned this pull request Dec 18, 2024

Deploy Checklist: New Expensify 2024-12-18 #54292

Closed

72 tasks

IuliiaHerets mentioned this pull request Dec 18, 2024

[$250] Web - Chat history scroll takes infinite #54307

Closed

8 tasks

nkdengineer mentioned this pull request Dec 26, 2024

[HOLD for payment 2025-01-17] [$250] Page not scroll down when hold and unhold expense #54580

Closed

8 tasks

blazejkustra mentioned this pull request Feb 20, 2026

[BATCH 6] Migrate scroll operations #83067

Open

Conversation

luckydaniel1993 commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 22, 2024

Uh oh!

akinwale commented Nov 27, 2024

Uh oh!

akinwale commented Nov 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

akinwale left a comment

Choose a reason for hiding this comment

Uh oh!

akinwale left a comment

Choose a reason for hiding this comment

Uh oh!

aldo-expensify commented Nov 29, 2024

Uh oh!

aldo-expensify commented Dec 4, 2024

Uh oh!

luckydaniel1993 commented Dec 4, 2024

Uh oh!

aldo-expensify commented Dec 4, 2024

Uh oh!

luckydaniel1993 commented Dec 4, 2024

Uh oh!

aldo-expensify commented Dec 4, 2024

Uh oh!

akinwale commented Dec 13, 2024

Uh oh!

luckydaniel1993 commented Dec 13, 2024

Uh oh!

akinwale commented Dec 13, 2024

Uh oh!

luckydaniel1993 commented Dec 13, 2024

Uh oh!

luckydaniel1993 commented Dec 13, 2024

Uh oh!

akinwale commented Dec 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luckydaniel1993 commented Dec 13, 2024

Uh oh!

akinwale commented Dec 13, 2024

Uh oh!

luckydaniel1993 commented Dec 13, 2024

Uh oh!

luckydaniel1993 commented Dec 13, 2024

Uh oh!

luckydaniel1993 commented Dec 15, 2024

Uh oh!

luckydaniel1993 commented Dec 16, 2024

Uh oh!

akinwale left a comment

Choose a reason for hiding this comment

Uh oh!

akinwale commented Dec 16, 2024

Uh oh!

aldo-expensify commented Dec 16, 2024

Uh oh!

github-actions bot commented Dec 18, 2024

Uh oh!

izarutskaya commented Dec 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luckydaniel1993 commented Dec 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aldo-expensify commented Dec 19, 2024

Uh oh!

luckydaniel1993 commented Nov 22, 2024 •

edited

Loading

akinwale commented Nov 27, 2024 •

edited

Loading

akinwale commented Dec 13, 2024 •

edited

Loading

izarutskaya commented Dec 19, 2024 •

edited

Loading

luckydaniel1993 commented Dec 19, 2024 •

edited

Loading