feat: There is no way to identify the primary workspace, making it appear essentially random. by Krishna2323 · Pull Request #53048 · Expensify/App

Krishna2323 · 2024-11-24T23:10:41Z

Explanation of Change

Fixed Issues

$ #52373
PROPOSAL: #52373 (comment)

Tests

Go to workspaces page
Verify default badge is displayed on active policy
Open three dot menu of the default policy > verify Set as default workspace is not shown.
Open three dot menu of any other policy > verify Set as default workspace is shown.
Click on Set as default workspace option > verify active policy is changed
Go back and open FAB menu > select Start chat > Select Room tab
Verify the new default policy is selected by default in workspace field

Verify that no errors appear in the JS console

Offline tests

Go to workspaces page
Verify default badge is displayed on active policy
Open three dot menu of the default policy > verify Set as default workspace is not shown.
Open three dot menu of any other policy > verify Set as default workspace is shown.
Click on Set as default workspace option > verify active policy is changed
Go back and open FAB menu > select Start chat > Select Room tab
Verify the new default policy is selected by default in workspace field

QA Steps

Go to workspaces page
Verify default badge is displayed on active policy
Open three dot menu of the default policy > verify Set as default workspace is not shown.
Open three dot menu of any other policy > verify Set as default workspace is shown.
Click on Set as default workspace option > verify active policy is changed
Go back and open FAB menu > select Start chat > Select Room tab
Verify the new default policy is selected by default in workspace field

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…pear essentially random. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot · 2024-11-24T23:10:46Z

@dubielzyk-expensify @Ollyws One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Krishna2323 · 2024-11-24T23:11:19Z

will add the screenshots once we add the api to update the active policy.

Krishna2323 · 2024-11-24T23:14:27Z

src/libs/actions/Policy/Policy.ts

+        policyID: newPolicyID,
+    };
+
+    API.write(WRITE_COMMANDS.UPDATE_ACTIVE_POLICY, parameters, {


@grgia, what will the api endpoint to update the active policy id? For now I added UPDATE_ACTIVE_POLICY: 'UpdateActivePolicy', in the WRITE_COMMANDS file.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

dubielzyk-expensify · 2024-11-24T23:34:28Z

Let me know when you got screenshots for me to look at 😄

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2024-12-13T13:16:07Z

@Expensify/design, please review the video below.

Do we want to show some kind of feedback when we make a workspace default in offline mode?

Monosnap.screencast.2024-12-13.18-42-41.mp4

Krishna2323 · 2024-12-16T22:10:25Z

@Expensify/design, please check the comment above ^

dubielzyk-expensify · 2024-12-17T04:00:14Z

I'm unsure what the right pattern is here, but I feel like we can optimistically save the Default mode and show the badge, assuming it'll update when it's online? Thoughts @Expensify/design and @trjExpensify ?

trjExpensify · 2024-12-17T12:11:07Z

Yeah, I think the question is which offline pattern to use for this. I think Pattern A ("optimistic without feedback") is fine for this, no need for the pending UI when changed offline.

Krishna2323 · 2024-12-18T08:47:51Z

@Expensify/design, the screenshots are up for review.

@Ollyws, this can be reviewed now. I haven't uploaded the video for android native because of build issues, I hope that's not a blocker.

shawnborton · 2024-12-18T13:40:47Z

They look good to me 👍

Ollyws · 2024-12-19T13:55:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

01_Android_Native.mp4

Android: mWeb Chrome

02_Android_Chrome.mp4

iOS: Native

03_iOS_Native.mp4

iOS: mWeb Safari

04_iOS_Safari.mp4

MacOS: Chrome / Safari

05_MacOS_Chrome.mp4

MacOS: Desktop

06_MacOS_Desktop.mp4

Ollyws

Code looks good and tests well!

dubielzyk-expensify

LGTM from design standpoint 👍

grgia

Could you fix the new ESLint? Thank you 🙏

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2024-12-20T18:24:27Z

@grgia ESLint issue is fixed 🙇🏻

Krishna2323 · 2024-12-26T12:52:03Z

@grgia, friendly bump for a final review.

grgia

Thank you!! I'll trigger a test build now to double check QA 😁

github-actions · 2025-01-03T16:16:28Z

🚧 @grgia has triggered a test build. You can view the workflow run here.

github-actions · 2025-01-03T16:40:29Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/53048/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/53048/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/53048/NewExpensify.dmg	https://53048.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2025-01-03T18:24:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-06T18:33:04Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.0.81-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-08T02:43:55Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.81-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

thesahindia · 2025-02-10T18:51:16Z

src/pages/workspace/WorkspacesListRow.tsx

                </View>
            )}
+            {!!isDefault && (
+                <Tooltip


#54955 was caused because of not specifying number of lines

Krishna2323 added 2 commits November 25, 2024 04:28

feat: There is no way to identify the primary workspace, making it ap…

07e6427

…pear essentially random. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

add translation.

2c85e76

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 requested a review from a team as a code owner November 24, 2024 23:10

melvin-bot bot requested review from Ollyws and dubielzyk-expensify and removed request for a team November 24, 2024 23:10

Krishna2323 marked this pull request as draft November 24, 2024 23:10

Krishna2323 commented Nov 24, 2024

View reviewed changes

add UpdateActivePolicyParams file.

9a0c399

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 mentioned this pull request Nov 26, 2024

[HOLD for payment 2025-01-15] [$250] There is no way to identify the primary workspace, making it appear essentially random #52373

Closed

8 tasks

Krishna2323 added 4 commits December 4, 2024 02:16

Merge branch 'main' into krishna2323/issue/52373

31c4264

Merge branch 'main' into krishna2323/issue/52373

4fe9ed4

use SetNameValuePair for updating active policy.

f674894

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Merge branch 'Expensify:main' into krishna2323/issue/52373

8f295c4

Merge branch 'Expensify:main' into krishna2323/issue/52373

5a11832

Krishna2323 marked this pull request as ready for review December 18, 2024 08:45

Ollyws approved these changes Dec 19, 2024

View reviewed changes

melvin-bot bot requested a review from grgia December 19, 2024 13:55

dubielzyk-expensify previously approved these changes Dec 19, 2024

View reviewed changes

grgia previously approved these changes Dec 20, 2024

View reviewed changes

Krishna2323 added 2 commits December 20, 2024 23:18

Merge branch 'Expensify:main' into krishna2323/issue/52373

773e8ee

fix eslint.

0bee7ba

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 dismissed stale reviews from grgia and dubielzyk-expensify via 0bee7ba December 20, 2024 18:07

Merge branch 'Expensify:main' into krishna2323/issue/52373

fb39249

Merge branch 'main' into krishna2323/issue/52373

b5031a8

grgia approved these changes Jan 3, 2025

View reviewed changes

grgia added the Ready To Build label Jan 3, 2025

grgia merged commit d60500a into Expensify:main Jan 3, 2025

github-actions bot mentioned this pull request Jan 6, 2025

Deploy Checklist: New Expensify 2025-01-06 #54825

Closed

74 tasks

thesahindia reviewed Feb 10, 2025

View reviewed changes

Conversation

Krishna2323 commented Nov 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 24, 2024

Uh oh!

Krishna2323 commented Nov 24, 2024

Uh oh!

Krishna2323 Nov 24, 2024

Choose a reason for hiding this comment

Uh oh!

dubielzyk-expensify commented Nov 24, 2024

Uh oh!

Krishna2323 commented Dec 13, 2024

Uh oh!

Krishna2323 commented Dec 16, 2024

Uh oh!

dubielzyk-expensify commented Dec 17, 2024

Uh oh!

trjExpensify commented Dec 17, 2024

Uh oh!

Krishna2323 commented Dec 18, 2024

Uh oh!

shawnborton commented Dec 18, 2024

Uh oh!

Ollyws commented Dec 19, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

Ollyws left a comment

Choose a reason for hiding this comment

Uh oh!

dubielzyk-expensify left a comment

Choose a reason for hiding this comment

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

Krishna2323 commented Dec 20, 2024

Uh oh!

Krishna2323 commented Dec 26, 2024

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 3, 2025

Uh oh!

github-actions bot commented Jan 3, 2025

Uh oh!

OSBotify commented Jan 3, 2025

Uh oh!

github-actions bot commented Jan 6, 2025

Uh oh!

github-actions bot commented Jan 8, 2025

Uh oh!

thesahindia Feb 10, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Krishna2323 commented Nov 24, 2024 •

edited

Loading