add go to workspace shortcut to report details page#53076
add go to workspace shortcut to report details page#53076youssef-lr merged 9 commits intoExpensify:mainfrom
Conversation
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Code change looks fine. Waiting for the confirmation on this one |
|
@mkzie2 We'll need to ensure that the shortcut is only shown for Workspace expenses and not 1:1 chats. web-error-go-to-workspace-chat-expense.mov |
|
@mananjadhav I updated. |
|
@mananjadhav I also rearrange the |
|
Reviewing the PR |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid-go-to-workspace.movAndroid: mWeb Chromemweb-chrome-go-to-workspace.moviOS: Nativeios-go-to-workspace.moviOS: mWeb Safarimweb-safari-go-to-workspace.movMacOS: Chrome / Safariweb-go-to-workspace.movMacOS: Desktopdesktop-go-to-workspace.mov |
|
I'm veeery keen to get this one merged and onto prod this week. I keep watching sessions of people going to the workspace chat details looking for workspace settings. |
|
We're waiting for the final review from @mananjadhav |
|
I started with the checklist but had issues with the app last night. I'll be online in 1-2 hours and will pick this first thing. |
|
@trjExpensify The workspace page back generally takes back to the workspace list. Should we modify the behavior here to go to the last chat? desktop-go-to-workspace.mov |
|
Hm, good question. We're in the process of rolling out persisting the bottom tabs when in the workspace editor, so you'd be "switched" to the Settings bottom tab and there won't be a back caret in the workspace editor anymore here, so I think it's fine not to worry about it in the interim. CC: @mountiny @luacmartins for a second opinion. |
|
I agree. We'll remove that back caret soon, so let's not worry about it here. |
|
Thanks for confirming. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
|
🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.0.73-0 🚀
|
|
Sure. |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.73-8 🚀
|
Explanation of Change
Fixed Issues
$ #52817
PROPOSAL: #52817 (comment)
Tests
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2024-11-25.at.23.58.09-compressed.mov
Android: mWeb Chrome
Screen.Recording.2024-11-26.at.00.00.11.mov
iOS: Native
Screen.Recording.2024-11-25.at.23.55.19.mov
iOS: mWeb Safari
Screen.Recording.2024-11-25.at.23.57.08-compressed.mov
MacOS: Chrome / Safari
MacOS: Desktop