Skip to content

Green dot disappears from LHN when paying one out of many unpaid reports #53137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristipaval merged 10 commits into from
Mar 7, 2025
Merged

Green dot disappears from LHN when paying one out of many unpaid reports #53137

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ffc8ca6
Green dot disappears from LHN when paying one out of many unpaid reports
tienifr Nov 26, 2024
faf6988
fix conflicts
tienifr Feb 20, 2025
3d6fe26
lint fix
tienifr Feb 20, 2025
f522eb6
use default value
tienifr Feb 20, 2025
b6b2fce
fix type
tienifr Feb 20, 2025
716e747
Merge branch 'main' into fix/34767
tienifr Feb 26, 2025
b304d59
Merge branch 'main' into fix/34767
tienifr Mar 3, 2025
7c2b714
update hasOutstandingChildRequest
tienifr Mar 3, 2025
fb9474f
Merge branch 'main' into fix/34767
tienifr Mar 7, 2025
e71dff4
add ach account check
tienifr Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/libs/actions/IOU.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ import {addSMSDomainIfPhoneNumber} from '@libs/PhoneNumber';
import {getPerDiemCustomUnit, getPolicy, getSubmitToAccountID, hasDependentTags, isControlPolicy, isPaidGroupPolicy, isPolicyAdmin, isSubmitAndClose} from '@libs/PolicyUtils';
import {
getAllReportActions,
getIOUReportIDFromReportActionPreview,
getLastVisibleAction,
getLastVisibleMessage,
getOriginalMessage,
Expand Down Expand Up @@ -7851,6 +7852,23 @@ function getReportFromHoldRequestsOnyxData(
};
}

function hasOutstandingChildRequest(chatReport: OnyxTypes.Report, excludedIOUReport: OnyxEntry<OnyxTypes.Report>, policyId?: string) {
const policy = getPolicy(policyId);
if (!policy?.achAccount?.bankAccountID) {
return false;
}
const reportActions = getAllReportActions(chatReport.reportID);
return !!Object.values(reportActions).find((action) => {
const iouReportID = getIOUReportIDFromReportActionPreview(action);
if (iouReportID === excludedIOUReport?.reportID) {
return false;
}
const iouReport = getReportOrDraftReport(iouReportID);
const transactions = getReportTransactions(iouReportID);
return canIOUBePaid(iouReport, chatReport, policy, transactions) || canIOUBePaid(iouReport, chatReport, policy, transactions, true);
});
}

function getPayMoneyRequestParams(
initialChatReport: OnyxTypes.Report,
iouReport: OnyxEntry<OnyxTypes.Report>,
Expand Down Expand Up @@ -7937,7 +7955,7 @@ function getPayMoneyRequestParams(
const optimisticChatReport = {
...chatReport,
lastReadTime: DateUtils.getDBTime(),
hasOutstandingChildRequest: false,
hasOutstandingChildRequest: hasOutstandingChildRequest(chatReport, iouReport, iouReport?.policyID),
iouReportID: null,
lastMessageText: getReportActionText(optimisticIOUReportAction),
lastMessageHtml: getReportActionHtml(optimisticIOUReportAction),
Expand Down