Remove Zip Code validation from Add a payment card page by ikevin127 · Pull Request #53178 · Expensify/App

ikevin127 · 2024-11-26T23:51:26Z

Explanation of Change

After getting feedback from the team in #52642 (comment), we decided to completely remove Zip Code validation in order to aligh with OD, meaning the only validation left in the Payment Card form for the Zip Code is that the field is required.

Fixed Issues

$ #52642
PROPOSAL: #52642 (comment)

Tests

Go to Settings.
Go to Subscriptions.
Click Add a payment card.
Verify that no specific Zip Code format is required other that the field itself being required (can't be left empty) regardless of the selected currency (USD, GBP or any other available).

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps.

QA Steps

Go to Settings.
Go to Subscriptions.
Click Add a payment card.
Verify that no specific Zip Code format is required other that the field itself being required (can't be left empty) regardless of the selected currency (USD, GBP or any other available).

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Add a payment card page is not available on native:

App/src/pages/settings/Subscription/PaymentCard/index.native.tsx

Lines 5 to 15 in c4ff235

    
           function AddPaymentCard() { 
        
               return ( 
        
                   <ScreenWrapper 
        
                       testID={AddPaymentCard.displayName} 
        
                       includeSafeAreaPaddingBottom 
        
                       shouldEnableMaxHeight 
        
                   > 
        
                       <FullPageNotFoundView shouldShow /> 
        
                   </ScreenWrapper> 
        
               ); 
        
           }

Android: mWeb Chrome

screen-20241126-154123.mp4

iOS: Native

Add a payment card page is not available on native:

App/src/pages/settings/Subscription/PaymentCard/index.native.tsx

Lines 5 to 15 in c4ff235

    
           function AddPaymentCard() { 
        
               return ( 
        
                   <ScreenWrapper 
        
                       testID={AddPaymentCard.displayName} 
        
                       includeSafeAreaPaddingBottom 
        
                       shouldEnableMaxHeight 
        
                   > 
        
                       <FullPageNotFoundView shouldShow /> 
        
                   </ScreenWrapper> 
        
               ); 
        
           }

iOS: mWeb Safari

ios-mweb.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

ikevin127 · 2024-11-26T23:55:41Z

src/components/AddPaymentCard/PaymentCardForm.tsx

                    label={translate('common.zip')}
                    aria-label={translate('common.zip')}
                    role={CONST.ROLE.PRESENTATION}
-                    inputMode={CONST.INPUT_MODE.NUMERIC}


I removed this line because on mWeb platforms this would only allow numeric input which would restrict users from typing UK Zip Codes what contain characters and numbers (ex. SW8 4LT). The issue was present on iOS: mWeb as well, here's an example from Android: mWeb before and after removing the line:

Before After

that makes sense, thanks

ikevin127 · 2024-11-26T23:58:04Z

Note

No testing was done on Native platforms because the Add a payment card page is not available on native:

App/src/pages/settings/Subscription/PaymentCard/index.native.tsx

Lines 5 to 15 in c4ff235

    
           function AddPaymentCard() { 
        
               return ( 
        
                   <ScreenWrapper 
        
                       testID={AddPaymentCard.displayName} 
        
                       includeSafeAreaPaddingBottom 
        
                       shouldEnableMaxHeight 
        
                   > 
        
                       <FullPageNotFoundView shouldShow /> 
        
                   </ScreenWrapper> 
        
               ); 
        
           }

melvin-bot · 2024-11-27T19:47:56Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ikevin127 · 2024-12-02T22:08:30Z

@getusha It has been 5 days without any updates regarding review - any updates on this ?

getusha · 2024-12-03T12:29:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

N/a

Android: mWeb Chrome

Screen.Recording.2024-12-03.at.5.20.50.in.the.afternoon.mov

iOS: Native

N/a

iOS: mWeb Safari

Screen.Recording.2024-12-03.at.5.21.24.in.the.afternoon.mov

MacOS: Chrome / Safari

Screen.Recording.2024-12-03.at.5.15.47.in.the.afternoon.mov

MacOS: Desktop

Screen.Recording.2024-12-03.at.5.26.43.in.the.afternoon.mov

getusha · 2024-12-03T14:27:41Z

src/components/AddPaymentCard/PaymentCardForm.tsx

            errors.addressStreet = translate(label.error.addressStreet);
        }

-        if (values.addressZipCode && !ValidationUtils.isValidZipCode(values.addressZipCode)) {


should we add a comment to prevent others reverting this change?

I think the change will be visible in blame which will lead to this PR / issue and it's self explanatory that we removed the specific Zip Code validation for time being, the explanation being visible in the PRs description.

Updated postcode input label to match the label found in the form on Settings > Profile > Private > Address , as requested in Expensify#52642 (comment).

ikevin127 · 2024-12-03T23:33:00Z

@danieldoglas The PR is ready to be merged, the latest commit was an input labal change request asked last minute in the issue #52642 (comment).

OSBotify · 2024-12-04T17:49:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-05T15:17:10Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.0.72-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-05T16:02:17Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.0.72-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-09T16:05:32Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.72-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

ikevin127 added 2 commits November 26, 2024 14:26

Remove payment card form Zip Code validation

6990c38

Removed inputMode to allow non-numeric Zip Codes (UK)

0e29ba1

ikevin127 commented Nov 26, 2024

View reviewed changes

ikevin127 mentioned this pull request Nov 27, 2024

[HOLD for payment 2024-12-16] [$125] Error message displayed when adding a UK zip code to a GBP payment card #52642

Closed

8 tasks

ikevin127 marked this pull request as ready for review November 27, 2024 19:47

ikevin127 requested a review from a team as a code owner November 27, 2024 19:47

melvin-bot bot requested review from getusha and removed request for a team November 27, 2024 19:47

getusha reviewed Dec 3, 2024

View reviewed changes

getusha approved these changes Dec 3, 2024

View reviewed changes

melvin-bot bot requested a review from danieldoglas December 3, 2024 14:28

updated postcode input label

2ad0ddf

Updated postcode input label to match the label found in the form on Settings > Profile > Private > Address , as requested in Expensify#52642 (comment).

getusha approved these changes Dec 4, 2024

View reviewed changes

danieldoglas approved these changes Dec 4, 2024

View reviewed changes

danieldoglas merged commit aa55b4d into Expensify:main Dec 4, 2024

github-actions bot mentioned this pull request Dec 5, 2024

Deploy Checklist: New Expensify 2024-12-05 #53631

Closed

43 tasks

allgandalf mentioned this pull request Jan 22, 2025

[PAID] [$250] Error message is not displayed when entering characters that cannot be in a zip code #53918

Closed

8 tasks

ikevin127 mentioned this pull request Jan 24, 2025

[HOLD for payment 2025-02-05] [HOLD for payment 2025-02-04] [$250] Valid Australian postcodes are not accepted when adding a payment card #55493

Closed

8 tasks

	function AddPaymentCard() {
	return (
	<ScreenWrapper
	testID={AddPaymentCard.displayName}
	includeSafeAreaPaddingBottom
	shouldEnableMaxHeight
	>
	<FullPageNotFoundView shouldShow />
	</ScreenWrapper>
	);
	}

Conversation

ikevin127 commented Nov 26, 2024

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

ikevin127 Nov 26, 2024

Choose a reason for hiding this comment

Uh oh!

getusha Dec 3, 2024

Choose a reason for hiding this comment

Uh oh!

ikevin127 commented Nov 26, 2024

Uh oh!

melvin-bot bot commented Nov 27, 2024

Uh oh!

ikevin127 commented Dec 2, 2024

Uh oh!

getusha commented Dec 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

getusha Dec 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ikevin127 Dec 3, 2024

Choose a reason for hiding this comment

Uh oh!

ikevin127 commented Dec 3, 2024

Uh oh!

OSBotify commented Dec 4, 2024

Uh oh!

github-actions bot commented Dec 5, 2024

Uh oh!

github-actions bot commented Dec 5, 2024

Uh oh!

github-actions bot commented Dec 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

getusha commented Dec 3, 2024 •

edited

Loading

getusha Dec 3, 2024 •

edited

Loading