fix categories imported are disabled#53246
Merged
mountiny merged 5 commits intoExpensify:mainfrom Dec 6, 2024
Merged
Conversation
Contributor
|
@getusha what is your eta on the review? |
getusha
reviewed
Dec 4, 2024
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-12-04.at.5.31.46.in.the.afternoon.movAndroid: mWeb ChromeScreen.Recording.2024-12-04.at.5.19.53.in.the.afternoon.moviOS: NativeScreen.Recording.2024-12-04.at.6.55.28.in.the.evening.moviOS: mWeb SafariScreen.Recording.2024-12-04.at.6.22.50.in.the.evening.movMacOS: Chrome / SafariScreen.Recording.2024-12-04.at.4.39.55.in.the.afternoon.movMacOS: DesktopScreen.Recording.2024-12-04.at.6.13.00.in.the.evening.mov |
Contributor
|
@huult do you think we can add a unit test for this? |
Contributor
Author
|
@getusha This only transforms data to a string and doesn’t involve complex logic or state changes. const data = [
"hello",
42,
123456789012345n,
true,
undefined,
Symbol('id'),
null
];
const stringified = data.map(item => String(item));We can test all data types like boolean and number or ... converting to string without any errors. Therefore, a unit test might not be necessary. Let me know if you think otherwise! |
Contributor
Sounds fair, @mountiny wdyt? |
…s-imported-are-disabled
Contributor
Author
|
@mountiny I am writing the unit test now |
Contributor
Author
|
@mountiny I encountered some issues while setting up ImportSpreadSheetTest, so I will continue tomorrow. I will ping you when it's done. |
…s-imported-are-disabled
Contributor
Author
|
@mountiny Can we skip the unit tests for this pull request? I tried, but it's more complex than I expected |
Contributor
|
Alright, thanks for looking into this |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
github-actions
bot
added
the
DeployBlockerCash
Contributor
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
Contributor
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
70 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.73-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.73-8 🚀
|
Closed
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #52466
PROPOSAL: #52466 (comment)
Tests
Same QA step
Offline tests
QA Steps
Bug6663366_1731473053062.Applausecard_s_Workspace_categories (1).csv
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2024-11-28.at.21.37.29.mp4
Android: mWeb Chrome
Screen.Recording.2024-11-28.at.21.38.26.mp4
iOS: Native
Screen.Recording.2024-11-28.at.21.45.07.mp4
iOS: mWeb Safari
Screen.Recording.2024-11-28.at.21.45.52.mp4
MacOS: Chrome / Safari
Screen.Recording.2024-11-28.at.21.46.26.mp4
MacOS: Desktop
Screen.Recording.2024-11-28.at.21.48.15.mp4