Update labels in VBA flow to have correct spacing #5329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelvinBot
requested review from
stitesExpensify
and removed request for
a team
stitesExpensify
approved these changes
Sep 20, 2021
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
31 tasks
Contributor
|
🚀 Deployed to staging by @stitesExpensify in version: 1.0.99-5 🚀
|
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR updates some labels that had incorrect spacing on iOS and Android while navigating the VBA flow. This fix uses the translateX prop introduced in #3414 to make these changes, eventually, we may want to refactor that since the spacing is not uniform for all inputs across the app, but for N6 this approach will work.
Fixed Issues
Fixes issue from discussion in slack
Tests/QA
First Name,Last Name,City,Incorporation Datespecifically, as this PR fixes thoseTested On
Screenshots
Company Info
Personal Info