[CP Staging] Fix chat view in search router by aldo-expensify · Pull Request #53293 · Expensify/App

aldo-expensify · 2024-11-28T22:05:50Z

Explanation of Change

The refactor #52568 seems to have missed passing some parameters

cc @Kicu @SzymczakJ @hannojg if you can take a look here when you have time 🙏

Fixed Issues

$ #53291
$ #53289
PROPOSAL:

Tests

Case 1: Group found in search should show the last message

Create a group chat between 3 users
Send a message in the group
Click the Search button on the top right
Verify that the group appearing search shows the last sent message

Case 2: Bold title show reflect read status

Create a DM between 2 users
Send a message from account A
Make the message read account B
Using account B, find the DM in the search to the top right:
Verify the title of the option is not bolded ("sad" is the title in the picture above)
Using account B, go to another chat (your concierge chat for example)
Using account A, send a new message in the chat between the two users
Using account B, find the DM in the search to the top right
Verify the title of the option is bolded because there is an unread message ("sad" is the title in the picture above)

Verify that no errors appear in the JS console

Offline tests

QA Steps

Case 1: Group found in search should show the last message

Create a group chat between 3 users
Send a message in the group
Click the Search button on the top right
Verify that the group appearing search shows the last sent message

Case 2: Bold title show reflect read status

Create a DM between 2 users
Send a message from account A
Make the message read account B
Using account B, find the DM in the search to the top right:
Verify the title of the option is not bolded ("sad" is the title in the picture above)
Using account B, go to another chat (your concierge chat for example)
Using account A, send a new message in the chat between the two users
Using account B, find the DM in the search to the top right
Verify the title of the option is bolded because there is an unread message ("sad" is the title in the picture above)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Group showing last message:

Last read status reflected in bold:

Screen.Recording.2024-11-28.at.5.36.52.PM.mov

MacOS: Desktop

aldo-expensify · 2024-11-29T01:34:56Z

src/components/Search/SearchRouter/SearchRouterList.tsx

                excludeLogins: CONST.EXPENSIFY_EMAILS,
                includeSelfDM: true,
+                showChatPreviewLine: true,
+                shouldBoldTitleByDefault: false,


This fixes: #53289

This is the PR that originally introduced shouldBoldTitleByDefault: https://github.com/Expensify/App/pull/48575/files

I understand that we used to pass shouldBoldTitleByDefault: false before the refactor #52568

src/components/Search/SearchRouter/SearchRouterList.tsx

melvin-bot · 2024-11-29T01:45:06Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MonilBhavsar · 2024-11-29T05:09:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

MonilBhavsar

Looks good

OSBotify · 2024-11-29T05:29:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Kicu · 2024-11-29T07:02:17Z

thanks 👍 somehow I missed these options being added.

Include showChatPreviewLine: true (cherry picked from commit eddc533) (CP triggered by mountiny)

…-53293-1 🍒 Cherry pick PR #53293 to staging 🍒

github-actions · 2024-11-29T09:37:12Z

🚀 Cherry-picked to staging by https://github.com/MonilBhavsar in version: 9.0.68-3 🚀

platform	result
🤖 android 🤖	false ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

kavimuru · 2024-11-29T15:47:58Z

Fixed issues #53291
#53289 failing in web, mweb, android and desktop

Bug6679872_1732877692137.Recording_2024-11-29_134625.mp4

Bug6679851_1732876321280.Recording_2024-11-29_133005.mp4

https://platform.utest.com/services/links/v1/internal/55238622?.mp4

https://platform.utest.com/services/links/v1/internal/55238623?.mp4

https://platform.applause.com/services/links/v1/external/e13508462722d0d46b4015951441fa9806698d07bfff3107dd409d151e4e2fad

https://platform.applause.com/services/links/v1/external/033ae4369e8f45126c8e8eba13533f66c783d1c66b146f726de606926351fac7

github-actions · 2024-11-30T13:53:59Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.68-7 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

Include showChatPreviewLine: true

e8d5635

aldo-expensify self-assigned this Nov 28, 2024

aldo-expensify mentioned this pull request Nov 28, 2024

[HOLD for payment 2024-12-09] [HOLD for payment 2024-12-07] Search - Group chat preview shows "Group" (email for 1:1 DM) instead of latest message #53291

Closed

8 tasks

Don't bold title by default in chat search

86e8916

aldo-expensify commented Nov 29, 2024

View reviewed changes

src/components/Search/SearchRouter/SearchRouterList.tsx Show resolved Hide resolved

aldo-expensify mentioned this pull request Nov 29, 2024

[HOLD for payment 2024-12-09] [HOLD for payment 2024-12-07] Search - Read message shown in bold in search router result #53289

Closed

8 tasks

aldo-expensify marked this pull request as ready for review November 29, 2024 01:45

aldo-expensify requested a review from a team as a code owner November 29, 2024 01:45

melvin-bot bot requested a review from abdulrahuman5196 November 29, 2024 01:45

melvin-bot bot removed the request for review from a team November 29, 2024 01:45

MonilBhavsar approved these changes Nov 29, 2024

View reviewed changes

MonilBhavsar merged commit eddc533 into main Nov 29, 2024

MonilBhavsar deleted the aldo_add-showChatPreviewLine branch November 29, 2024 05:21

MonilBhavsar changed the title ~~Include showChatPreviewLine: true~~ [CP Staging] Fix chat view in search router Nov 29, 2024

OSBotify pushed a commit that referenced this pull request Nov 29, 2024

Merge pull request #53293 from Expensify/aldo_add-showChatPreviewLine

f07ed11

Include showChatPreviewLine: true (cherry picked from commit eddc533) (CP triggered by mountiny)

os-botify bot mentioned this pull request Nov 29, 2024

🍒 Cherry pick PR #53293 to staging 🍒 #53299

Merged

github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Nov 29, 2024

mountiny added a commit that referenced this pull request Nov 29, 2024

Merge pull request #53299 from Expensify/mountiny-cherry-pick-staging…

708d1ca

…-53293-1 🍒 Cherry pick PR #53293 to staging 🍒

github-actions bot mentioned this pull request Nov 29, 2024

Deploy Checklist: New Expensify 2024-11-28 #53245

Closed

72 tasks

bernhardoj mentioned this pull request Dec 2, 2024

[HOLD for payment 2025-01-18] [$250] Search - Workspace chat preview, flickers between last message and information message #53361

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Fix chat view in search router#53293

[CP Staging] Fix chat view in search router#53293
MonilBhavsar merged 2 commits intomainfrom
aldo_add-showChatPreviewLine

aldo-expensify commented Nov 28, 2024 •

edited

Loading

Uh oh!

aldo-expensify Nov 29, 2024

Uh oh!

aldo-expensify Nov 29, 2024

Uh oh!

Uh oh!

melvin-bot bot commented Nov 29, 2024

Uh oh!

MonilBhavsar commented Nov 29, 2024 •

edited

Loading

Uh oh!

MonilBhavsar left a comment

Uh oh!

OSBotify commented Nov 29, 2024

Uh oh!

Kicu commented Nov 29, 2024

Uh oh!

github-actions bot commented Nov 29, 2024

Uh oh!

kavimuru commented Nov 29, 2024 •

edited by aldo-expensify

Loading

Uh oh!

github-actions bot commented Nov 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

aldo-expensify commented Nov 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

aldo-expensify Nov 29, 2024

Choose a reason for hiding this comment

Uh oh!

aldo-expensify Nov 29, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melvin-bot bot commented Nov 29, 2024

Uh oh!

MonilBhavsar commented Nov 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

MonilBhavsar left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Nov 29, 2024

Uh oh!

Kicu commented Nov 29, 2024

Uh oh!

github-actions bot commented Nov 29, 2024

Uh oh!

kavimuru commented Nov 29, 2024 • edited by aldo-expensify Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

aldo-expensify commented Nov 28, 2024 •

edited

Loading

MonilBhavsar commented Nov 29, 2024 •

edited

Loading

kavimuru commented Nov 29, 2024 •

edited by aldo-expensify

Loading