fix search invoice page doesn't display merchant text "expense"

src/libs/SearchUIUtils.ts

@@ -66,7 +66,7 @@ function getTransactionItemCommonFormattedProperties(
     const formattedTotal = TransactionUtils.getAmount(transactionItem, isExpenseReport);
     const date = transactionItem?.modifiedCreated ? transactionItem.modifiedCreated : transactionItem?.created;
     const merchant = TransactionUtils.getMerchant(transactionItem);
-    const formattedMerchant = merchant === CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT || merchant === CONST.TRANSACTION.DEFAULT_MERCHANT ? '' : merchant;
+    const formattedMerchant = merchant === CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT ? '' : merchant;
 
     return {
         formattedFrom,
@@ -106,7 +106,7 @@ function getShouldShowMerchant(data: OnyxTypes.SearchResults['data']): boolean {
         if (isTransactionEntry(key)) {
             const item = data[key];
             const merchant = item.modifiedMerchant ? item.modifiedMerchant : item.merchant ?? '';
-            return merchant !== '' && merchant !== CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT && merchant !== CONST.TRANSACTION.DEFAULT_MERCHANT;
+            return merchant !== '' && merchant !== CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT;
         }
         return false;
     });
@@ -374,7 +374,7 @@ function getReportSections(data: OnyxTypes.SearchResults['data'], metadata: Onyx
                 ...reportItem,
                 action: getAction(data, key),
                 keyForList: reportItem.reportID,
-                from: data.personalDetailsList?.[reportItem.accountID ?? -1],
+                from: data.personalDetailsList?.[reportItem.accountID ?? CONST.DEFAULT_NUMBER_ID],
                 to: reportItem.managerID ? data.personalDetailsList?.[reportItem.managerID] : emptyPersonalDetails,
                 transactions,
                 reportName: isIOUReport ? getIOUReportName(data, reportItem) : reportItem.reportName,

tests/unit/Search/SearchUIUtilsTest.ts

@@ -0,0 +1,114 @@
+import type {TransactionListItemType} from '@components/SelectionList/types';
+import CONST from '@src/CONST';
+import * as SearchUIUtils from '@src/libs/SearchUIUtils';
+import type * as OnyxTypes from '@src/types/onyx';
+
+const accountID = 18439984;
+const policyID = 'A1B2C3';
+const reportID = '123456789';
+const transactionID = '1';
+
+// Given search data results consisting of involved users' personal details, policyID, reportID and transactionID
+const searchResults: OnyxTypes.SearchResults = {
+    data: {
+        personalDetailsList: {
+            [accountID]: {
+                accountID,
+                avatar: 'https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/avatar_3.png',
+                displayName: 'test',
+                login: 'test1234@gmail.com',
+            },
+        },
+        [`policy_${policyID}`]: {
+            approvalMode: 'OPTIONAL',
+            autoReimbursement: {
+                limit: 0,
+            },
+            autoReimbursementLimit: 0,
+            autoReporting: true,
+            autoReportingFrequency: 'instant',
+            preventSelfApproval: false,
+            owner: 'test1234@gmail.com',
+            reimbursementChoice: 'reimburseManual',
+            role: 'admin',
+            type: 'team',
+        },
+        [`report_${reportID}`]: {
+            accountID,
+            action: 'view',
+            chatReportID: '1706144653204915',
+            created: '2024-12-21 13:05:20',
+            currency: 'USD',
+            isOneTransactionReport: true,
+            isPolicyExpenseChat: false,
+            isWaitingOnBankAccount: false,
+            managerID: accountID,
+            nonReimbursableTotal: 0,
+            ownerAccountID: accountID,
+            policyID,
+            reportID,
+            reportName: 'Expense Report #123',
+            stateNum: 1,
+            statusNum: 1,
+            total: -5000,
+            type: 'expense',
+            unheldTotal: -5000,
+        },
+        [`transactions_${transactionID}`]: {
+            accountID,
+            action: 'view',
+            amount: -5000,
+            canDelete: true,
+            canHold: true,
+            canUnhold: false,
+            category: '',
+            comment: {
+                comment: '',
+            },
+            created: '2024-12-21',
+            currency: 'USD',
+            hasEReceipt: false,
+            isFromOneTransactionReport: true,
+            managerID: accountID,
+            description: '',
+            hasViolation: false,
+            merchant: 'Expense',
+            modifiedAmount: 0,
+            modifiedCreated: '',
+            modifiedCurrency: '',
+            modifiedMerchant: 'Expense',
+            parentTransactionID: '',
+            policyID,
+            reportID,
+            reportType: 'expense',
+            tag: '',
+            transactionID,
+            transactionThreadReportID: '456',
+            transactionType: 'cash',
+        },
+    },
+    search: {
+        columnsToShow: {
+            shouldShowCategoryColumn: true,
+            shouldShowTagColumn: false,
+            shouldShowTaxColumn: false,
+        },
+        hasMoreResults: false,
+        hasResults: true,
+        offset: 0,
+        status: 'all',
+        isLoading: false,
+        type: 'expense',
+    },
+};
+
+// When the results are filtered by type "expense" to be displayed on the search page
+const transactionSections = SearchUIUtils.getSections('expense', 'all', searchResults.data, searchResults.search) as TransactionListItemType[];
+const tests = transactionSections.map((transactionList) => [{transactionListItem: transactionList, expectedMerchant: CONST.TRANSACTION.DEFAULT_MERCHANT}]);
+
+// Then verify the merchant column is displayed as "Expense", and does not contain an empty string
+describe('SearchUIUtils', () => {
+    test.each(tests)('Transaction list item with "Expense" merchant', ({transactionListItem, expectedMerchant}) => {
+        expect(transactionListItem.merchant).toEqual(expectedMerchant);
+    });
+});