Fix: App back button returns to the same page after clicking back button on Import RHP by twilight2294 · Pull Request #53520 · Expensify/App

twilight2294 · 2024-12-04T07:10:14Z

Explanation of Change

Fixed Issues

$ #53047
PROPOSAL: #53047 (comment)

Tests

Same as QA

Verify that no errors appear in the JS console

Offline tests

Same as QA

QA Steps

Go to workspace settings > Categories.
Click 3-dot menu > Import spreadsheet.
Click RHP back button to dismiss the RHP (important).
Click app back button on the top left.

Verify that we get to the workspace list page.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen_recording_20241204_130637.mp4

Android: mWeb Chrome

Screen_recording_20241204_130023.mp4

iOS: Native

Simulator.Screen.Recording.-.Expensify.testing.-.2024-12-04.at.13.03.39.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.Expensify.testing.-.2024-12-04.at.13.02.42.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-12-04.at.12.50.08.PM.mov

MacOS: Desktop

Screen.Recording.2024-12-04.at.12.58.21.PM.mov

Signed-off-by: GitHub <noreply@github.com>

melvin-bot · 2024-12-04T07:38:33Z

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dominictb · 2024-12-05T08:56:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-12-30.at.23.43.12-compressed.mov

Android: mWeb Chrome

Screen.Recording.2024-12-30.at.23.45.01-compressed.mov

iOS: Native

Screen.Recording.2024-12-30.at.23.38.19-compressed.mov

iOS: mWeb Safari

Screen.Recording.2024-12-30.at.23.39.58-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2024-12-30.at.23.29.56-compressed.mov

MacOS: Desktop

Screen.Recording.2024-12-30.at.23.35.59-compressed.mov

dominictb · 2024-12-11T07:45:27Z

@twilight2294 BUG:

Submit an expense to a workspace with categories enabled
Proceed to the confirmation page and click "Category"
[Device B] Go to the workspace settings > Categories
[Device B] Disable all tags
Click Edit categories
Click three dot menu > Import spreadsheet
Refresh the page
Click the "Back" button

Expected result: App goes back to categories quick settings flow.
Actual result: RHP is closed

twilight2294 · 2024-12-12T07:30:38Z

Looking

twilight2294 · 2024-12-14T16:18:06Z

@dominictb do you have any suggestions here ? we flush the navigation state on refresh

dominictb · 2024-12-14T17:41:36Z

@twilight2294 the backTo param you removed is used for this purpose. Please investigate more.

twilight2294 · 2024-12-18T06:26:05Z

Still looking for a solution, @dominictb do you have anything in mind i can experiment ?

dominictb · 2024-12-18T06:37:36Z

This seems to be not correct from the proposal. We can close the PR and get back to proposal evaluation again.

twilight2294 · 2024-12-19T05:55:01Z

I think i know how to fix it, will try and let you know if that solution works

dominictb · 2024-12-23T04:15:12Z

@twilight2294 How is this going? If you're stuck, we can come back to proposal review. Just need to solve this ASAP.

twilight2294 · 2024-12-23T18:12:20Z

I'll try once tomorrow, else we can move to proposal review stage again, thanks for patience, mainly i'm try to remember the navigation state like we do for money request

twilight2294 · 2024-12-26T13:52:11Z

Okay i have a fix here, pushing shortly

…atch-13

twilight2294 · 2024-12-26T19:08:02Z

@dominictb thanks for the patience, last week my setup was terribly broken and that is why there was so much delay, all my PR's were delayed in fact, I'm extremely sorry for that delay, The bug is now fixed.

The flow was over complicated, we don't need to have to put a navigation route again, we can simply pass the backTo value and out navigation functions are smart enough to deal with.

We follow the same appraoch when we navigate from the empty category IOU page to workspace categories RHP:

App/src/pages/iou/request/step/IOURequestStepCategory.tsx

Lines 181 to 188 in e94df0f

    
           InteractionManager.runAfterInteractions(() => { 
        
               Navigation.navigate( 
        
                   ROUTES.SETTINGS_CATEGORIES_ROOT.getRoute( 
        
                       policy.id, 
        
                       ROUTES.MONEY_REQUEST_STEP_CATEGORY.getRoute(action, iouType, transactionID, report.reportID, backTo, reportActionID), 
        
                   ), 
        
               ); 
        
           });

dominictb · 2024-12-30T16:32:39Z

@twilight2294 Please update your QA Steps to include steps 4 - 7 only. Ping me when you're done.

OSBotify · 2024-12-31T14:53:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-31T22:17:25Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.0.80-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-06T18:16:58Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.80-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

twilight2294 added 2 commits December 4, 2024 12:39

remove backTo prop and use closeRHPFlow

d7795f9

remove prop usage from components

dce06f0

Signed-off-by: GitHub <noreply@github.com>

twilight2294 marked this pull request as ready for review December 4, 2024 07:38

twilight2294 requested a review from a team as a code owner December 4, 2024 07:38

melvin-bot bot requested review from dominictb and removed request for a team December 4, 2024 07:38

twilight2294 added 6 commits December 26, 2024 19:26

Merge branch 'Expensify:main' into patch-13

1420ee1

fix navigation issues in tags and categories

cd80b7a

undo order change

3747927

fix esLint

c85eef6

Merge branch 'patch-13' of https://github.com/twilight2294/App into p…

e06933f

…atch-13

Merge branch 'main' into patch-13

900cb38

dominictb approved these changes Dec 30, 2024

View reviewed changes

melvin-bot bot requested a review from arosiclair December 30, 2024 16:48

arosiclair approved these changes Dec 31, 2024

View reviewed changes

arosiclair merged commit d89be5f into Expensify:main Dec 31, 2024

github-actions bot mentioned this pull request Dec 31, 2024

Deploy Checklist: New Expensify 2024-12-31 #54686

Closed

68 tasks

melvin-bot bot mentioned this pull request Jan 6, 2025

[HOLD for payment 2025-01-13] [$250] Categories - App back button returns to the same page after clicking back button on Import RHP #53047

Closed

8 tasks

Conversation

twilight2294 commented Dec 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 4, 2024

Uh oh!

dominictb commented Dec 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dominictb commented Dec 11, 2024

Uh oh!

twilight2294 commented Dec 12, 2024

Uh oh!

twilight2294 commented Dec 14, 2024

Uh oh!

dominictb commented Dec 14, 2024

Uh oh!

twilight2294 commented Dec 18, 2024

Uh oh!

dominictb commented Dec 18, 2024

Uh oh!

twilight2294 commented Dec 19, 2024

Uh oh!

dominictb commented Dec 23, 2024

Uh oh!

twilight2294 commented Dec 23, 2024

Uh oh!

twilight2294 commented Dec 26, 2024

Uh oh!

twilight2294 commented Dec 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dominictb commented Dec 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Dec 31, 2024

Uh oh!

github-actions bot commented Dec 31, 2024

Uh oh!

github-actions bot commented Jan 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

twilight2294 commented Dec 4, 2024 •

edited

Loading

dominictb commented Dec 5, 2024 •

edited

Loading

twilight2294 commented Dec 26, 2024 •

edited

Loading

dominictb commented Dec 30, 2024 •

edited

Loading