53182 submit button jump confirmation page by huult · Pull Request #53529 · Expensify/App

huult · 2024-12-04T09:10:50Z

Details

Fixed Issues

$ #53182
PROPOSAL: #53182 (comment)

Tests

Same QA step

Verify that no errors appear in the JS console

Offline tests

QA Steps

Launch the app.
Navigate to FAB > Create expense > Manual.
Enter an amount and tap Next.
Ensure the keyboard is open.
Select any user from the list at the top.
Verify the Submit button does not jump when transitioning to the confirmation page.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-12-04.at.15.33.09.mp4

Android: mWeb Chrome

Screen.Recording.2024-12-04.at.15.34.14.mp4

iOS: Native

Screen.Recording.2024-12-04.at.15.35.06.mp4

iOS: mWeb Safari

Screen.Recording.2024-12-04.at.15.36.01.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-12-04.at.15.37.09.mp4

MacOS: Desktop

Screen.Recording.2024-12-04.at.15.41.07.mp4

…n page

…-jump-confirmation-page

melvin-bot · 2024-12-04T09:10:56Z

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

huult · 2024-12-04T10:35:06Z

@suneox I’ve made changes to the keyboard utils. This function wasn’t working on mWeb, as mentioned in the documentation here. Due to this issue, the function needed an update to ensure it works properly on the web

…-jump-confirmation-page

src/utils/keyboard.ts

…-jump-confirmation-page

suneox · 2024-12-08T16:35:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-12-09.at.00.35.11.mp4

Android: mWeb Chrome

Screen.Recording.2024-12-09.at.00.33.17.mp4

iOS: Native

Screen.Recording.2024-12-09.at.00.28.14.mp4

iOS: mWeb Safari

Screen.Recording.2024-12-24.at.23.21.05.mp4

Screen.Recording.2024-12-09.at.00.29.10.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-12-09.at.00.26.09.mp4

MacOS: Desktop

Screen.Recording.2024-12-09.at.00.30.00.mp4

suneox · 2024-12-08T17:53:48Z

@huult We need to make a specific change for Android native only, as this issue does not occur on iOS. After implementing the change, there might be a lot of delay on iOS native when choose recipient.

iOS: Native before change

Screen.Recording.2024-12-09.at.00.42.11.mp4

iOS: Native after change

Screen.Recording.2024-12-09.at.00.45.55.mp4

…-jump-confirmation-page

…bile web

huult · 2024-12-09T03:09:46Z

@suneox I’ve updated your feedback. Could you please check it again? Thank you

…-jump-confirmation-page

suneox · 2024-12-13T14:43:52Z

@suneox I’ve updated your feedback. Could you please check it again? Thank you

@huult The latest change isn't working on mWeb.

Screen.Recording.2024-12-13.at.21.39.59.mp4

src/utils/keyboard/index.website.ts

suneox · 2024-12-13T16:10:20Z

@huult The latest change isn't working on mWeb.

It looks like we have another issue #50663, specifically to handle this issue on mWeb.

suneox · 2024-12-13T16:16:05Z

It looks like we have another issue #50663, specifically to handle this issue on mWeb.

The referenced issue is also on hold due to this PR 😅.

…-jump-confirmation-page

huult · 2024-12-14T10:23:50Z

@suneox I’ve updated the pull request. Can you take a look?

Screen.Recording.2024-12-14.at.17.22.27.mov

suneox · 2024-12-14T16:57:29Z

@suneox I’ve updated the pull request. Can you take a look?

Screen.Recording.2024-12-14.at.17.22.27.mov

@huult It looks like in your change, the submit button is not aligned to the bottom.

…-jump-confirmation-page

huult · 2024-12-18T04:16:29Z

@suneox I’ve updated the pull request. Could you please check it? Thank you

Screen.Recording.2024-12-18.at.11.14.39.mp4

suneox · 2024-12-18T15:15:51Z

@huult Could you please explain the root cause you've identified and the new solution you've implemented?

src/hooks/useReadyWithDimensions.ts

src/components/ScreenWrapper.tsx

…-jump-confirmation-page

huult · 2024-12-19T06:38:48Z

@suneox I’ve updated the keyboard dismissal to use the visual viewport. Can you check it again? Thank you.

…-jump-confirmation-page

suneox · 2024-12-24T14:48:03Z

@huult Please fix the eslint

…-jump-confirmation-page

huult · 2024-12-24T15:26:33Z

@suneox it's done!

src/libs/DistanceRequestUtils.ts

techievivek

Looks good, thanks for the changes.

OSBotify · 2024-12-25T06:47:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-26T20:54:37Z

🚀 Deployed to staging by https://github.com/techievivek in version: 9.0.79-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-31T21:51:56Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.79-5 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

parasharrajat · 2025-01-10T19:18:33Z

src/utils/keyboard/index.website.ts

+        };
+
+        window.visualViewport?.addEventListener('resize', handleDismissResize);
+        Keyboard.dismiss();


How are we using this @huult? This a mock on react-native-web.

huult added 3 commits December 3, 2024 14:13

prevent submit button from jumping when proceeding to the confirmatio…

8250f05

…n page

Merge remote-tracking branch 'upstream/main' into 53182-submit-button…

53a6a35

…-jump-confirmation-page

Update dismiss keyboard for web

c0d30f7

huult requested a review from a team as a code owner December 4, 2024 09:10

melvin-bot bot requested review from suneox and removed request for a team December 4, 2024 09:10

Merge remote-tracking branch 'upstream/main' into 53182-submit-button…

ca09e27

…-jump-confirmation-page

suneox reviewed Dec 4, 2024

View reviewed changes

src/utils/keyboard.ts Outdated Show resolved Hide resolved

suneox reviewed Dec 4, 2024

View reviewed changes

src/utils/keyboard.ts Outdated Show resolved Hide resolved

huult added 2 commits December 5, 2024 08:51

Merge remote-tracking branch 'upstream/main' into 53182-submit-button…

c6368a5

…-jump-confirmation-page

Add keyboard dismiss for web

ff74004

huult added 2 commits December 9, 2024 09:41

Merge remote-tracking branch 'upstream/main' into 53182-submit-button…

0a6cd9e

…-jump-confirmation-page

Specify dismiss keyboard behavior for Android native and Safari on mo…

c01e82c

…bile web

Merge remote-tracking branch 'upstream/main' into 53182-submit-button…

94b8c83

…-jump-confirmation-page

suneox reviewed Dec 13, 2024

View reviewed changes

src/utils/keyboard/index.website.ts Outdated Show resolved Hide resolved

huult added 2 commits December 14, 2024 15:01

Merge remote-tracking branch 'upstream/main' into 53182-submit-button…

cbfc0d2

…-jump-confirmation-page

add listen dimention changes

ff4fb89

Merge remote-tracking branch 'upstream/main' into 53182-submit-button…

babeb3f

…-jump-confirmation-page

techievivek assigned huult Dec 18, 2024

suneox reviewed Dec 18, 2024

View reviewed changes

src/hooks/useReadyWithDimensions.ts Outdated Show resolved Hide resolved

suneox reviewed Dec 18, 2024

View reviewed changes

src/hooks/useReadyWithDimensions.ts Outdated Show resolved Hide resolved

suneox reviewed Dec 18, 2024

View reviewed changes

src/components/ScreenWrapper.tsx Outdated Show resolved Hide resolved

huult added 4 commits December 19, 2024 10:44

Merge remote-tracking branch 'upstream/main' into 53182-submit-button…

a89ea97

…-jump-confirmation-page

Check visual viewport before setting maxHeight

65345c4

Use visual viewport to detect keyboard show/hide

968a125

Remove unused break line

9917a1b

Merge remote-tracking branch 'upstream/main' into 53182-submit-button…

2d002c6

…-jump-confirmation-page

MitchExpensify mentioned this pull request Dec 24, 2024

[HOLD for payment 2025-01-07] [$250] Android - Expense - Submit button jumps when proceeding to confirmation page #53182

Closed

8 tasks

huult added 2 commits December 24, 2024 21:49

Merge remote-tracking branch 'upstream/main' into 53182-submit-button…

38f9e8c

…-jump-confirmation-page

fix eslint

c25b460

suneox reviewed Dec 24, 2024

View reviewed changes

src/libs/DistanceRequestUtils.ts Show resolved Hide resolved

suneox approved these changes Dec 24, 2024

View reviewed changes

melvin-bot bot requested a review from techievivek December 24, 2024 16:46

Update return default customUnitRateID when report ID is undefined

6704403

techievivek approved these changes Dec 25, 2024

View reviewed changes

techievivek merged commit 12e0941 into Expensify:main Dec 25, 2024

github-actions bot mentioned this pull request Dec 26, 2024

Deploy Checklist: New Expensify 2024-12-26 #54591

Closed

42 tasks

bernhardoj mentioned this pull request Dec 27, 2024

[HOLD for payment 2025-01-30] [HOLD for payment 2025-01-15] [$50] mWeb - Workspace - In offline, unable to save workspace name/ description #54609

Closed

8 tasks

This was referenced Dec 31, 2024

mWeb/Chrome - Expenses - The Save button on the Merchant page is unresponsive in offline mode #54671

Closed

Revert "53182 submit button jump confirmation page" #54674

Closed

parasharrajat reviewed Jan 10, 2025

View reviewed changes

greg-schroeder mentioned this pull request Jan 16, 2025

[$250] mWeb/Safari - Expense - Submit button hangs in the middle of expense details page for 2 sec #50663

Closed

6 tasks

Conversation

huult commented Dec 4, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 4, 2024

Uh oh!

huult commented Dec 4, 2024

Uh oh!

Uh oh!

Uh oh!

suneox commented Dec 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

suneox commented Dec 8, 2024

Uh oh!

huult commented Dec 9, 2024

Uh oh!

suneox commented Dec 13, 2024

Uh oh!

Uh oh!

suneox commented Dec 13, 2024

Uh oh!

suneox commented Dec 13, 2024

Uh oh!

huult commented Dec 14, 2024

Uh oh!

suneox commented Dec 14, 2024

Uh oh!

huult commented Dec 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

suneox commented Dec 18, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

huult commented Dec 19, 2024

Uh oh!

suneox commented Dec 24, 2024

Uh oh!

huult commented Dec 24, 2024

Uh oh!

Uh oh!

techievivek left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Dec 25, 2024

Uh oh!

github-actions bot commented Dec 26, 2024

Uh oh!

github-actions bot commented Dec 31, 2024

Uh oh!

parasharrajat Jan 10, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

suneox commented Dec 8, 2024 •

edited

Loading

huult commented Dec 18, 2024 •

edited

Loading