Skip to content

scroll cursor into view when focus #53566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deetergp merged 1 commit into from
Dec 6, 2024
Merged

scroll cursor into view when focus #53566

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions patches/react-native+0.75.2+025+fix-scroll-the-cursor-into-view-when-focus.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
diff --git a/node_modules/react-native/React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputComponentView.mm b/node_modules/react-native/React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputComponentView.mm
index db7cba4..6937720 100644
--- a/node_modules/react-native/React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputComponentView.mm
+++ b/node_modules/react-native/React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputComponentView.mm
@@ -88,6 +88,7 @@ - (void)didMoveToWindow
const auto &props = static_cast<const TextInputProps &>(*_props);
if (props.autoFocus) {
[_backedTextInputView becomeFirstResponder];
+ [self scrollCursorIntoView];
}
_didMoveToWindow = YES;
[self initializeReturnKeyType];
@@ -301,6 +302,7 @@ - (void)textInputDidBeginEditing
[self textInputDidChangeSelection];
}

+ [self scrollCursorIntoView];
if (_eventEmitter) {
static_cast<const TextInputEventEmitter &>(*_eventEmitter).onFocus([self _textInputMetrics]);
}
@@ -674,6 +676,15 @@ - (void)_setAttributedString:(NSAttributedString *)attributedString
_lastStringStateWasUpdatedWith = attributedString;
}

+- (void)scrollCursorIntoView {
+ UITextRange *selectedRange = _backedTextInputView.selectedTextRange;
+ if (selectedRange.empty) {
+ NSInteger offsetStart = [_backedTextInputView offsetFromPosition:_backedTextInputView.beginningOfDocument
+ toPosition:selectedRange.start];
+ [_backedTextInputView scrollRangeToVisible:NSMakeRange(offsetStart, 0)];
+ }
+}
+
- (void)_setMultiline:(BOOL)multiline
{
[_backedTextInputView removeFromSuperview];