fix: enable paste html in compose box and fix regressions by daledah · Pull Request #53758 · Expensify/App

daledah · 2024-12-09T15:09:15Z

Explanation of Change

This PR re-implements #53367 with some changes to fix regressions:

Remove navigate usage in useHTMLPaste to fix [HOLD for payment 2025-01-02] [$250] App crashes when clicking add reaction #53637
Remove useHTMLPaste in PrivateNotesEditPage to fix [HOLD for payment 2025-01-02] [$250] Profile - Email copied from profile is pasted twice in Private notes #53654

Fixed Issues

$ #52681
$ #53654
$ #53637
PROPOSAL: #52681 (comment)

Tests

Open a chat
Type "> hi" and send message
Long press message and click "Copy to clipboard"
Open Emoji picker
Verify that: Emoji picker is opened, app is not crashed
Click on header
Click private notes
Press CMD+V or long press to paste
Verify that: Text with correct format is pasted and pasted only once

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open a chat
Type "> hi" and send message
Long press message and click "Copy to clipboard"
Open Emoji picker
Verify that: Emoji picker is opened, app is not crashed
Click on header
Click private notes
Press CMD+V or long press to paste
Verify that: Text with correct format is pasted and pasted only once

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-12-09.at.21.51.06.mp4

Android: mWeb Chrome

Screen.Recording.2024-12-09.at.21.53.29.mp4

iOS: Native

Screen.Recording.2024-12-09.at.21.59.00.mov

iOS: mWeb Safari

Screen.Recording.2024-12-09.at.22.00.07.mov

MacOS: Chrome / Safari

Screen.Recording.2024-12-09.at.21.48.37.mov

MacOS: Desktop

Screen.Recording.2024-12-09.at.22.06.57.mp4

melvin-bot · 2024-12-09T15:09:21Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2024-12-10T07:48:16Z

@ntdiary Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ntdiary · 2024-12-10T08:05:01Z

seems @thesahindia is right c+ reviewer. :)

thesahindia · 2024-12-10T13:21:20Z

@daledah, please include the explanation in the top section.

daledah · 2024-12-13T03:50:42Z

@daledah, please include the explanation in the top section.

@thesahindia I updated

thesahindia · 2024-12-13T10:59:17Z

Please resolve the conflicts @daledah

daledah · 2024-12-17T15:40:18Z

@thesahindia i updated

thesahindia · 2024-12-18T13:18:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-12-18.at.6.43.25.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-12-18.at.6.40.35.PM.mov

iOS: Native

Screen.Recording.2024-12-18.at.6.46.53.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-12-18.at.6.45.46.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-12-18.at.6.34.49.PM.mov

MacOS: Desktop

Screen.Recording.2024-12-18.at.6.38.56.PM.mov

thesahindia · 2024-12-18T13:20:11Z

Paste the text in compose box

@daledah, you missed one step.

thesahindia

LGTM!

thesahindia · 2024-12-18T18:14:12Z

Sorry for the ping @stitesExpensify. @flodnv is already assigned to the original issue.

OSBotify · 2024-12-19T16:08:13Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-23T20:57:37Z

🚀 Deployed to staging by https://github.com/flodnv in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	cancelled 🔪
🍎🔄 iOS HybridApp 🍎🔄	cancelled 🔪

github-actions · 2024-12-23T21:41:33Z

🚀 Deployed to staging by https://github.com/flodnv in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-23T21:49:03Z

🚀 Deployed to staging by https://github.com/flodnv in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-24T00:04:48Z

🚀 Deployed to staging by https://github.com/flodnv in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-24T00:52:27Z

🚀 Deployed to staging by https://github.com/flodnv in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-24T19:42:34Z

🚀 Deployed to staging by https://github.com/flodnv in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-24T19:59:30Z

🚀 Deployed to staging by https://github.com/flodnv in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-26T20:26:45Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.78-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

c3024 · 2025-10-18T14:37:14Z

src/hooks/useHtmlPaste/index.ts

        };
        // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
-    }, []);
+    }, [isActive]);


The changes needed to either add the handlePaste dependency here or retrigger this effect some way when handlePaste changes. Fixed here #70279

fix: enable paste html in compose box and fix regressions

17fc54b

daledah added 2 commits December 9, 2024 22:38

Merge branch 'main' into fix/53637

ce77526

fix: lint

ba9f86a

daledah marked this pull request as ready for review December 10, 2024 07:48

daledah requested a review from a team as a code owner December 10, 2024 07:48

melvin-bot bot requested a review from ntdiary December 10, 2024 07:48

melvin-bot bot removed the request for review from a team December 10, 2024 07:48

Merge branch 'main' into fix/53637

e2b59ef

thesahindia approved these changes Dec 18, 2024

View reviewed changes

melvin-bot bot requested a review from stitesExpensify December 18, 2024 13:20

thesahindia mentioned this pull request Dec 18, 2024

[HOLD for payment 2025-01-02][$125] mWeb - Chat - Quote markdown is not copied in compose box #52681

Closed

8 tasks

stitesExpensify requested review from flodnv and removed request for stitesExpensify December 18, 2024 21:41

flodnv approved these changes Dec 19, 2024

View reviewed changes

flodnv merged commit b59e021 into Expensify:main Dec 19, 2024

github-actions bot mentioned this pull request Dec 23, 2024

Deploy Checklist: New Expensify 2024-12-23 #54476

Closed

This was referenced Dec 26, 2024

[HOLD for payment 2025-01-02] [$250] Profile - Email copied from profile is pasted twice in Private notes #53654

Closed

[HOLD for payment 2025-01-02] [$250] App crashes when clicking add reaction #53637

Closed

c3024 reviewed Oct 18, 2025

View reviewed changes

Conversation

daledah commented Dec 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 9, 2024

Uh oh!

melvin-bot bot commented Dec 10, 2024

Uh oh!

ntdiary commented Dec 10, 2024

Uh oh!

thesahindia commented Dec 10, 2024

Uh oh!

daledah commented Dec 13, 2024

Uh oh!

thesahindia commented Dec 13, 2024

Uh oh!

daledah commented Dec 17, 2024

Uh oh!

thesahindia commented Dec 18, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

thesahindia commented Dec 18, 2024

Uh oh!

thesahindia left a comment

Choose a reason for hiding this comment

Uh oh!

thesahindia commented Dec 18, 2024

Uh oh!

OSBotify commented Dec 19, 2024

Uh oh!

github-actions bot commented Dec 23, 2024

Uh oh!

github-actions bot commented Dec 23, 2024

Uh oh!

github-actions bot commented Dec 23, 2024

Uh oh!

github-actions bot commented Dec 24, 2024

Uh oh!

github-actions bot commented Dec 24, 2024

Uh oh!

github-actions bot commented Dec 24, 2024

Uh oh!

github-actions bot commented Dec 24, 2024

Uh oh!

github-actions bot commented Dec 26, 2024

Uh oh!

c3024 Oct 18, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

daledah commented Dec 9, 2024 •

edited

Loading