Add go to workspace shortcut and fix regression by mkzie2 · Pull Request #53898 · Expensify/App

mkzie2 · 2024-12-11T08:02:17Z

Explanation of Change

Add go to workspace shortcut and fix regression

Fixed Issues

$ #52817
PROPOSAL:

Tests

Go to any workspace expense chat
Press report header
Verify "Go to workspace" menu shows
Press Go to workspace
Verify app opens workspace initial settings page on small screens and workspace profile page on large screens
Repeat steps 2 - 5 with workspace rooms, workspace's expense reports, workspace's transaction thread reports, thread reports originating from any kind of workspace chats listed above
Enable the invoices feature
Create a send invoice
Delete the workspace
Go the report detail of the invoice report and verify that no Leave option
Open the report detail of the workspace chat and verify that no Go to workspace option

Verify that no errors appear in the JS console

Offline tests

Same

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-25.at.23.58.09-compressed.mov

Screen.Recording.2024-12-11.at.14.54.04.mov

Android: mWeb Chrome

Screen.Recording.2024-11-26.at.00.00.11.mov

Screen.Recording.2024-12-11.at.14.49.29.mov

iOS: Native

Screen.Recording.2024-11-25.at.23.55.19.mov

Screen.Recording.2024-12-11.at.14.50.25.mov

iOS: mWeb Safari

Screen.Recording.2024-11-25.at.23.57.08-compressed.mov

Screen.Recording.2024-12-11.at.14.51.20.mov

MacOS: Chrome / Safari

Screen.Recording.2024-12-11.at.14.45.33.mp4

MacOS: Desktop

Screen.Recording.2024-12-11.at.14.56.28.mov

melvin-bot · 2024-12-11T08:06:51Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2024-12-13T09:08:16Z

Going to review this today.

mananjadhav · 2024-12-17T12:14:59Z

@trjExpensify quick question. Archived workspace - is the only scenario when the Go to workspace option will not be visible? Do we have any other such cases?

trjExpensify · 2024-12-17T12:19:53Z

Archived workspace - is the only scenario when the Go to workspace option will not be visible? Do we have any other such cases?

That's the only one I can think of, yeah. Well, assuming when you say "archive" you mean both cases of a user being removed from the workspace (thus wouldn't be able to access the read-only workspace settings anymore) or the workspace being deleted (thus nobody would be able to access the workspace settings anymore).

mananjadhav · 2024-12-19T15:14:01Z

I tested this on Web and I couldn't get the app working on Native. Checklist will be finished today.

mkzie2 · 2024-12-25T09:10:57Z

@mananjadhav Any update here?

mananjadhav · 2024-12-26T18:16:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web-go-to-workspace.mov

MacOS: Desktop

desktop-go-to-workspace.mov

mananjadhav · 2024-12-26T18:16:35Z

@mkzie2 Can you sync the main branch please? It seems out of sync.

mkzie2 · 2024-12-26T19:29:01Z

@mananjadhav Updated.

mananjadhav · 2024-12-28T06:11:22Z

@mkzie2 I can see lint failures. Can you please fix them?

mananjadhav · 2024-12-29T18:40:38Z

@mkzie2 Quick bump on the PR.

mkzie2 · 2025-01-02T03:58:52Z

@youssef-lr Please help to check when you have a chance.

youssef-lr · 2025-01-02T20:21:36Z

On it today! I Was OOO.

trjExpensify · 2025-01-03T11:30:11Z

How'd you get on, @youssef-lr?

youssef-lr

LGTM

OSBotify · 2025-01-03T17:51:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-06T18:33:13Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.0.81-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-08T02:44:04Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.81-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

rojiphil · 2025-03-03T05:15:25Z

src/pages/ReportDetailsPage.tsx

+                        return;
+                    }
+                    if (isSmallScreenWidth) {
+                        Navigation.navigate(ROUTES.WORKSPACE_INITIAL.getRoute(report?.policyID));


If the workspace settings page was navigated to from here, we would want to come back to this page on the back button press in the workspace settings page. This is implemented in #55196

Thanks for highlighting.

Add go to workspace shortcut and fix regression

8d70885

mkzie2 marked this pull request as ready for review December 11, 2024 08:06

mkzie2 requested a review from a team as a code owner December 11, 2024 08:06

melvin-bot bot requested a review from mananjadhav December 11, 2024 08:06

melvin-bot bot removed the request for review from a team December 11, 2024 08:06

mkzie2 mentioned this pull request Dec 11, 2024

[HOLD for payment 2025-01-15] [$125] Add "Go to workspace" as a shortcut in all of the workspace chats, rooms and reports details page. #52817

Closed

8 tasks

Merge branch 'main' into mkzie2-issue/52817-regression

cfbf715

mkzie2 added 2 commits December 30, 2024 11:51

Merge branch 'main' into mkzie2-issue/52817-regression

14324da

fix lint error

55dec32

mananjadhav approved these changes Dec 30, 2024

View reviewed changes

melvin-bot bot requested a review from youssef-lr December 30, 2024 05:08

Merge branch 'main' into mkzie2-issue/52817-regression

e859d45

youssef-lr approved these changes Jan 3, 2025

View reviewed changes

youssef-lr merged commit 165a9ba into Expensify:main Jan 3, 2025

github-actions bot mentioned this pull request Jan 6, 2025

Deploy Checklist: New Expensify 2025-01-06 #54825

Closed

74 tasks

rojiphil reviewed Mar 3, 2025

View reviewed changes

Conversation

mkzie2 commented Dec 11, 2024

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 11, 2024

Uh oh!

mananjadhav commented Dec 13, 2024

Uh oh!

mananjadhav commented Dec 17, 2024

Uh oh!

trjExpensify commented Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mananjadhav commented Dec 19, 2024

Uh oh!

mkzie2 commented Dec 25, 2024

Uh oh!

mananjadhav commented Dec 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mananjadhav commented Dec 26, 2024

Uh oh!

mkzie2 commented Dec 26, 2024

Uh oh!

mananjadhav commented Dec 28, 2024

Uh oh!

mananjadhav commented Dec 29, 2024

Uh oh!

mkzie2 commented Jan 2, 2025

Uh oh!

youssef-lr commented Jan 2, 2025

Uh oh!

trjExpensify commented Jan 3, 2025

Uh oh!

youssef-lr left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jan 3, 2025

Uh oh!

github-actions bot commented Jan 6, 2025

Uh oh!

github-actions bot commented Jan 8, 2025

Uh oh!

rojiphil Mar 3, 2025

Choose a reason for hiding this comment

Uh oh!

mananjadhav Mar 3, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

trjExpensify commented Dec 17, 2024 •

edited

Loading

mananjadhav commented Dec 26, 2024 •

edited

Loading