[CP Staging] fix: onboarding modal is not displayed in web by nkdengineer · Pull Request #54329 · Expensify/App

nkdengineer · 2024-12-18T21:36:25Z

Explanation of Change

Fixed Issues

$ #54322
PROPOSAL: #54322 (comment)

Tests

Sign in with a new account
Verify that the onboarding modal is displayed
Complete the onboarding flow
Go to the settings tab.
Open the workspaces list.
Create a new workspace if we don't have any workspace
Open any workspace.
Resize the app to the narrow layout.
Go back to the workspace initial page.
Resize the app to the wide layout.
Verify if the Workspace Profile page is displayed.

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Sign in with a new account
Verify that the onboarding modal is displayed
Complete the onboarding flow
Go to the settings tab.
Open the workspaces list.
Create a new workspace if we don't have any workspace
Open any workspace.
Resize the app to the narrow layout.
Go back to the workspace initial page.
Resize the app to the wide layout.
Verify if the Workspace Profile page is displayed.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-12-19.at.05.20.16.mov

Android: mWeb Chrome

Screen.Recording.2024-12-19.at.04.49.13.mov

iOS: Native

Screen.Recording.2024-12-19.at.05.37.39.mov

iOS: mWeb Safari

Screen.Recording.2024-12-19.at.04.49.47.mov

MacOS: Chrome / Safari

Screen.Recording.2024-12-19.at.04.48.35.mov

Screen.Recording.2024-12-19.at.05.15.44.mov

MacOS: Desktop

Screen.Recording.2024-12-19.at.05.18.19.mov

Screen.Recording.2024-12-19.at.05.18.38.mov

github-actions · 2024-12-18T21:47:25Z

🚧 @mountiny has triggered a test build. You can view the workflow run here.

s77rt · 2024-12-18T21:54:20Z

Bug: After resizing to wide layout the report screen is empty

Screen.Recording.2024-12-18.at.10.53.41.PM.mov

(BTW this fixes the bug)

nkdengineer · 2024-12-18T21:58:03Z

@s77rt The API is live now. I'm completing the checklist.

melvin-bot · 2024-12-18T22:22:14Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

nkdengineer · 2024-12-18T22:22:24Z

@s77rt The PR is ready.

s77rt · 2024-12-18T22:22:59Z

@nkdengineer Did you check this bug #54329 (comment)

nkdengineer · 2024-12-18T22:28:21Z

@s77rt I can't reproduce this bug in this PR.

Screen.Recording.2024-12-19.at.05.27.43.mov

s77rt · 2024-12-18T22:48:33Z

Interesting. The bug is reproducible but not reliably. Maybe that's the case on main too

s77rt · 2024-12-18T23:26:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

s77rt · 2024-12-18T23:29:13Z

Screen.Recording.2024-12-19.at.12.28.46.AM.mov

github-actions · 2024-12-18T23:42:02Z

🚧 @mountiny has triggered a test build. You can view the workflow run here.

nkdengineer · 2024-12-18T23:44:55Z

@mountiny Sorry this new commit doesn't fix the empty bug above.

mountiny

This is working well for me now

github-actions · 2024-12-19T00:08:31Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/54329/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/54329/NewExpensify.dmg	https://54329.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

mountiny · 2024-12-19T00:11:30Z

Actually still having the issue with empty report screen after testing more

nkdengineer · 2024-12-19T00:13:35Z

Yes this issue here #54329 (comment) only happens on this PR.

src/libs/Navigation/AppNavigator/useNavigationResetRootOnLayoutChange.ts

github-actions · 2024-12-19T11:27:57Z

🚧 @mountiny has triggered a test build. You can view the workflow run here.

nkdengineer · 2024-12-19T11:50:37Z

src/pages/home/ReportScreen.tsx


        Log.info(`[ReportScreen] no reportID found in params, setting it to lastAccessedReportID: ${lastAccessedReportID}`);
+        lastAccessedReportIDRef.current = lastAccessedReportID;
        navigation.setParams({reportID: lastAccessedReportID});


While the param is updating in the route, this useEffect can be triggered again, and navigation.setParams is called again with the outdated state that can cause the navigation stack to be overridden to the old state.

github-actions · 2024-12-19T11:55:49Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/54329/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/54329/NewExpensify.dmg	https://54329.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

nkdengineer · 2024-12-19T12:00:17Z

Work well on dev now.

Screen.Recording.2024-12-19.at.18.58.23.mp4

s77rt · 2024-12-19T12:30:12Z

Please fix the lint. We can use just a boolean for that ref

nkdengineer · 2024-12-19T12:38:26Z

@s77rt The lint is related to the default value lint rule. I think we can skip here to prevent regression.

nkdengineer · 2024-12-19T12:39:41Z

We can use just a boolean for that ref

Updated.

mountiny

Thanks!

melvin-bot · 2024-12-19T12:54:37Z

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

mountiny · 2024-12-19T12:55:01Z

Not an emergency, the eslint failures are related to the default id and we are not going to change it here as this is fixing a deploy blocker

OSBotify · 2024-12-19T13:04:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Julesssss · 2024-12-19T13:10:29Z

Hey @nkdengineer @s77rt. Sharing another bug report here which seems like it should be resolved with these changes?

s77rt · 2024-12-19T13:17:43Z

Unrelated. We are looking in that one as well, it's a regression from #51681

[CP Staging] fix: onboarding modal is not displayed in web (cherry picked from commit dd93c76) (CP triggered by mountiny)

github-actions · 2024-12-19T13:54:52Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.77-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2024-12-23T21:01:40Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.77-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

fix: onboarding modal is not displayed in web

faf2807

mountiny added the Ready To Build label Dec 18, 2024

s77rt mentioned this pull request Dec 18, 2024

Revert "The central page page is not rendered when resized to narrow and then to wide view again" #54328

Closed

This comment has been minimized.

Sign in to view

nkdengineer marked this pull request as ready for review December 18, 2024 22:22

nkdengineer requested a review from a team as a code owner December 18, 2024 22:22

melvin-bot bot requested a review from s77rt December 18, 2024 22:22

melvin-bot bot removed the request for review from a team December 18, 2024 22:22

mountiny assigned nkdengineer Dec 18, 2024

mountiny self-requested a review December 18, 2024 23:15

nkdengineer added 2 commits December 19, 2024 06:33

fix report is empty

a518bb4

revert pod lock

57e9632

mountiny changed the title ~~fix: onboarding modal is not displayed in web~~ [CP Staging] fix: onboarding modal is not displayed in web Dec 19, 2024

mountiny previously approved these changes Dec 19, 2024

View reviewed changes

mountiny reviewed Dec 19, 2024

View reviewed changes

src/libs/Navigation/AppNavigator/useNavigationResetRootOnLayoutChange.ts Outdated Show resolved Hide resolved

fix empty report bug

854ec2c

nkdengineer dismissed mountiny’s stale review via 854ec2c December 19, 2024 08:11

nkdengineer commented Dec 19, 2024

View reviewed changes

s77rt approved these changes Dec 19, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny December 19, 2024 12:25

use boolean ref

35c5933

mountiny approved these changes Dec 19, 2024

View reviewed changes

mountiny merged commit dd93c76 into Expensify:main Dec 19, 2024

melvin-bot bot added the Emergency label Dec 19, 2024

mountiny removed the Emergency label Dec 19, 2024

OSBotify pushed a commit that referenced this pull request Dec 19, 2024

Merge pull request #54329 from nkdengineer/fix/54322

efb31e3

[CP Staging] fix: onboarding modal is not displayed in web (cherry picked from commit dd93c76) (CP triggered by mountiny)

github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Dec 19, 2024

github-actions bot mentioned this pull request Dec 19, 2024

Deploy Checklist: New Expensify 2024-12-18 #54292

Closed

72 tasks

melvin-bot bot mentioned this pull request Dec 23, 2024

[HOLD for payment 2025-01-02] [HOLD for payment 2024-12-30] [$500] Onboarding flow is not showing upon first sign in #54322

Closed

8 tasks

Conversation

nkdengineer commented Dec 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Dec 18, 2024

Uh oh!

s77rt commented Dec 18, 2024

Uh oh!

nkdengineer commented Dec 18, 2024

Uh oh!

This comment has been minimized.

melvin-bot bot commented Dec 18, 2024

Uh oh!

nkdengineer commented Dec 18, 2024

Uh oh!

s77rt commented Dec 18, 2024

Uh oh!

nkdengineer commented Dec 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

s77rt commented Dec 18, 2024

Uh oh!

s77rt commented Dec 18, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

s77rt commented Dec 18, 2024

Uh oh!

github-actions bot commented Dec 18, 2024

Uh oh!

nkdengineer commented Dec 18, 2024

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 19, 2024

Uh oh!

mountiny commented Dec 19, 2024

Uh oh!

nkdengineer commented Dec 19, 2024

Uh oh!

Uh oh!

github-actions bot commented Dec 19, 2024

Uh oh!

nkdengineer Dec 19, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 19, 2024

Uh oh!

nkdengineer commented Dec 19, 2024

Uh oh!

s77rt commented Dec 19, 2024

Uh oh!

nkdengineer commented Dec 19, 2024

Uh oh!

nkdengineer commented Dec 19, 2024

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Dec 19, 2024

Uh oh!

mountiny commented Dec 19, 2024

Uh oh!

OSBotify commented Dec 19, 2024

Uh oh!

Julesssss commented Dec 19, 2024

Uh oh!

s77rt commented Dec 19, 2024

Uh oh!

github-actions bot commented Dec 19, 2024

Uh oh!

github-actions bot commented Dec 23, 2024

nkdengineer commented Dec 18, 2024 •

edited

Loading

nkdengineer commented Dec 18, 2024 •

edited

Loading