Skip to content

[No QA] Create workflow to warn on native file changes #54357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dangrous merged 6 commits into from
Jan 13, 2025
Merged

[No QA] Create workflow to warn on native file changes #54357

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a153e36
Create workflow to warn on native file changes
jnowakow Dec 9, 2024
f2390fb
fix workflow
jnowakow Dec 19, 2024
572cf5d
Add more files to paths
jnowakow Jan 10, 2025
a66c745
Small changes
jnowakow Jan 13, 2025
33d09b7
Merge branch 'main' into comment-on-native-files-changed
jnowakow Jan 13, 2025
085df1f
Update comment
jnowakow Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .github/workflows/commentOnNativeFileChanged.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: Comment on native files changed

on:
pull_request:
branches:
- 'main'
paths:
- '**.kt'
- '**.java'
- '**.swift'
- '**.mm'
- '**.h'
- '**.cpp'
- 'AndroidManifest.xml'
- 'project.pbxproj'

jobs:
commentOnNativeFilesChanged:
name: Create comment
runs-on: ubuntu-latest
steps:
- name: Comment
run: |
gh pr comment ${{ github.event.number }} --body \
":warning: This PR is possibly changing native code. It may cause problems in Hybrid App. Please ask Hybrid App team to review those changes in the Slack open-source channel. The C+ can help you with that. :warning:"
env:
GITHUB_TOKEN: ${{ github.token }}