Recreate a receipt for native by rezkiy37 · Pull Request #54358 · Expensify/App

rezkiy37 · 2024-12-19T11:37:32Z

Explanation of Change

The PR fixes a case when submitting the scanned expense is errored when the user kills the app while the request is in the queue. I propose reconstructing a blob of the receipt if the request is created while the user is offline.

Fixed Issues

$ #51761
PROPOSAL: #51761 (comment)

Tests

Go offline.
Submit an expense and scan a receipt with the in app camera, submit it to anyone.
Kill the app.
Re-open the app.
Go back online.
The receipt is uploaded and scanned correctly. If it fails for some reason, then the user is able to download the receipt.

Verify that no errors appear in the JS console

Offline tests

Same as tests.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Android.Chrome.mp4

iOS: Native

IOS.mp4

iOS: mWeb Safari

IOS.Safari.mp4

MacOS: Chrome / Safari

Desktop.mp4

MacOS: Desktop

Desktop.mp4

…/51761-recreate-receipt

src/libs/HttpUtils.ts

…/51761-recreate-receipt

…emove unused functions

…upport

…/51761-recreate-receipt

melvin-bot · 2024-12-28T11:14:22Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rezkiy37 · 2024-12-28T11:16:20Z

I struggle to build Android so I haven't attached a video to this platform. Please build it on your side.

allgandalf · 2024-12-30T20:34:53Z

sure thing!

allgandalf · 2025-01-02T03:22:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…/51761-recreate-receipt

neil-marcellini

Thanks for the updates, good to go

neil-marcellini · 2025-01-24T17:35:36Z

Oh, actually unit tests are failing @rezkiy37

…/51761-recreate-receipt

allgandalf · 2025-01-28T08:58:59Z

@rezkiy37 can you please fix conflicts when you're online 😄

…/51761-recreate-receipt

rezkiy37 · 2025-01-28T11:24:04Z

@allgandalf, done 🙂

neil-marcellini

I'm not really understanding why you changed the assertions for one of the tests, it seems wrong. Also, I see that you mocked the fileDownload util in almost all of the tests, then had to change many files to use named imports, I assume because this PR now touches those files.

Instead, can we set up a single global mock for all the tests, and then the PR won't have to change so many files? Please let me know if you have different ideas.

tests/actions/ReportTest.ts

…/51761-recreate-receipt

This reverts commit 23ac663.

…nctionality" This reverts commit 0ce0a09.

…rity" This reverts commit bc698ea.

rezkiy37 · 2025-01-29T13:49:11Z

I'm not really understanding why you changed the assertions for one of the tests, it seems wrong. Also, I see that you mocked the fileDownload util in almost all of the tests, then had to change many files to use named imports, I assume because this PR now touches those files.

Instead, can we set up a single global mock for all the tests, and then the PR won't have to change so many files? Please let me know if you have different ideas.

I've integrated the mock globally. I reverted many changes. It works properly now.

neil-marcellini

Thanks for the fixes, I think it's good to go.

OSBotify · 2025-01-29T17:58:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-30T01:58:48Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.92-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-31T06:48:36Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.92-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

dukenv0307 · 2026-01-07T03:33:21Z

src/libs/prepareRequestPayload/index.native.ts

+            if (key === 'receipt' && initiatedOffline) {
+                const {uri: path = '', source} = value as File;
+
+                return readFileAsync(source, path, () => {}).then((file) => {


Coming from #76975, we should use the actual file name if available, otherwise fall back to extracting from path/uri

rezkiy37 added 2 commits December 19, 2024 12:36

Add file handling utilities and enhance form data processing draft

acdd2e2

remove dev prop

50c4f59

rezkiy37 mentioned this pull request Dec 19, 2024

[HOLD for payment 2025-02-07] BUG: Receipt is deleted if app is killed while request is in queue #51761

Closed

8 tasks

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

0c2b632

…/51761-recreate-receipt

rezkiy37 changed the title ~~[WIP] Create a receipt~~ [WIP] Recreate a receipt Dec 19, 2024

allgandalf reviewed Dec 20, 2024

View reviewed changes

src/libs/HttpUtils.ts Outdated Show resolved Hide resolved

rezkiy37 added 14 commits December 20, 2024 10:30

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

2446bb8

…/51761-recreate-receipt

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

18d637f

…/51761-recreate-receipt

Refactor file reading logic to import readFileAsync dynamically and r…

04cff7b

…emove unused functions

remove import

8dd63c2

Add initiatedOffline parameter to HTTP request handling for offline s…

a9dbba9

…upport

Add initiatedOffline property to persistedRequest in SequentialQueueTest

02ae8cd

Add initiatedOffline property to persistedRequest in SequentialQueueTest

754949c

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

0888f6b

…/51761-recreate-receipt

clean processFormData

6f7f4a4

integrate prepareRequestPayload

c1a5306

integrate prepareRequestPayload

e12d29c

clean

3a389bf

lazy load readFileAsync in prepareRequestPayload

b899c11

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

38b1224

…/51761-recreate-receipt

rezkiy37 changed the title ~~[WIP] Recreate a receipt~~ Recreate a receipt for native Dec 28, 2024

rezkiy37 marked this pull request as ready for review December 28, 2024 11:14

rezkiy37 requested a review from a team as a code owner December 28, 2024 11:14

melvin-bot bot requested review from allgandalf and removed request for a team December 28, 2024 11:14

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

713c51f

…/51761-recreate-receipt

neil-marcellini previously approved these changes Jan 24, 2025

View reviewed changes

rezkiy37 added 2 commits January 27, 2025 10:47

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

cad3e6f

…/51761-recreate-receipt

Mock fileDownload utility in tests to isolate file reading functionality

0ce0a09

neil-marcellini marked this pull request as draft January 27, 2025 16:12

Refactor imports to use named exports for consistency and clarity

bc698ea

rezkiy37 dismissed neil-marcellini’s stale review via bc698ea January 27, 2025 16:36

rezkiy37 marked this pull request as ready for review January 27, 2025 16:37

rezkiy37 requested a review from neil-marcellini January 27, 2025 16:37

rezkiy37 added 2 commits January 28, 2025 10:38

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

d2963fc

…/51761-recreate-receipt

Fix expectations for API command calls in Report actions test

23ac663

neil-marcellini requested changes Jan 28, 2025

View reviewed changes

tests/actions/ReportTest.ts Outdated Show resolved Hide resolved

tests/actions/ReportTest.ts Outdated Show resolved Hide resolved

tests/actions/ReportTest.ts Outdated Show resolved Hide resolved

rezkiy37 added 7 commits January 29, 2025 10:55

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

f6304bb

…/51761-recreate-receipt

Revert "Fix expectations for API command calls in Report actions test"

c4b9318

This reverts commit 23ac663.

Revert "Mock fileDownload utility in tests to isolate file reading fu…

65d23a5

…nctionality" This reverts commit 0ce0a09.

Mock prepareRequestPayload for tests globally

57f62c8

Refactor prepareRequestPayload mock to handle dynamic data appending

4efd175

Revert "Refactor imports to use named exports for consistency and cla…

ff8d096

…rity" This reverts commit bc698ea.

Refactor ValidationUtilsTest to use translateLocal for localization

6d19d5f

rezkiy37 requested a review from neil-marcellini January 29, 2025 13:49

neil-marcellini approved these changes Jan 29, 2025

View reviewed changes

neil-marcellini merged commit 6cc411b into Expensify:main Jan 29, 2025
15 checks passed

github-actions bot mentioned this pull request Jan 30, 2025

Deploy Checklist: New Expensify 2025-01-30 #56018

Closed

48 tasks

dukenv0307 reviewed Jan 7, 2026

View reviewed changes

Conversation

rezkiy37 commented Dec 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

melvin-bot bot commented Dec 28, 2024

Uh oh!

rezkiy37 commented Dec 28, 2024

Uh oh!

allgandalf commented Dec 30, 2024

Uh oh!

allgandalf commented Jan 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini commented Jan 24, 2025

Uh oh!

allgandalf commented Jan 28, 2025

Uh oh!

rezkiy37 commented Jan 28, 2025

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rezkiy37 commented Jan 29, 2025

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jan 29, 2025

Uh oh!

github-actions bot commented Jan 30, 2025

Uh oh!

github-actions bot commented Jan 31, 2025

Uh oh!

dukenv0307 Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

rezkiy37 commented Dec 19, 2024 •

edited

Loading

allgandalf commented Jan 2, 2025 •

edited

Loading