[Internal QA]: Add additional navigation for not existing export by narefyev91 · Pull Request #54433 · Expensify/App

narefyev91 · 2024-12-20T18:48:07Z

Explanation of Change

Since you accessed the accounting integration settings from the card-level export, the nav structure tries to bring you back to the card-level export selection page. However, that page is no longer supported based on the new integration settings. I suggest that where you landed on this "no accounts found" page previously when going back, you instead land directly on the card details page, with the card-level export row gone.-->

Fixed Issues

$ #54371
PROPOSAL:

Tests

Set non-reimbursable exports to something that supports card-level export settings (like QBO credit cards). go to the card details page of an assign card.
Click the card export row.
Click the link in the subheader to go to the accounting integration settings.
Change the non-reimbursable exports to something that doesn't support card-level export settings (like QBO vendor bills).
Click back couple of times.
Verify that user lands directly to card details page
Verify that Export menu item is not shown

Verify that no errors appear in the JS console

Offline tests

No changes

QA Steps

Set non-reimbursable exports to something that supports card-level export settings (like QBO credit cards). go to the card details page of an assign card.
Click the card export row.
Click the link in the subheader to go to the accounting integration settings.
Change the non-reimbursable exports to something that doesn't support card-level export settings (like QBO vendor bills).
Click back couple of times.
Verify that user lands directly to card details page
Verify that Export menu item is not shown

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

narefyev91 · 2024-12-20T18:48:13Z

I added logic using backTo to just one connection. There are some other places which should be changed for other connections to use correct go back logic. Also needs to add util function which will return true/false based on check for valid export account (which is available for company card details page menu item). I will be back on Monday 30th and will add all these changes. For now will leave it draft

…-exists-export

melvin-bot · 2025-01-03T04:09:09Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2025-01-03T10:43:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-03.at.17.37.21.mov

Android: mWeb Chrome

Screen.Recording.2025-01-03.at.17.30.49.mov

iOS: Native

Screen.Recording.2025-01-03.at.17.36.02.mov

iOS: mWeb Safari

Screen.Recording.2025-01-03.at.17.26.45.mov

MacOS: Chrome / Safari

Screen.Recording.2025-01-03.at.16.43.35.mov

MacOS: Desktop

Screen.Recording.2025-01-03.at.17.43.26.mov

dukenv0307

LGTM

mountiny · 2025-01-06T15:50:42Z

src/pages/workspace/accounting/intacct/export/SageIntacctExportPage.tsx

+    const route = useRoute<PlatformStackRouteProp<SettingsNavigatorParamList, typeof SCREENS.WORKSPACE.ACCOUNTING.SAGE_INTACCT_EXPORT>>();
+    const backTo = route?.params?.backTo;
    const {export: exportConfig, pendingFields, errorFields} = policy?.connections?.intacct?.config ?? {};
+    const isConnectionShouldBeRemovedFromCompanyCard = exportConfig?.reimbursable === CONST.SAGE_INTACCT_REIMBURSABLE_EXPENSE_TYPE.EXPENSE_REPORT && backTo;


I dotn really understand this variable name 😂 can you please try to explain it in plain english and maybe we can find a better name

In menu item for company card - we have a row name Export %connection name%. And in some cases we should not show that row if connection is not supported. Sorry did not find a good name for variable

src/pages/workspace/accounting/intacct/export/SageIntacctExportPage.tsx

mountiny · 2025-01-06T16:24:39Z

src/pages/workspace/accounting/netsuite/export/NetSuiteExportConfigurationPage.tsx

    const {canUseNetSuiteUSATax} = usePermissions();

    const config = policy?.connections?.netsuite?.options.config;
+    const isConnectionShouldBeRemovedFromCompanyCard =


Maybe lets name it more specifically to what it will cause/ do. It would be great to also add some comment explaining why we need it

Suggested change

const isConnectionShouldBeRemovedFromCompanyCard =

const shouldgoBackToSpecificRoute =

I discussed with @narefyev91 these changes, and he is out until Friday. These are NAB changes but we should make them for better DX. We can add it to some future fixes to the flow and not hold in this

OSBotify · 2025-01-06T17:15:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-06T18:34:01Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.81-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

joekaufmanexpensify · 2025-01-07T21:35:23Z

Not fully working. After changing from credit card > vendor bills with QBO, you land on the "hmm not here" page when navigating backward instead of the card details page.

2025-01-07_16-33-23.mp4

joekaufmanexpensify · 2025-01-07T21:36:00Z

Checking off on deploy checklist as this is NAB

mountiny · 2025-01-07T21:53:02Z

@narefyev91 something to look into when you back

github-actions · 2025-01-08T02:44:52Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.81-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

narefyev91 · 2025-01-08T08:50:21Z

@narefyev91 something to look into when you back

Sure - will take a look

mananjadhav · 2025-03-10T16:40:00Z

src/pages/workspace/companyCards/WorkspaceCompanyCardAccountSelectCardPage.tsx

    const card = allBankCards?.[cardID];
    const connectedIntegration = PolicyUtils.getConnectedIntegration(policy) ?? CONST.POLICY.CONNECTIONS.NAME.QBO;
-    const exportMenuItem = getExportMenuItem(connectedIntegration, policyID, translate, policy, card);
+    const exportMenuItem = getExportMenuItem(connectedIntegration, policyID, translate, policy, card, backTo);


We should've passed the active route here, which we fixed it here

Add additional navigation for not existing export

4c4aca0

narefyev91 added 4 commits December 30, 2024 18:16

Merge branch 'refs/heads/main' into add-additional-navigation-for-not…

322a2dd

…-exists-export

add changes for routes support

d89e603

add logic for check not available account options for company cards

38c538b

add reimbursable logic

e9776d4

narefyev91 marked this pull request as ready for review January 3, 2025 04:09

narefyev91 requested a review from a team as a code owner January 3, 2025 04:09

melvin-bot bot requested review from dukenv0307 and removed request for a team January 3, 2025 04:09

dukenv0307 approved these changes Jan 3, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny January 3, 2025 10:44

mountiny assigned narefyev91 Jan 6, 2025

mountiny added the InternalQA This pull request required internal QA label Jan 6, 2025

mountiny requested changes Jan 6, 2025

View reviewed changes

mountiny reviewed Jan 6, 2025

View reviewed changes

mountiny approved these changes Jan 6, 2025

View reviewed changes

mountiny merged commit 8381d8f into Expensify:main Jan 6, 2025

github-actions bot mentioned this pull request Jan 6, 2025

Deploy Checklist: New Expensify 2025-01-06 #54825

Closed

74 tasks

melvin-bot bot mentioned this pull request Jan 8, 2025

[HOLD for payment 2025-01-30] [HOLD for payment 2025-01-28] [HOLD for payment 2025-01-15] "No Accounts" Page for Unsupported Card-Level Export Options #54371

Closed

8 tasks

daledah mentioned this pull request Mar 5, 2025

[$250] Company cards - QBO: RHP closes when clicking back button on Export page after a page reload #57814

Closed

8 tasks

mananjadhav reviewed Mar 10, 2025

View reviewed changes

narefyev91 mentioned this pull request Apr 16, 2025

[Internal QA]: Add QBD to company card export #60120

Merged

50 tasks

	const isConnectionShouldBeRemovedFromCompanyCard =
	const shouldgoBackToSpecificRoute =

Conversation

narefyev91 commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

narefyev91 commented Dec 20, 2024

Uh oh!

melvin-bot bot commented Jan 3, 2025

Uh oh!

dukenv0307 commented Jan 3, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Jan 6, 2025

Choose a reason for hiding this comment

Uh oh!

narefyev91 Jan 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mountiny Jan 6, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny Jan 6, 2025

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jan 6, 2025

Uh oh!

github-actions bot commented Jan 6, 2025

Uh oh!

joekaufmanexpensify commented Jan 7, 2025

Uh oh!

joekaufmanexpensify commented Jan 7, 2025

Uh oh!

mountiny commented Jan 7, 2025

Uh oh!

github-actions bot commented Jan 8, 2025

Uh oh!

narefyev91 commented Jan 8, 2025

Uh oh!

mananjadhav Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

narefyev91 commented Dec 20, 2024 •

edited

Loading