feat: [Auth Violations] Support isDismissed on newDot to hide violations.#54455
feat: [Auth Violations] Support isDismissed on newDot to hide violations.#54455pecanoro merged 42 commits intoExpensify:mainfrom
Conversation
…ons. Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
Hmm, not sure why lint warnings increases every time I commit changes. |
| }; | ||
| } | ||
| if (TransactionUtils.hasPendingRTERViolation(TransactionUtils.getTransactionViolations(transaction?.transactionID ?? '-1', transactionViolations))) { | ||
| if (TransactionUtils.hasPendingRTERViolation(TransactionUtils.getTransactionViolations(transaction?.transactionID))) { |
There was a problem hiding this comment.
@rojiphil, could you please check the ESLint failures below? I have already resolved dozens of those but it keeps increasing everytime I push a commit. I want your help especially in resolving the warning just below this comment and when we use ?? while getting a route, I have no idea how to deal with that, please let me know if you are familiar with that. Thanks 🙏🏻
There was a problem hiding this comment.
In the case of calling route, can we not do an early return as shown below? It does not seem correct to call navigate with an invalid report id anyway.
The guidelines for the fix of the ESlint failures is already mentioned here. Please look for similar handling for ESlint failures elsewhere in code as that can help. But let me know if you get stuck otherwise.
if(!reportID) {
return;
}
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
I will fix ESLint issues again today. |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
Finally🥴, all the lint issues are fixed, I'm on my way to record the videos... @rojiphil do you know how to replicate RTER violation? |
|
@Krishna2323 Is it ready for @rojiphil's review? |
|
@pecanoro, the code changes are done (new ESLint check issues😬). I was trying to record videos for native platforms, and it was failing on iOS a few days back. I will try again and upload them today. By the way, do you know how to replicate an RTER violation? |
|
@Krishna2323 This issue is for a different bug but it explains how the RTER violation is triggered: #47511 |
|
@pecanoro, I think a company card is required to trigger an RTER violation, or is there alternative way? |
@Krishna2323 You can record for the remaining scenarios and during PR review stage we can see how we can ensure validating the fix for RTER violation. Does this help? |
|
Yeah, we can do that, I will try to find an account that we can use to check if it works for RTER |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
Unit tests are failing. Is this because of our PR? Can you please merge it with the latest? |
|
@rojiphil, the Unit tests are still failing and it's not because of our PR. |
Yeah. Just raised this as an issue in slack here |
@pecanoro Changes LGTM and works well too. Unit test failure is not related to our PR and is fixed elsewhere. 54455-retest-001.mp4 |
|
@pecanoro looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
|
🚀 Deployed to staging by https://github.com/pecanoro in version: 9.0.94-0 🚀
|
|
Oh! The PR is reverted. We will have to create a new PR |
|
@rojiphil, the PR isn't reverted yet, I have taken some time before we revert the PR, please let me know if you find something that is causing the issue. |
[CP Staging] Revert "Merge pull request #54455 from Krishna2323/krishna2323/issue/…
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.94-25 🚀
|
|
🚀 Deployed to staging by https://github.com/pecanoro in version: 9.0.95-0 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.94-25 🚀
|
* main: (194 commits) fix LHN user name disappears from WS admin rooms feat: bump jvm heap memory size Update Mobile-Expensify submodule version to 9.0.95-0 Update version to 9.0.95-0 lint fix improve comment Update Mobile-Expensify submodule version to 9.0.94-25 Update version to 9.0.94-25 move export move diff move method resolve conflict Revert "Merge pull request #54455 from Krishna2323/krishna2323/issue/53398" Update Mobile-Expensify submodule version to 9.0.94-24 Update version to 9.0.94-24 minor update. Update Mobile-Expensify submodule version to 9.0.94-23 Update version to 9.0.94-23 Rebuild gh actions Remove unnecessary sparse checkout from setupGitForOSBotifyApp ...
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.95-6 🚀
|
3 participants
Explanation of Change
Fixed Issues
$ #53398
PROPOSAL: #53398 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android_native.mp4
Android: mWeb Chrome
android_chrome.mp4
iOS: Native
ios_native.mp4
iOS: mWeb Safari
ios_safari.mp4
MacOS: Chrome / Safari
web_chrome.mp4
MacOS: Desktop
desktop_app.mp4