[CP Staging] Add loading state to ProductTrainingContextProvider#54865
[CP Staging] Add loading state to ProductTrainingContextProvider#54865Beamanator merged 3 commits intoExpensify:mainfrom
Conversation
|
🚧 @Beamanator has triggered a test build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪 |
|
@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
I will review this one |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2025-01-07.at.3.20.25.PM.movScreen.Recording.2025-01-07.at.3.22.18.PM.movAndroid: mWeb ChromeScreen.Recording.2025-01-07.at.3.14.23.PM.movScreen.Recording.2025-01-07.at.3.12.53.PM.moviOS: NativeSimulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-07.at.15.32.01.mp4iOS: mWeb SafariSimulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-07.at.15.10.57.mp4MacOS: Chrome / SafariScreen.Recording.2025-01-07.at.3.06.12.PM.movScreen.Recording.2025-01-07.at.3.06.59.PM.movMacOS: DesktopScreen.Recording.2025-01-07.at.3.08.19.PM.mov |
|
requested CP! |
[CP Staging] Add loading state to ProductTrainingContextProvider (cherry picked from commit 8f3fe5f) (CP triggered by mountiny)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.81-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.81-6 🚀
|
Explanation of Change
Fixed Issues
$ #54859
$ #54841
PROPOSAL:
Tests
Test 1:
Expected: The tooltip should only appear on the "+" button
Test 2:
Expected Result:
FAB tooltip will not appear during login because it has been dismissed in Step 3.
Offline tests
QA Steps
Same as test steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Record_2025-01-07-17-17-49.mp4
Android: mWeb Chrome
Record_2025-01-07-17-13-57.mp4
iOS: Native
trim.00451559-3CE9-4CF5-9D92-867647BB46E9.MOV
iOS: mWeb Safari
trim.EAF6D08E-80F5-4883-9B1C-D44548EC4EEF.MOV
MacOS: Chrome / Safari
Screen.Recording.2025-01-07.at.4.15.06.PM.mov
Screen.Recording.2025-01-07.at.3.52.20.PM.mov
MacOS: Desktop
Screen.Recording.2025-01-07.at.5.26.33.PM.mov