Fix hidden shows when sending invoice to new user#54868
Merged
justinpersaud merged 8 commits intoExpensify:mainfrom Jan 15, 2025
Merged
Fix hidden shows when sending invoice to new user#54868justinpersaud merged 8 commits intoExpensify:mainfrom
justinpersaud merged 8 commits intoExpensify:mainfrom
Conversation
bernhardoj
commented
Jan 7, 2025
| payerOrApproverName = ReportUtils.getPolicyName(chatReport, undefined, policy); | ||
| } else if (isInvoiceRoom) { | ||
| payerOrApproverName = ReportUtils.getInvoicePayerName(chatReport, invoiceReceiverPolicy); | ||
| payerOrApproverName = ReportUtils.getInvoicePayerName(chatReport, invoiceReceiverPolicy, invoiceReceiverPersonalDetail); |
Contributor
Author
There was a problem hiding this comment.
I can repro it on mobile for report preview, so I fix it here too.
Contributor
Author
I'm trying to create the unit test, but it is always success. I can't find a way to replicate the above behavior. |
Contributor
|
Higher priority work got in the way today, will get to this tomorrow! |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid-app-2025-01-10_16.20.47.mp4Android: mWeb Chromeandroid-chrome-2025-01-10_16.22.12.mp4iOS: Nativeios-app-2025-01-10_16.46.12.mp4iOS: mWeb Safariios-safari-2025-01-10_16.47.50.mp4MacOS: Chrome / Safaridesktop-chrome-2025-01-10_16.10.30.mp4MacOS: Desktopdesktop-app-2025-01-10_16.16.10.mp4 |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Maybe you can try asking on Slack? Or do you think it would just be unnecessarily difficult to replicate? |
Contributor
Author
My bad, somehow I forgot to commit passing the personal details
I think we need a test so it's run on a browser so the environment is replicated too. Also, I think it's really an edge case where we depend on the data on the Onyx.connect which is not the best practice because it's not syncing to the view component. Since we don't depend on Onyx.connect on this PR, I think it's fine to create a test to make sure the component (display name) is re-rendered when the personal detail is updated (even though it works like this already, but just to prevent future issues). What do you think? |
Contributor
@bernhardoj That sounds like a good idea to me! |
Contributor
Author
|
Done |
Contributor
|
@bernhardoj You have conflicts. |
Contributor
Author
|
fixed |
justinpersaud
approved these changes
Jan 15, 2025
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
github-actions
bot
added
the
DeployBlockerCash
Contributor
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
Contributor
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
Contributor
|
Reverted because the test was flaky, more details in the revert PR |
60 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/justinpersaud in version: 9.0.87-0 🚀
|
8 tasks
Contributor
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.87-3 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #54211
PROPOSAL: #54211 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
android.mweb.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
ios.mweb.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4