Skip to content

Add useCallback to avoid unnecessary rerenders of FloatingMessageCounter #54944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasperhuangg merged 1 commit into from
Jan 21, 2025
Merged

Add useCallback to avoid unnecessary rerenders of FloatingMessageCounter #54944

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pages/home/report/ReportActionsList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ function ReportActionsList({
onScroll?.(event);
};

const scrollToBottomAndMarkReportAsRead = () => {
const scrollToBottomAndMarkReportAsRead = useCallback(() => {
if (!hasNewestReportAction) {
Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report.reportID));
openReport(report.reportID);
Expand All @@ -524,7 +524,7 @@ function ReportActionsList({
reportScrollManager.scrollToBottom();
readActionSkipped.current = false;
readNewestAction(report.reportID);
};
}, [report.reportID, reportScrollManager, hasNewestReportAction]);

/**
* Calculates the ideal number of report actions to render in the first render, based on the screen height and on
Expand Down