add tasks for new user first workspace

[ishpaul777]

Explanation of Change

Fixed Issues

$ #53509
PROPOSAL:

Tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[ishpaul777]

I dont understand the lint failure and how my changes can cause it @mananjadhav any ideas?

[ishpaul777]

okay i figure that prepareOnboardingOnyxData is defined in @libs/actions/Report.ts and used in @libs/actions/Policy/Policy.ts causing this lint failure its still weird that that lint is failing on out of context function defination.

we can not just move prepareOnboardingOnyxData into a Reportutils since has been calling Onyx.merge which should be called in action which again cause a lint failure here plus its a lot unncessary code refactoring since prepareOnboardingOnyxData not exactly calling a API (which is what we want to prevent with this lint failure) i am leaning on suppressing the lint. Any thought against it?

[mananjadhav]

Let me try to take a look at the method and the refactor. Is the rest of the PR ready for review?

[ishpaul777]

yes its ready, sadly i could not test any other cases other than 'Track and budget Expenses" option, becuase that doesn't create a self dm ( its a bug i have reported here)

[ishpaul777]

i am thinking of completing checklist once i have 👍 from you on changes till now

[francoisl]

Did we change something with the upgrade flow with categorizing expenses in the Track flow?
If I sign up with the intent "Track and budget expenses", then create a Track expense, then choose the action "Categorize it", it now opens a modal with a button "Go to workspaces" instead of a direct "Upgrade" button like on main or staging.

Now	staging & main

[ishpaul777]

@francoisl merging main solves the issue, its just that this branch was behind few commits

[mananjadhav]

@ishpaul777 The last commit wasn't a signed commit. Can you please fix that?

I also checked a possibility of refactoring the prepareOnboardingOptimisticData but it's too large to be moved outside of actions. Ihought we could send the data with buildPolicyData. This method is also a part of the actions, may be the lint is for incremental changes.

@francoisl Should we ignore the rule for this particular instance?

[ishpaul777]

sorry guys i messed up the commit history while trying to sign the unsigned commit 😭 (blame chatGPT for it)

[ishpaul777]

fixed in new PR #55302, @mananjadhav lets move the conv. about lint failure there