[NoQA] NSQS by s77rt · Pull Request #55049 · Expensify/App

s77rt · 2025-01-10T02:31:44Z

Explanation of Change

Fixed Issues

$ #55495
#55496
#55497
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

s77rt · 2025-01-10T21:58:03Z

s77rt · 2025-01-21T07:17:10Z

Disclaimer: The multi connection selector works best for 2 linked connections at most. To handle more I need to add the following logic:

Select a new designated connection if the primary designated connection is the connected integration. Example: C1,C2,C3 are linked, with C1 being the designated display connection. But if C1 is already connected, we need to set C2 to be the new designated display connection. This is needed for the "Other integrations" section in the policy accounting page.
Filter out the selected connection in multi-connection selector page

I don't see this as a blocker as we don't have more than 2 linked connection thus not going to include this logic yet.

s77rt · 2025-01-21T09:29:59Z

Bug; If you try to connect using the multi-connection page then go back and forth again, the disconnect prompt is always re-displayed.

Screen.Recording.2025-01-21.at.10.25.12.AM.mov

Fix attempt 1: If I force going back to the correct route (without the integrationToDisconnect params, etc.), the bug is fixed but the navigation direction is not correct.

Screen.Recording.2025-01-21.at.10.28.27.AM.mov

…necting to multi connection route

yuwenmemon

Looking good, but had some comments. I really wish we broke this up into smaller PRs. But we can revise as long as things are hidden well under the beta for now.

src/CONST.ts

yuwenmemon · 2025-02-04T01:19:49Z

src/languages/en.ts

        },
+        nsqs: {
+            setup: {
+                title: 'NetSuite setup',


Let's rename everything that's NetSuite to NSQS here and below.

The default value of imports mapping is NETSUITE_DEFAULT which translates to NetSuite employee default. Should I:

Change default value (requires BE changes) to NSQS_DEFAULT and create a new translation for this entity

Keep NETSUITE_DEFAULT but use custom translation for NSQS

Do nothing

yuwenmemon · 2025-02-04T01:22:16Z

src/languages/es.ts

        },
+        nsqs: {
+            setup: {
+                title: 'Netsuite configuración',


Same here NSQS

src/pages/workspace/accounting/nsqs/advanced/NSQSApprovalAccountPage.tsx

yuwenmemon · 2025-02-04T01:31:35Z

Also you have some ESLint checks failing and you need to fill out the PR Author Checklist.

s77rt · 2025-02-04T01:45:23Z

The current failing lint rules are not really caused by this PR. It's only because I touched those files the linter is complaining about them. They will be fixed in main eventually. Will also merge main to see if they got fixed already

s77rt · 2025-02-04T17:41:41Z

Update:

I have resolved the review comments except one small detail [NoQA] NSQS #55049 (comment)
I used the translations given by JaimeGPT but didn't get confirmation yet. This shouldn't be a blocker, I will update the translation after merge if necessary
I don't have a solution yet for [NoQA] NSQS #55049 (comment) but this shouldn't be a blocker

ikevin127

🟢 Just reviewed again and I approve with the following mentions:

⚠️ remaining non-blocker issues mentioned by author in comment, which IMO can be addressed in a follow-up PR (if we want to merge today)
🇪🇸 translations were added in PR but not confirmed yet on Slack
regarding ❌ Eslint failing -> it's caused by changes in 2 files because of the rulesdir/no-default-id-values rule. Since the author only touched the files without changing the logic related to where the rule popped up -> we can merge like this or insist that author fix them (I've seen both ways done in the past, up to CME)

We decided in Slack that the first 2 bullet points can be addressed in a follow-up and we're in talks to possibly fix the eslint issue if author is available.

yuwenmemon

Merging with the ESLint failure because it is from an edited file but not a direct result of this PR

melvin-bot · 2025-02-04T22:28:04Z

@yuwenmemon looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

yuwenmemon · 2025-02-04T22:29:30Z

Not am emergency, see the merge comment.

github-actions · 2025-02-06T22:00:55Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.95-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-02-11T02:12:14Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.95-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

s77rt changed the title ~~NetSuite QuickStart~~ NSQS Jan 17, 2025

s77rt force-pushed the netsuite-quickstart branch from 0c271e5 to 580d6e4 Compare January 21, 2025 09:19

s77rt added 21 commits January 21, 2025 21:54

multiselector draft

0ab8da6

added remaining pages

bec781f

use correct copy on multiconnector page

4e74f7e

prepare for use of multi connection mapping

c171474

move multi connection mapping to CONST

e3562eb

Import: Add API

73bfcc1

better Option type

d67f357

remove unused import

86cf5e8

Export: Add API

9bc3a2c

Advanced: Add API

2941339

Export: added exporters list

47d3bdc

Advanced: added approval accounts list

e8d0c41

Advanced: use account.name for approval account menu item title

9593f66

rename to NSQS

f1600a1

added connect and sync commands

14bc440

add temp comment

1618f8d

fixed Other integrations logic

15e04ce

set popoverAnchorRefs

4480082

remove unused imports

f4bbccb

pass integrationToDisconnect and shouldDisconnectIntegrationBeforeCon…

70094b4

…necting to multi connection route

use correct params for nsqs connection

7efbf46

s77rt force-pushed the netsuite-quickstart branch from 580d6e4 to 7efbf46 Compare January 21, 2025 20:55

s77rt added 2 commits January 21, 2025 22:05

netsuite legacy: dismiss modal on submit

90a3f2f

lock behind beta

62cb9b5

yuwenmemon self-requested a review January 21, 2025 21:50

yuwenmemon requested changes Feb 4, 2025

View reviewed changes

s77rt added 9 commits February 4, 2025 13:03

Merge branch 'main' into netsuite-quickstart

4d45810

rename connection to netsuiteQuickStart

3866916

use NSQS term instead of NetSuite in NSQS pages

e78993a

update pages to use netsuiteQuickStart key config

ec56acf

remove unused import type translation

bd4e53c

remove redundant multi connection mappings

56df2bb

typecheck

9df34d2

use payableAccounts instead of payableList

26733ae

add spanish translation

af291ed

s77rt changed the title ~~NSQS~~ [NoQA] NSQS Feb 4, 2025

Merge branch 'main' into netsuite-quickstart

5137770

yuwenmemon requested review from ikevin127 and removed request for alitoshmatov February 4, 2025 22:04

ikevin127 approved these changes Feb 4, 2025

View reviewed changes

melvin-bot bot requested a review from yuwenmemon February 4, 2025 22:12

yuwenmemon approved these changes Feb 4, 2025

View reviewed changes

yuwenmemon merged commit 1526f42 into Expensify:main Feb 4, 2025
14 of 15 checks passed

melvin-bot bot added the Emergency label Feb 4, 2025

yuwenmemon removed the Emergency label Feb 4, 2025

github-actions bot mentioned this pull request Feb 6, 2025

Deploy Checklist: New Expensify 2025-02-06 #56482

Closed

s77rt mentioned this pull request Feb 24, 2025

[HOLD for payment 2025-02-27] [$250] Bug: Going back and forth on multi connection page displays a disconnect prompt. #56385

Closed

rayane-d mentioned this pull request Mar 30, 2025

NSQS: Remove NSQS #58537

Merged

50 tasks

Conversation

s77rt commented Jan 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

s77rt commented Jan 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

s77rt commented Jan 21, 2025

Uh oh!

s77rt commented Jan 21, 2025

Uh oh!

yuwenmemon left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

yuwenmemon Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

s77rt Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

yuwenmemon Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yuwenmemon commented Feb 4, 2025

Uh oh!

s77rt commented Feb 4, 2025

Uh oh!

s77rt commented Feb 4, 2025

Uh oh!

ikevin127 left a comment

Choose a reason for hiding this comment

Uh oh!

yuwenmemon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melvin-bot bot commented Feb 4, 2025

Uh oh!

yuwenmemon commented Feb 4, 2025

Uh oh!

github-actions bot commented Feb 6, 2025

Uh oh!

github-actions bot commented Feb 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

s77rt commented Jan 10, 2025 •

edited

Loading

s77rt commented Jan 10, 2025 •

edited

Loading

yuwenmemon left a comment •

edited

Loading