Align default IDs in ReportScreen file by VickyStash · Pull Request #55074 · Expensify/App

VickyStash · 2025-01-10T14:44:11Z

Explanation of Change

Align default IDs in ReportScreen file

Fixed Issues

$ #50360
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Open the app, log in
Look through different chats (1-1, workspace chats, self DM). Make sure the chats look as expected - both loading and data.
Open 1-1 chat, make sure next functionality works as expected:

send a message and add reaction to it
open the message thread and send one more message inside
send an attachmnet
send a Task and open it
submit an expense and then open it

From the FAB:

create a group chat, make sure it's loaded and looks as expected
send an expense, make sure the right report is opened

Offline tests

Same, as in the Tests section

QA Steps

Verify that no errors appear in the JS console

Same, as in the Tests section

PR Author Checklist

Screenshots/Videos

Android: Native

android_1.mp4

Android: mWeb Chrome

android_web_1.mp4

iOS: Native

ios1.mp4

iOS: mWeb Safari

ios_web1.mp4

MacOS: Chrome / Safari

web_1.mp4

MacOS: Desktop

desktop_1.mp4

desktop_2.mp4

…align-default-ids # Conflicts: # src/ROUTES.ts # src/pages/home/HeaderView.tsx

…align-default-ids

melvin-bot · 2025-01-13T17:17:59Z

@paultsimura Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/ReportUtils.ts

src/pages/home/HeaderView.tsx

…align-default-ids # Conflicts: # .eslintrc.changed.js # src/ROUTES.ts

VickyStash · 2025-01-14T09:14:35Z

After merging the latest main I have a bunch of import related errors:
Namespace imports from @userActions are not allowed. Use named imports instead. Example: import { action } from "@userActions/module" no-restricted-syntax

@fabioh8010 @paultsimura Should I resolve them in this PR?
I can do that, just want to confirm since it will make the PR even more complicated.

fabioh8010 · 2025-01-14T10:56:33Z

After merging the latest main I have a bunch of import related errors: Namespace imports from @userActions are not allowed. Use named imports instead. Example: import { action } from "@userActions/module" no-restricted-syntax

@fabioh8010 @paultsimura Should I resolve them in this PR? I can do that, just want to confirm since it will make the PR even more complicated.

I think we should treat this in a follow-up PR to avoid overcomplicating this one.

src/libs/Notification/clearReportNotifications/index.native.ts

src/libs/Notification/LocalNotification/index.ts

src/libs/Notification/LocalNotification/index.desktop.ts

src/hooks/usePaginatedReportActions.ts

paultsimura · 2025-01-14T16:18:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android.webm

Android: mWeb Chrome

chrome.webm

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-01-14.at.17.13.18.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-01-14.at.17.15.07.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-01-14.at.16.59.32.mov

MacOS: Desktop

Screen.Recording.2025-01-14.at.17.03.48.mov

…align-default-ids # Conflicts: # .eslintrc.changed.js

paultsimura

LGTM ✔️

Note

The lint errors will be handled in a follow-up PR to reduce the complexity of these changes.

neil-marcellini

Great work, good to go

melvin-bot · 2025-01-15T18:50:31Z

@neil-marcellini looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

neil-marcellini · 2025-01-15T18:50:57Z

Not an emergency, we're going to handle some lint fixes separately as noted by others above.

OSBotify · 2025-01-15T18:58:40Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-17T13:55:14Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.87-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-21T08:08:18Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.87-3 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

VickyStash added 6 commits January 10, 2025 12:01

Remove ReportScreen from the ignored list

961f724

Align default ids usages

1f90425

Update the test

d09a20b

Code improvements

880cb7e

Fix lint errors

0ca71c2

Merge branch 'refs/heads/main' into VickyStash/refactor/ReportScreen-…

a752937

…align-default-ids # Conflicts: # src/ROUTES.ts # src/pages/home/HeaderView.tsx

VickyStash added 5 commits January 13, 2025 12:34

Merge branch 'refs/heads/main' into VickyStash/refactor/ReportScreen-…

be52463

…align-default-ids

Minor improvement

a5ed2e0

Merge branch 'refs/heads/main' into VickyStash/refactor/ReportScreen-…

bb1239e

…align-default-ids

Fixes

d8c95eb

Lint fixes

a09caa5

VickyStash marked this pull request as ready for review January 13, 2025 17:17

VickyStash requested a review from a team as a code owner January 13, 2025 17:17

melvin-bot bot requested review from paultsimura and removed request for a team January 13, 2025 17:17

fabioh8010 reviewed Jan 13, 2025

View reviewed changes

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

src/pages/home/HeaderView.tsx Outdated Show resolved Hide resolved

src/pages/home/HeaderView.tsx Outdated Show resolved Hide resolved

Merge branch 'refs/heads/main' into VickyStash/refactor/ReportScreen-…

590070f

…align-default-ids # Conflicts: # .eslintrc.changed.js # src/ROUTES.ts

VickyStash added 3 commits January 14, 2025 10:27

Use getNonEmptyStringOnyxID instead of getNonEmptyStringReportID

ee611e6

Prettier fix

c6f17e4

Minor improvement

e515c23

fabioh8010 approved these changes Jan 14, 2025

View reviewed changes

paultsimura reviewed Jan 14, 2025

View reviewed changes

src/libs/Notification/clearReportNotifications/index.native.ts Show resolved Hide resolved

src/libs/Notification/LocalNotification/index.ts Show resolved Hide resolved

src/libs/Notification/LocalNotification/index.desktop.ts Show resolved Hide resolved

paultsimura reviewed Jan 14, 2025

View reviewed changes

src/hooks/usePaginatedReportActions.ts Outdated Show resolved Hide resolved

src/hooks/usePaginatedReportActions.ts Outdated Show resolved Hide resolved

VickyStash added 2 commits January 15, 2025 11:00

Merge branch 'refs/heads/main' into VickyStash/refactor/ReportScreen-…

9c66425

…align-default-ids # Conflicts: # .eslintrc.changed.js

Apply reviewer feedback

f56d380

paultsimura approved these changes Jan 15, 2025

View reviewed changes

melvin-bot bot requested a review from neil-marcellini January 15, 2025 11:18

neil-marcellini approved these changes Jan 15, 2025

View reviewed changes

neil-marcellini merged commit 79f60ec into Expensify:main Jan 15, 2025

melvin-bot bot added the Emergency label Jan 15, 2025

neil-marcellini removed the Emergency label Jan 15, 2025

github-actions bot mentioned this pull request Jan 17, 2025

Deploy Checklist: New Expensify 2025-01-17 #55396

Closed

60 tasks

Conversation

VickyStash commented Jan 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

VickyStash commented Jan 14, 2025

Uh oh!

fabioh8010 commented Jan 14, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

paultsimura commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

paultsimura left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Jan 15, 2025

Uh oh!

neil-marcellini commented Jan 15, 2025

Uh oh!

OSBotify commented Jan 15, 2025

Uh oh!

github-actions bot commented Jan 17, 2025

Uh oh!

github-actions bot commented Jan 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

VickyStash commented Jan 10, 2025 •

edited

Loading

paultsimura commented Jan 14, 2025 •

edited

Loading