Add tooltip for the inactive tab in the create expense page when the tab title is hidden by Shahidullah-Muffakir · Pull Request #55216 · Expensify/App

Shahidullah-Muffakir · 2025-01-14T15:31:07Z

Explanation of Change

Add tooltip for the inactive tab in the create expense page when the tab title is hidden

Fixed Issues

$ #55032
PROPOSAL: #55032 (comment)

Tests

Import perdiem in the workspace
Click create expense from the green +
Hover on the tabs which does not have labels
Verify that the tooltip is shown

Verify that no errors appear in the JS console

Offline tests

Import perdiem in the workspace
Click create expense from the green +
Hover on the tabs which does not have labels
Verify that the tooltip is shown

QA Steps

Import perdiem in the workspace
Click create expense from the green +
Hover on the tabs which does not have labels
Verify that the tooltip is shown

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-16.at.7.21.21.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-01-16.at.5.58.33.PM.mov

iOS: Native

ios.native.mov

iOS: mWeb Safari

ios.safari.mov

MacOS: Chrome / Safari

macos.web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2025-01-14T15:31:12Z

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ahmedGaber93 · 2025-01-15T07:01:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

20250116101155474.mp4

Android: mWeb Chrome

20250116101443270.mp4

iOS: Native

iOS: mWeb Safari

20250116101659951.mp4

MacOS: Chrome / Safari

20250116101757101.mp4

MacOS: Desktop

20250116102113791.mp4

ahmedGaber93 · 2025-01-15T14:10:21Z

tests/ui/components/TabSelectorItem.tsx

+        screen.findByText(tooltipText).then((tooltip) => {
+            expect(tooltip).toBeTruthy();
+        });


I think you should use async await instead of promise here because the below lines will call before promise onResolve

And any way if we use async await expect(await screen.findByText(tooltipText)).toBeTruthy(); the test is failed

Thanks for the review, I will update it.

Shahidullah-Muffakir · 2025-01-15T18:59:10Z

@ahmedGaber93 I’ve added the changes.

ahmedGaber93 · 2025-01-16T03:18:56Z

tests/ui/components/TabSelectorItem.tsx

+jest.mock('@components/Tooltip', () => {
+    return jest.fn(({children, shouldRender, text}: {children: React.ReactNode; shouldRender: boolean; text: string}) => {
+        return (
+            <>
+                {shouldRender && <div data-testid="tooltip">{text}</div>}
+                {children}
+            </>
+        );
+    });
+});


Since we just test with toHaveBeenCalledWith, I think we can simply mock with empty jest.fn

jest.mock('@components/Tooltip', () => jest.fn()); jest.mock('@components/Tooltip'); // factory param already have empty function as a default

ahmedGaber93 · 2025-01-16T03:33:53Z

tests/ui/components/TabSelectorItem.tsx

+        const button = screen.getByRole(CONST.ROLE.BUTTON, {name: defaultProps.title});
+        fireEvent(button, 'hoverIn');


I think hoverIn will not trigger anything because we mocked up the Tooltip. Also, it looks related to Tooltip test not TabSelectorItem test.
Let's remove it, the below test that check the Tooltip is called with the correct props is a good enough.

Thanks for the valuable feedback, updated.

ahmedGaber93 · 2025-01-16T03:35:00Z

tests/ui/components/TabSelectorItem.tsx

+    const defaultProps = {
+        title: 'Test Tab',
+        icon: 'icon-home',
+        onPress: jest.fn(),
+    };


Unused parameters, we just use the title here.

Also use it below as a const instead of duplicate initialization in title="Test Tab"

ahmedGaber93 · 2025-01-16T07:57:17Z

@Shahidullah-Muffakir could you please add screenshots for native apps to confirm the UI is not broken?

Shahidullah-Muffakir · 2025-01-16T11:14:00Z

@Shahidullah-Muffakir could you please add screenshots for native apps to confirm the UI is not broken?

@ahmedGaber93 Sure, just to confirm, we're not expecting the tooltip to appear on mWeb and native apps, correct?

ahmedGaber93 · 2025-01-16T11:42:10Z

Yeah, that's correct. The purpose of testing native apps is to confirm everything is still working and UI is not broken .

ahmedGaber93

LGTM!

NikkiWines

👍 Looks great

OSBotify · 2025-01-16T14:13:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-17T13:55:35Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.0.87-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-21T08:08:39Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.87-3 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

Add tooltip for the inactive tab in the create expense page

3cc368c

Shahidullah-Muffakir requested a review from a team as a code owner January 14, 2025 15:31

melvin-bot bot requested review from ahmedGaber93 and removed request for a team January 14, 2025 15:31

ahmedGaber93 reviewed Jan 15, 2025

View reviewed changes

update TabSelectorItem unit test for Tooltip on hover

c9743b5

ahmedGaber93 suggested changes Jan 16, 2025

View reviewed changes

updated the Unit test for Tooltip in TabSelectorItem

831a941

ahmedGaber93 approved these changes Jan 16, 2025

View reviewed changes

melvin-bot bot requested a review from NikkiWines January 16, 2025 12:12

NikkiWines approved these changes Jan 16, 2025

View reviewed changes

NikkiWines merged commit 86a7c90 into Expensify:main Jan 16, 2025

github-actions bot mentioned this pull request Jan 17, 2025

Deploy Checklist: New Expensify 2025-01-17 #55396

Closed

60 tasks

melvin-bot bot mentioned this pull request Jan 21, 2025

[HOLD for payment 2025-01-28] [$250] Tooltips are missing in the create expense page for the tabs with no labels #55032

Closed

8 tasks

		const button = screen.getByRole(CONST.ROLE.BUTTON, {name: defaultProps.title});
		fireEvent(button, 'hoverIn');

Conversation

Shahidullah-Muffakir commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 14, 2025

Uh oh!

ahmedGaber93 commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Shahidullah-Muffakir commented Jan 15, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ahmedGaber93 commented Jan 16, 2025

Uh oh!

Shahidullah-Muffakir commented Jan 16, 2025

Uh oh!

ahmedGaber93 commented Jan 16, 2025

Uh oh!

ahmedGaber93 left a comment

Choose a reason for hiding this comment

Uh oh!

NikkiWines left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jan 16, 2025

Uh oh!

github-actions bot commented Jan 17, 2025

Uh oh!

github-actions bot commented Jan 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Shahidullah-Muffakir commented Jan 14, 2025 •

edited

Loading

ahmedGaber93 commented Jan 15, 2025 •

edited

Loading