Add report fraud confirmation page when getting new virtual card by burczu · Pull Request #55278 · Expensify/App

burczu · 2025-01-15T15:02:38Z

Explanation of Change

In this PR we are fixing the issue with the "It's not here" 404 page is shown for a short period of time after successfully deactivating a virtual card and before redirecting back. Additionally, we are improving the UX of the deactivation flow by adding the confirmation modal after the successful deactivation

Fixed Issues

$ #53996
PROPOSAL: #53996 (comment)

Tests

Login to the App with the account that has some virtual cards
Go to Settings -> Wallet and open details of the card
Tap on "Report virtual card fraud" and go through the process of card deactivation
Check if there is no "It's not there" 404 page showing up
Check if the confirmation modal appears at the end of the process

Verify that no errors appear in the JS console

Offline tests

Same as above.

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-23.at.09.17.54.mov

Android: mWeb Chrome

Screen.Recording.2025-01-23.at.09.24.34.mov

iOS: Native

Screen.Recording.2025-01-23.at.09.16.10.mov

iOS: mWeb Safari

Screen.Recording.2025-01-23.at.09.20.50.mov

MacOS: Chrome / Safari

Screen.Recording.2025-01-23.at.09.52.43.mov

MacOS: Desktop

Screen.Recording.2025-01-23.at.09.56.18.mov

melvin-bot · 2025-01-23T08:42:25Z

@shawnborton @alitoshmatov One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2025-01-23T08:44:25Z

Looking good, love the fraud dude!

Is there a way to prevent the transition from $0.00 to the updated card details? Like maybe we just show a loading spinner in that area until the new data populates?

burczu · 2025-01-28T10:19:35Z

@alitoshmatov Fixed!

alitoshmatov · 2025-01-28T11:02:32Z

Changes looks good, I hit rate limit while testing. Will get try again shortly

alitoshmatov · 2025-01-28T12:55:05Z

@burczu I come across this issue where user might end up in navigation loop where it cannot go out of card info. Clicking on back button sends user to confirmation page

Also I am not able to reproduce it consistently. Was able to reproduce 2 times, maybe I did something wrong

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-28.at.17.52.42.mp4

burczu · 2025-01-28T13:12:49Z

@alitoshmatov Hmmm... strange. I'll check it, thanks!

burczu · 2025-01-28T13:28:59Z

@alitoshmatov Ok, I was able to reproduce it - it happens only if you refresh the page being on the confirmation page. I'll work on the fix.

burczu · 2025-01-29T08:16:30Z

@alitoshmatov Fixed.

alitoshmatov · 2025-01-29T09:44:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/a136963f-0258-4f63-9cbb-aa9f494ca600

Android: mWeb Chrome

iOS: Native

fraud3-ios.mp4

iOS: mWeb Safari

fraud3-safari.mp4

MacOS: Chrome / Safari

fraud3-web.mov

MacOS: Desktop

fraud3-desktop.mov

alitoshmatov

LGTM!

mountiny

Thanks for patient work on this one, looks good to me!

github-actions · 2025-01-29T12:29:05Z

🚧 @mountiny has triggered a test build. You can view the workflow run here.

OSBotify · 2025-01-29T12:38:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-29T13:00:37Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/55278/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/55278/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/55278/NewExpensify.dmg	https://55278.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

github-actions · 2025-01-30T01:58:56Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.92-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-31T06:48:45Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.92-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

alitoshmatov · 2025-02-13T10:20:26Z

src/pages/settings/Wallet/ReportVirtualCardFraudConfirmationPage.tsx

+    const {translate} = useLocalize();
+
+    const close = useCallback(() => {
+        Navigation.navigate(ROUTES.SETTINGS_WALLET_DOMAINCARD.getRoute(cardID));


Commenting for reference: This changes caused regression #56026

alitoshmatov · 2025-02-13T10:25:29Z

Commenting for reference. Not adding adding confirmation page to RHP mapping caused this regression #56023

jayeshmangwani · 2025-03-24T06:40:20Z

src/pages/settings/Wallet/ExpensifyCardPage.tsx

            <HeaderWithBackButton
                title={pageTitle}
-                onBackButtonPress={() => Navigation.goBack()}
+                onBackButtonPress={() => Navigation.navigate(ROUTES.SETTINGS_WALLET)}


Coming from this issue #58260, adding navigation here caused the app to get stuck in loop when accessing the assigned card from the Wallet page. Instead, we should have used goBack to navigate to SETTINGS_WALLET

burczu added 4 commits January 14, 2025 13:50

basic fraud report confirmation modal added

5029dd3

navigation back + preventing showing 404 page

5ac68f4

Merge branch 'main' into fix/53996-wallet-its-not-here-error

f8a76ad

modal content and styles added

01c94a4

burczu mentioned this pull request Jan 15, 2025

[HOLD for payment 2025-02-07] [$250] Wallet - "It's not here" error is briefly shown when deactivating a virtual card #53996

Closed

7 tasks

burczu added 11 commits January 15, 2025 16:34

unnecessary condition removed

f6c1c27

linter errors fixed

3d65b28

another linter error fixed

3148d2d

Merge branch 'main' into fix/53996-wallet-its-not-here-error

6d8ae98

cherry pick from other PR

97951e0

adjustments after cherry pick

6f3bb57

unnecessary commented line removed

533fd17

storing previous virtual card fixed

f2856c7

translations introduced

8d32b27

jamiegpt translations added

f7f1630

modal title translated

4f285fc

mountiny assigned burczu Jan 21, 2025

burczu added 5 commits January 21, 2025 13:47

Merge branch 'main' into fix/53996-wallet-its-not-here-error

b7bbab5

Merge branch 'main' into fix/53996-wallet-its-not-here-error

d469ca4

Merge branch 'main' into fix/53996-wallet-its-not-here-error

7ac64e0

navigate as an side effect to fix behaviour on mobile

bcee6ae

Merge branch 'main' into fix/53996-wallet-its-not-here-error

abb7f9c

burczu marked this pull request as ready for review January 23, 2025 08:42

burczu requested review from a team as code owners January 23, 2025 08:42

melvin-bot bot requested review from alitoshmatov and shawnborton January 23, 2025 08:42

melvin-bot bot removed the request for review from a team January 23, 2025 08:42

burczu added 2 commits January 28, 2025 10:51

switched from confirmation modal to standalone page

e8bbcaa

eslint fix

6fc26fc

redirecting to fixed page from card details page fixing redirect loop

2cecae4

alitoshmatov approved these changes Jan 29, 2025

View reviewed changes

mountiny changed the title ~~Fix/53996 wallet its not here error~~ Add report fraud confirmation page when getting new virtual card Jan 29, 2025

mountiny approved these changes Jan 29, 2025

View reviewed changes

mountiny merged commit 79e0ecf into Expensify:main Jan 29, 2025
16 checks passed

github-actions bot mentioned this pull request Jan 30, 2025

Deploy Checklist: New Expensify 2025-01-30 #56018

Closed

48 tasks

This was referenced Jan 30, 2025

[CP Staging] Staying on Settings -> Wallet after Confirmation page refresh #56065

Merged

Proper back navigation handling in card deactivation success page #56070

Merged

alitoshmatov reviewed Feb 13, 2025

View reviewed changes

gijoe0295 mentioned this pull request Feb 26, 2025

[HOLD for #57404][Back nav] Expensify Card - The back button navigates to wallet page #57461

Closed

8 tasks

jayeshmangwani reviewed Mar 24, 2025

View reviewed changes

jayeshmangwani mentioned this pull request Mar 24, 2025

[Due for payment 2025-03-28] [$250][Back Nav] Navigation Back Stuck After Viewing Assigned Card #58260

Closed

8 tasks

Conversation

burczu commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 23, 2025

Uh oh!

shawnborton commented Jan 23, 2025

Uh oh!

burczu commented Jan 28, 2025

Uh oh!

alitoshmatov commented Jan 28, 2025

Uh oh!

alitoshmatov commented Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

burczu commented Jan 28, 2025

Uh oh!

burczu commented Jan 28, 2025

Uh oh!

burczu commented Jan 29, 2025

Uh oh!

alitoshmatov commented Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

alitoshmatov left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jan 29, 2025

Uh oh!

OSBotify commented Jan 29, 2025

Uh oh!

github-actions bot commented Jan 29, 2025

Uh oh!

github-actions bot commented Jan 30, 2025

Uh oh!

github-actions bot commented Jan 31, 2025

Uh oh!

alitoshmatov Feb 13, 2025

Choose a reason for hiding this comment

Uh oh!

alitoshmatov commented Feb 13, 2025

Uh oh!

jayeshmangwani Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

burczu commented Jan 15, 2025 •

edited

Loading

alitoshmatov commented Jan 28, 2025 •

edited

Loading

alitoshmatov commented Jan 29, 2025 •

edited

Loading