Skip to content

Revert "[HybridApp] Necessary copilot changes"#55363

Merged
Julesssss merged 1 commit intomainfrom
revert-54296-war-in/enable-hybrid-app-copilot
Jan 16, 2025
Merged

Revert "[HybridApp] Necessary copilot changes"#55363
Julesssss merged 1 commit intomainfrom
revert-54296-war-in/enable-hybrid-app-copilot

Conversation

@chiragsalian
Copy link
Contributor

@chiragsalian chiragsalian commented Jan 16, 2025

Reverts #54296

Context - #54296 (comment)

@chiragsalian chiragsalian self-assigned this Jan 16, 2025
@chiragsalian chiragsalian marked this pull request as ready for review January 16, 2025 19:09
@chiragsalian chiragsalian requested a review from a team as a code owner January 16, 2025 19:09
@melvin-bot melvin-bot bot requested review from amyevans and removed request for a team January 16, 2025 19:09
@melvin-bot
Copy link

melvin-bot bot commented Jan 16, 2025

@amyevans Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link
Contributor

@amyevans amyevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we reverting? Could you add just a wee bit of context or links in the OP before merging @chiragsalian?

@Julesssss
Copy link
Contributor

Ignoring checklist checks, this is a simple revert

@Julesssss Julesssss merged commit 5d25d69 into main Jan 16, 2025
@Julesssss Julesssss deleted the revert-54296-war-in/enable-hybrid-app-copilot branch January 16, 2025 19:18
@melvin-bot melvin-bot bot added the Emergency label Jan 16, 2025
@melvin-bot
Copy link

melvin-bot bot commented Jan 16, 2025

@Julesssss looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@Julesssss
Copy link
Contributor

@Julesssss looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

#55363 (comment)

@chiragsalian
Copy link
Contributor Author

@amyevans, yup i created this PR quick before I dipped into some meetings so that workflows succeed. I added the explanation here. I'll add it to the PR description here too.

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Contributor

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.0.87-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@github-actions
Copy link
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.87-3 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants