[CP Staging] fix: Unable to close currency list using device back button. by Krishna2323 · Pull Request #55575 · Expensify/App

Krishna2323 · 2025-01-21T21:15:49Z

Explanation of Change

This PR fixes regressions from #53845

REGRESSIONS: #55547 #55551 #55549 #55552 #55553 #55601

Fixed Issues

$ #53845
$ #55551
$ #55549
$ #55552
$ #55553
$ #55601
PROPOSAL: NA

Tests

Go to Account settings > Workspaces
Tap New workspace
Tap Currency
Exit the currency list using device back gesture
Verify currency list is closed

--

Go to Account settings > Workspaces.
Tap New workspace.
Tap on the workspace name field to bring up the keyboard.
Tap on the avatar > Verify avatar upload options appears
Tap on the workspace name field to bring up the keyboard.
Tap Confirm button > Verify workspace is created

--

Go to Account settings > Workspaces.
Click New workspace.
Click Currency.
Press CMD+D > Verify currency list is closed and modal opens correctly.
Click Currency.
Press CMD+K. > Verify currency list is closed and modal opens correctly.

Verify that no errors appear in the JS console

Offline tests

Go to Account settings > Workspaces
Tap New workspace
Tap Currency
Exit the currency list using device back gesture
Verify currency list is closed

--

Go to Account settings > Workspaces.
Tap New workspace.
Tap on the workspace name field to bring up the keyboard.
Tap on the avatar > Verify avatar upload options appears
Tap on the workspace name field to bring up the keyboard.
Tap Confirm button > Verify workspace is created

--

Go to Account settings > Workspaces.
Click New workspace.
Click Currency.
Press CMD+D > Verify currency list is closed and modal opens correctly.
Click Currency.
Press CMD+K. > Verify currency list is closed and modal opens correctly.

QA Steps

Go to Account settings > Workspaces
Tap New workspace
Tap Currency
Exit the currency list using device back gesture
Verify currency list is closed

--

Go to Account settings > Workspaces.
Tap New workspace.
Tap on the workspace name field to bring up the keyboard.
Tap on the avatar > Verify avatar upload options appears
Tap on the workspace name field to bring up the keyboard.
Tap Confirm button > Verify workspace is created

--

Go to Account settings > Workspaces.
Click New workspace.
Click Currency.
Press CMD+D > Verify currency list is closed and modal opens correctly.
Click Currency.
Press CMD+K. > Verify currency list is closed and modal opens correctly.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot · 2025-01-21T21:15:54Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Krishna2323 · 2025-01-21T21:19:45Z

@allgandalf could you please check #55547 (comment) & #55553 (comment)?

Do you know why android native app is not working even after successful build?

marcochavezf · 2025-01-21T23:34:13Z

Assigning @ishpaul777 for expedited C+ review per https://expensify.slack.com/archives/C02NK2DQWUX/p1737501890114999

ishpaul777 · 2025-01-21T23:39:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-22.at.5.51.27.AM.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2025-01-22.at.6.00.15.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-01-22.at.6.02.48.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-01-22.at.5.54.26.AM.mov

MacOS: Desktop

Screen.Recording.2025-01-22.at.6.35.10.PM.mov

Krishna2323 · 2025-01-21T23:41:21Z

@ishpaul777, are you able to reproduce #55553? And what do you think about #55547 (comment).

github-actions · 2025-01-21T23:50:13Z

🚧 @marcochavezf has triggered a test build. You can view the workflow run here.

ishpaul777 · 2025-01-21T23:59:54Z

i can reproduce this #55553, if you compare with other currency selector the padding is extra

Screen.Recording.2025-01-22.at.5.28.18.AM.mov

ishpaul777 · 2025-01-22T00:05:24Z

I think this is same as #53692, can this be handled there?

#55547 (comment) i think yeah the linked issue seems to have same problem fix should be similar, can be handled there

github-actions · 2025-01-22T00:15:43Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/55575/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/55575/NewExpensify.dmg	https://55575.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

ishpaul777 · 2025-01-22T00:19:28Z

bug: notice when the currency selector open it changes the color of device navigation buttons to white

Screen.Recording.2025-01-22.at.5.47.16.AM.mov

ishpaul777 · 2025-01-22T00:41:35Z

Bug: tapping device back button redirects to workspace list page instead of workpace edit page

Screen.Recording.2025-01-22.at.6.09.35.AM.mov

ishpaul777 · 2025-01-22T00:44:37Z

found few bugs @Krishna2323 ^

Krishna2323 · 2025-01-22T05:28:20Z

if you compare with other currency selector the padding is extra

While other currency selectors have their own dedicated pages, the workspace confirmation page uses a modal for its currency selector. Consequently, it inherits the same padding as the initial workspace confirmation page. Same happens in the state selector modal in connect bank account flow.

Monosnap.screencast.2025-01-22.10-56-44.mp4

Krishna2323 · 2025-01-22T05:38:54Z

Bug: tapping device back button redirects to workspace list page instead of workpace edit page

Since we are using a modal for the currency picker, it closes the workspace confirmation page even when the user is on currency selector modal. This behavior is also observed in multiple other areas of the application.

Monosnap.screencast.2025-01-22.11-07-30.mp4

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Beamanator · 2025-01-22T07:57:12Z

How we goin' here? Looks like there's still a few bugs to be resolved?

Krishna2323 · 2025-01-22T08:36:34Z

bug: notice when the currency selector open it changes the color of device navigation buttons to white

@ishpaul777, I’m unable to reproduce this issue on iOS Native, and the Android app crashes as soon as it launches. I’ve been trying to get the Android app to work for the last 3 days but have been unsuccessful. I also tried this, but it didn’t work.

ios_native_back_buttons.mp4

android_native.mp4

ishpaul777 · 2025-01-22T09:14:05Z

@Krishna2323 i think the issue with android build fixed on main with #55513 can you try building again?

Krishna2323 · 2025-01-22T09:34:41Z

i think the issue with android build fixed on main with #55513 can you try building again?

Still fails to launch.

ishpaul777 · 2025-01-22T09:58:49Z

@Krishna2323 Can you check logs to see why and where its crashing?

allgandalf · 2025-01-22T10:00:42Z

Still fails to launch.

You also need to clear the gradle i think:

rm -rf android/build android/app/build android/.gradle android/app/.gradle android/.cxx android/app/.cxx

And

cd android && ./gradlew clean

And then build again

melvin-bot · 2025-01-22T13:06:45Z

🎯 @ishpaul777, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #55603.

Beamanator

LGTM!

fix: Unable to close currency list using device back button. (cherry picked from commit f38cb04) (CP triggered by Beamanator)

OSBotify · 2025-01-22T13:21:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-22T13:55:50Z

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.0.88-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-01-23T18:07:26Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.88-7 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

fix: Unable to close currency list using device back button.

034c4ca

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 requested a review from a team as a code owner January 21, 2025 21:15

melvin-bot bot requested a review from jayeshmangwani January 21, 2025 21:15

melvin-bot bot removed the request for review from a team January 21, 2025 21:15

Krishna2323 mentioned this pull request Jan 21, 2025

[HOLD for payment 2025-02-04] [HOLD for payment 2025-01-30] [$250] Android/iOS - Workspace - Currency list in new workspace page has extra bottom padding #55553

Closed

8 tasks

marcochavezf requested review from ishpaul777 and removed request for jayeshmangwani January 21, 2025 23:31

This comment was marked as resolved.

Sign in to view

marcochavezf added the Ready To Build label Jan 21, 2025

fix input focus.

26a0914

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

allgandalf mentioned this pull request Jan 22, 2025

[Due for payment 2025-02-05] [$250] Workspace - mWeb - Currency selector scrolls to the top when I scroll down quickly #55601

Closed

8 tasks

Merge branch 'Expensify:main' into krishna2323/issue/55551

f2d8340

ishpaul777 approved these changes Jan 22, 2025

View reviewed changes

melvin-bot bot mentioned this pull request Jan 22, 2025

[$250] Payment issue for E/App PR#55575 #55603

Closed

ishpaul777 approved these changes Jan 22, 2025

View reviewed changes

Beamanator approved these changes Jan 22, 2025

View reviewed changes

Beamanator merged commit f38cb04 into Expensify:main Jan 22, 2025
18 checks passed

Beamanator changed the title ~~fix: Unable to close currency list using device back button.~~ [CP Staging] fix: Unable to close currency list using device back button. Jan 22, 2025

OSBotify pushed a commit that referenced this pull request Jan 22, 2025

Merge pull request #55575 from Krishna2323/krishna2323/issue/55551

9231ceb

fix: Unable to close currency list using device back button. (cherry picked from commit f38cb04) (CP triggered by Beamanator)

github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Jan 22, 2025

github-actions bot mentioned this pull request Jan 22, 2025

Deploy Checklist: New Expensify 2025-01-21 #55507

Closed

53 tasks

danieldoglas mentioned this pull request Jan 22, 2025

[HOLD for payment 2025-02-04] [HOLD for payment 2025-01-30] Android & iOS - Create workspace - Unable to tap Confirm button and avatar when keyboard is up #55549

Closed

8 tasks

Conversation

Krishna2323 commented Jan 21, 2025 • edited by Beamanator Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 21, 2025

Uh oh!

Krishna2323 commented Jan 21, 2025

Uh oh!

marcochavezf commented Jan 21, 2025

Uh oh!

This comment was marked as resolved.

ishpaul777 commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Krishna2323 commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 21, 2025

Uh oh!

ishpaul777 commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ishpaul777 commented Jan 22, 2025

Uh oh!

github-actions bot commented Jan 22, 2025

Uh oh!

ishpaul777 commented Jan 22, 2025

Uh oh!

ishpaul777 commented Jan 22, 2025

Uh oh!

ishpaul777 commented Jan 22, 2025

Uh oh!

Krishna2323 commented Jan 22, 2025

Uh oh!

Krishna2323 commented Jan 22, 2025

Uh oh!

Beamanator commented Jan 22, 2025

Uh oh!

Krishna2323 commented Jan 22, 2025

Uh oh!

ishpaul777 commented Jan 22, 2025

Uh oh!

Krishna2323 commented Jan 22, 2025

Uh oh!

ishpaul777 commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

allgandalf commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot bot commented Jan 22, 2025

Uh oh!

Beamanator left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jan 22, 2025

Uh oh!

github-actions bot commented Jan 22, 2025

Uh oh!

github-actions bot commented Jan 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Krishna2323 commented Jan 21, 2025 •

edited by Beamanator

Loading

ishpaul777 commented Jan 21, 2025 •

edited

Loading

Krishna2323 commented Jan 21, 2025 •

edited

Loading

ishpaul777 commented Jan 21, 2025 •

edited

Loading

ishpaul777 commented Jan 22, 2025 •

edited

Loading

allgandalf commented Jan 22, 2025 •

edited

Loading