Skip to content

Removing one value from Search filter clears the search #55636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luacmartins merged 6 commits into from
Jan 23, 2025
Merged

Removing one value from Search filter clears the search #55636

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cc44229
Removing one value from Search filter clears the search
ishakakkad Jan 22, 2025
488c11d
Fix issue when selecting autocomplete suggestion.
ishakakkad Jan 23, 2025
885ee94
Fix useCallback missing dependancy
ishakakkad Jan 23, 2025
45e4888
Fix eslint issues
ishakakkad Jan 23, 2025
2820b29
Fix review comments
ishakakkad Jan 23, 2025
82c5532
Fix prettier issues
ishakakkad Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/components/Search/SearchPageHeaderInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ function SearchPageHeaderInput({queryJSON, children}: SearchPageHeaderInputProps
const updatedSubstitutionsMap = getUpdatedSubstitutionsMap(userQuery, autocompleteSubstitutions);
setAutocompleteSubstitutions(updatedSubstitutionsMap);

if (updatedUserQuery || textInputValue.length > 0) {
if (updatedUserQuery) {
listRef.current?.updateAndScrollToFocusedIndex(0);
} else {
listRef.current?.updateAndScrollToFocusedIndex(-1);
Expand All @@ -148,9 +148,12 @@ function SearchPageHeaderInput({queryJSON, children}: SearchPageHeaderInputProps
setTextInputValue('');
setAutocompleteQueryValue('');
setIsAutocompleteListVisible(false);
} else {
setTextInputValue(queryText);
setAutocompleteQueryValue(queryText);
}
},
[autocompleteSubstitutions, originalInputQuery, queryJSON.policyID],
[autocompleteSubstitutions, originalInputQuery, queryJSON.policyID, queryText],
);

const onListItemPress = useCallback(
Expand Down Expand Up @@ -260,6 +263,10 @@ function SearchPageHeaderInput({queryJSON, children}: SearchPageHeaderInputProps
onSearchQueryChange={onSearchQueryChange}
isFullWidth
onSubmit={() => {
const focusedOption = listRef.current?.getFocusedOption();
if (focusedOption) {
return;
}
submitSearch(textInputValue);
}}
autoFocus={false}
Expand Down