Improve eReceipt visually in New Dot by mkzie2 · Pull Request #55803 · Expensify/App

mkzie2 · 2025-01-27T17:37:14Z

Explanation of Change

Improve eReceipt visually in New Dot

Fixed Issues

Tests

Create card transaction
If we don't have card transactions, go to the transaction detail and add this command to the console (replace the ID after _ with the transactionID that we're viewing)

Onyx.merge(`transactions_8073227627479073933`, {
    amount: 1000,
    currency: 'USD',
    cardID: 4,
    merchant: 'United Airlines',
    mccGroup: 'Airlines',
    created: '2023-07-24 13:46:20',
    hasEReceipt: true,
});

or add this useEffect to MoneyRequestView

useEffect(() => {
    Onyx.merge(`transactions_${linkedTransactionID}`, {
        amount: 1000,
        currency: 'USD',
        cardID: 4,
        merchant: 'United Airlines',
        mccGroup: 'Goods',
        created: '2023-07-24 13:46:20',
        hasEReceipt: true,
    });
    
});

Notice the EReceipt preview and EReceipt detail
Verify that the UI is correct with the description here

Verify that no errors appear in the JS console

Offline tests

Same

QA Steps

Create card transaction
If we don't have card transactions, go to the transaction detail and add this command to the console

Onyx.merge(`transactions_8073227627479073933`, {
    amount: 1000,
    currency: 'USD',
    cardID: 4,
    merchant: 'United Airlines',
    mccGroup: 'Airlines',
    created: '2023-07-24 13:46:20',
    hasEReceipt: true,
});

or add this useEffect to MoneyRequestView

useEffect(() => {
    Onyx.merge(`transactions_${linkedTransactionID}`, {
        amount: 1000,
        currency: 'USD',
        cardID: 4,
        merchant: 'United Airlines',
        mccGroup: 'Goods',
        created: '2023-07-24 13:46:20',
        hasEReceipt: true,
    });
    
});

Notice the EReceipt preview and EReceipt detail
Verify that the UI is correct with the description here

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-02-03.at.16.17.38.mov

Android: mWeb Chrome

Screen.Recording.2025-02-03.at.15.08.30.mov

iOS: Native

Screen.Recording.2025-02-03.at.16.23.20.mov

iOS: mWeb Safari

Screen.Recording.2025-02-03.at.15.10.11.mov

MacOS: Chrome / Safari

Screen.Recording.2025-02-03.at.15.04.40.mov

MacOS: Desktop

Screen.Recording.2025-02-03.at.16.26.39.mov

melvin-bot · 2025-02-03T09:47:56Z

@shawnborton @ishpaul777 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2025-02-03T20:15:04Z

It seems like the spacing is quite off from our mockups. Here is what I see in your videos:

Yet here is our Figma file:

Can you update and then we can review again from there?

ishpaul777 · 2025-02-03T20:38:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-19.at.5.51.20.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-03-18.at.2.43.34.AM.mov

iOS: Native

Screen.Recording.2025-03-18.at.1.13.54.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-03-18.at.1.31.14.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-18.at.1.26.57.AM.mov

MacOS: Desktop

Screen.Recording.2025-03-18.at.2.55.38.AM.mov

ishpaul777 · 2025-02-03T21:06:54Z

@mkzie2 can you please provide steps to add a card transaction (maybe we need to mock it? if yes please provide code to execute to have the mocked transaction) Thank you!

dannymcclain · 2025-02-03T22:03:27Z

Aside from @shawnborton's comments, why does the receipt change colors between the preview and full receipt? I would assume it would stay the same between those views.

mkzie2 · 2025-02-04T05:05:40Z

Aside from @shawnborton's comments, why does the receipt change colors between the preview and full receipt? I would assume it would stay the same between those views.

No problem, this is because I hard-coded it to display the receipt.

mkzie2 · 2025-02-04T05:50:27Z

@shawnborton, I updated it to match the Figma. Please help to check again.

mkzie2 · 2025-02-04T05:50:45Z

can you please provide steps to add a card transaction (maybe we need to mock it? if yes please provide code to execute to have the mocked transaction) Thank you!

@ishpaul777 Updated the test step.

ishpaul777 · 2025-02-04T12:08:49Z

e-reciept	distance receipt

dont we want make distance e-receipt to follow similar design @Expensify/design @mkzie2

shawnborton · 2025-02-04T19:04:09Z

I think we should leave the map receipts alone for now. We can follow up later and change them a bit to match these new eReceipts, but I say we tackle eReceipts first so that we don't have too much scope creep in this particular issue.

shawnborton · 2025-02-04T19:07:54Z

It looks like the spacing is still off a bit. For example the content below the amount is too far to the left, we don't have enough inner padding. Please refer to the Figma file, but see this image as well:

src/components/EReceipt.tsx

mkzie2 · 2025-03-18T09:07:26Z

it working really well, no big issues spotted. one NAB thing that text seems to be selectable in preview, I this it should not be selectable

@ishpaul777 Fixed now.

github-actions · 2025-03-18T09:08:45Z

🚧 @shawnborton has triggered a test app build. You can view the workflow run here.

github-actions · 2025-03-18T09:50:23Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/55803/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/55803/index.html

Android Hybrid 🤖🔄	iOS Hybrid 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/55803-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/55803-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/55803/NewExpensify.dmg	https://55803.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2025-03-18T16:21:40Z

cc @ishpaul777 for another review

shawnborton · 2025-03-18T16:23:07Z

And cc @Expensify/design in case you want to take this for a spin and look for bugs - it's feeling pretty good to me though! Thanks so much @mkzie2 for being patient with our feedback.

shawnborton · 2025-03-18T16:25:05Z

Actually @mkzie2 sorry, one small thing I noticed... it looks like the number portion of the eReceipt doesn't appear centered:

In Figma, we're adding a space over on the right side of the amount so that it appears more centered for the majority of currency cases. Could we do something like that in the product?

Basically it just adds like 16px of padding on the right side to balance out the currency symbol. Thanks!

mkzie2 · 2025-03-18T16:39:05Z

Basically it just adds like 16px of padding on the right side to balance out the currency symbol. Thanks!

@shawnborton I added this.

github-actions · 2025-03-18T16:40:15Z

🚧 @shawnborton has triggered a test app build. You can view the workflow run here.

github-actions · 2025-03-18T17:28:15Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/55803/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/55803/index.html

Android Hybrid 🤖🔄	iOS Hybrid 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/55803-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/55803-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/55803/NewExpensify.dmg	https://55803.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2025-03-18T18:03:03Z

Hmm I'm not seeing it?

mkzie2 · 2025-03-19T02:45:13Z

@shawnborton Can you try to reload?

shawnborton · 2025-03-19T07:34:47Z

I was trying in an incognito window and it still didn't work. Let me try again though...

shawnborton · 2025-03-19T07:36:23Z

Okay cool, I'm seeing it now, nice:

@ishpaul777 over to you for final review again, hopefully we can get this merged soon. Let's please do a super thorough test of this one, as I definitely want to avoid needing to revert :)

ishpaul777

LGTM! Great work!

grgia

Great work on this one everyone! It makes a big difference

OSBotify · 2025-03-19T12:53:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-20T15:36:30Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.1.16-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-03-21T22:20:32Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.16-4 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

mkzie2 added 8 commits January 14, 2025 23:34

add test branch

e076d99

resolve conflict

6f5000a

use only one background

0f3ff8f

Merge branch 'main' into mkzie2-issue/55083

cc254f6

fix ui in native

28ce4b8

update story

fb3b2fb

fix lint error

c29d6da

remove default value

7bb31bb

mkzie2 marked this pull request as ready for review February 3, 2025 09:47

mkzie2 requested review from a team as code owners February 3, 2025 09:47

melvin-bot bot requested review from ishpaul777 and shawnborton and removed request for a team February 3, 2025 09:47

mkzie2 mentioned this pull request Feb 3, 2025

[PAID] [$250] Improve eReceipt visually in New Dot #55083

Closed

Merge branch 'main' into mkzie2-issue/55083

f7903f2

mkzie2 added 2 commits February 4, 2025 12:32

update ereceipt style

b60b1fb

update background image style

6fec798

ishpaul777 reviewed Feb 5, 2025

View reviewed changes

src/components/EReceipt.tsx Outdated Show resolved Hide resolved

mkzie2 added 2 commits March 18, 2025 15:58

Merge branch 'main' into mkzie2-issue/55083

10a1b7c

make eReceipt preview to none select

42f9d50

mkzie2 added 2 commits March 18, 2025 23:30

Merge branch 'main' into mkzie2-issue/55083

9490ae3

add padding right for amount

fb723a4

ishpaul777 approved these changes Mar 19, 2025

View reviewed changes

melvin-bot bot requested a review from grgia March 19, 2025 12:31

grgia approved these changes Mar 19, 2025

View reviewed changes

grgia merged commit 9ad2340 into Expensify:main Mar 19, 2025
17 checks passed

github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label Mar 19, 2025

FitseTLT mentioned this pull request Mar 21, 2025

[Due for payment 2025-04-07] [$125] iOS - Expense - Add receipt modal on confirmation page is smaller and does not fit the screen #58898

Closed

8 tasks

mkzie2 mentioned this pull request Mar 26, 2025

fix: Add receipt modal on confirmation page is smaller and does not fit the screen #59046

Merged

50 tasks

Conversation

mkzie2 commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 3, 2025

Uh oh!

shawnborton commented Feb 3, 2025

Uh oh!

ishpaul777 commented Feb 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ishpaul777 commented Feb 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dannymcclain commented Feb 3, 2025

Uh oh!

mkzie2 commented Feb 4, 2025

Uh oh!

mkzie2 commented Feb 4, 2025

Uh oh!

mkzie2 commented Feb 4, 2025

Uh oh!

ishpaul777 commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawnborton commented Feb 4, 2025

Uh oh!

shawnborton commented Feb 4, 2025

Uh oh!

Uh oh!

mkzie2 commented Mar 18, 2025

Uh oh!

github-actions bot commented Mar 18, 2025

Uh oh!

github-actions bot commented Mar 18, 2025

Uh oh!

shawnborton commented Mar 18, 2025

Uh oh!

shawnborton commented Mar 18, 2025

Uh oh!

shawnborton commented Mar 18, 2025

Uh oh!

mkzie2 commented Mar 18, 2025

Uh oh!

github-actions bot commented Mar 18, 2025

Uh oh!

github-actions bot commented Mar 18, 2025

Uh oh!

shawnborton commented Mar 18, 2025

Uh oh!

mkzie2 commented Mar 19, 2025

Uh oh!

shawnborton commented Mar 19, 2025

Uh oh!

shawnborton commented Mar 19, 2025

Uh oh!

ishpaul777 left a comment

Choose a reason for hiding this comment

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 19, 2025

Uh oh!

github-actions bot commented Mar 20, 2025

Uh oh!

github-actions bot commented Mar 21, 2025

Uh oh!

Reviewers

Assignees

mkzie2 commented Jan 27, 2025 •

edited

Loading

ishpaul777 commented Feb 3, 2025 •

edited

Loading

ishpaul777 commented Feb 3, 2025 •

edited

Loading

ishpaul777 commented Feb 4, 2025 •

edited

Loading