feat: RN 77 upgrade by WoLewicki · Pull Request #55861 · Expensify/App

WoLewicki · 2025-01-28T14:08:28Z

Explanation of Change

PR bumping RN to 0.77 and updating dependencies connected with it.

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13394

Fixed Issues

$ #54903
PROPOSAL:

Patches

deleted patches
patches/@react-native+assets-registry+0.76.3.patch
patches/expo+52.0.14+002+rn-75-fixes.patch
patches/expo+52.0.14+003+fix-form-data-entries-override.patch
patches/expo-modules-core+2.1.1+004+fix-type-exports.patch
patches/lottie-react-native+6.5.1+002+bridgeless.patch
patches/react-native+0.76.3+017+Android-onHostResume-resume-frame-callback.patch
patches/react-native+0.76.3+019+keyboard-avoiding-view.patch
patches/react-native+0.76.3+021+fix-selection-not-working.patch
patches/react-native+0.76.3+023+modal-navigation-bar-translucent.patch
patches/react-native+0.76.3+024+hybrid-app.patch
patches/react-native+0.76.3+027+measureText-full-width-if-wraps.patch
patches/react-native+0.76.3+028+fix-scroll-the-cursor-into-view-when-focus.patch
added patches
patches/expo+52.0.28+001+dont-change-formdata.patch - upstream PR

patches/jest-expo+52.0.3.patch - upstream PR
patches/react-native-reanimated+3.16.7+004+targets-for-markdown.patch - not available for upstream due to changes in Reanimated core, should be removed when we bump live-markdown version since it was fixed there in Fix linking error error: undefined symbol: worklets::extractWorkletRuntime on Android react-native-live-markdown#627
patches/react-native-screens+3.35.0+004+cover-all-cases.patch - fixed in 4.x so it will removed when we bump to those versions, hopefully soon

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-01-28T14:08:34Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-01-28T14:17:50Z

🚧 @mountiny has triggered a test build. You can view the workflow run here.

github-actions · 2025-01-28T16:29:03Z

🚧 @mountiny has triggered a test build. You can view the workflow run here.

github-actions · 2025-01-28T16:57:58Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/55861/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Desktop build failed	The QR code can't be generated, because the Web build failed

👀 View the workflow run that generated this build 👀

shubham1206agra · 2025-01-28T19:12:40Z

@WoLewicki This might help you here react-native-modal/react-native-modal#781

github-actions · 2025-01-28T21:34:39Z

🚧 @mountiny has triggered a test build. You can view the workflow run here.

github-actions · 2025-01-28T22:00:46Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/55861/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Desktop build failed	The QR code can't be generated, because the Web build failed

👀 View the workflow run that generated this build 👀

github-actions · 2025-01-29T14:25:56Z

🚧 @mountiny has triggered a test hybrid app build. You can view the workflow run here.

github-actions · 2025-01-29T14:58:37Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/55861/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/55861/index.html

Desktop 💻	Web 🕸️
N/A	N/A
N/A	N/A

👀 View the workflow run that generated this build 👀

mountiny · 2025-01-29T15:23:02Z

Asked QA to test the hybrid

shubham1206agra · 2025-03-18T17:21:33Z

@war-in The map is not panning correctly when entering the waypoints initially.

# Conflicts: # ios/NewExpensifyTests/Info.plist

github-actions · 2025-03-18T20:51:02Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

war-in · 2025-03-19T10:01:13Z

Wrong color of header in ND Standalone build.

@shubham1206agra I verified on the main and the color of the header is white too - unrelated
I'd appreciate it if the issues were verified with the staging before being reported 🙏

The map is not panning correctly when entering the waypoints initially.

Could you post some reproduction steps and include the expected result? It'll be much easier for me to check

shubham1206agra · 2025-03-19T10:03:34Z

Could you post some reproduction steps and include the expected result? It'll be much easier for me to check

Enter 2 waypoints and expected result is that both waypoints should be visible in the map with correct zoom level.

# Conflicts: # ios/NewExpensifyTests/Info.plist

war-in · 2025-03-19T12:37:59Z

Enter 2 waypoints and expected result is that both waypoints should be visible in the map with correct zoom level.

@shubham1206agra verified and not reproducible

Screen.Recording.Mar.19.2025.from.Marcin.Warchol.mp4

github-actions · 2025-03-19T12:38:30Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

shubham1206agra · 2025-03-19T13:10:42Z

@war-in Can you fix conflicts so we can merge this PR?

# Conflicts: # ios/NewExpensifyTests/Info.plist

github-actions · 2025-03-19T13:20:40Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

war-in · 2025-03-19T13:20:41Z

@shubham1206agra done!

shubham1206agra · 2025-03-19T13:30:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

# Conflicts: # ios/NewExpensifyTests/Info.plist # package-lock.json # package.json

github-actions · 2025-03-20T08:03:57Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

OSBotify · 2025-03-20T14:41:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

mvtglobally · 2025-03-20T15:10:58Z

@mountiny Anything to QA here?

mountiny · 2025-03-20T15:30:20Z

@mvtglobally this will be general regression testing, if you find any deploy blockers, might be related to this

github-actions · 2025-03-20T15:36:33Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.16-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

mvtglobally · 2025-03-21T14:25:11Z

@mountiny Can we check it off the checklist then once regression is done?

mountiny · 2025-03-21T14:33:26Z

Yes please

github-actions · 2025-03-21T22:20:35Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.16-4 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

eh2077 · 2025-09-29T11:02:05Z

There seems no upstream issue for the patches/lottie-react-native+6.5.1+002+bridgeless.patch and patches/lottie-react-native+6.5.1+003+support-RN-77.patch patches.

war-in · 2025-10-01T08:05:02Z

@eh2077 I'll add details.md file for lottie patches in the upcoming React Native bump - #69535

WoLewicki added 5 commits January 20, 2025 17:14

feat: android working and ios release working

2b8db83

chore: bump to stable rn77

225d1dd

chore: merge current main

93e9b3d

feat: bump expo and update patches

8c6871c

chore: merge current main

7eaa3b6

WoLewicki requested a review from a team as a code owner January 28, 2025 14:08

melvin-bot bot requested a review from getusha January 28, 2025 14:08

melvin-bot bot removed the request for review from a team January 28, 2025 14:08

WoLewicki changed the title ~~feat: android working and ios release working~~ feat: RN 77 upgrade Jan 28, 2025

mountiny added the Ready To Build label Jan 28, 2025

fix: bump metaspace

37654b1

This comment has been minimized.

Sign in to view

mountiny assigned WoLewicki Jan 28, 2025

WoLewicki added 3 commits January 29, 2025 11:02

feat: bump expo to fix ios dev

f45ba4d

chore: merge current main

3fa0603

chore: gh actions

f937635

fix: workaround typescript

d8368ca

WoLewicki requested a review from a team as a code owner January 29, 2025 14:37

fix: change to expect-error

de5d124

fix: add other lib needed by lottie

3b9ab01

Merge branch 'main' into @wolewicki/rn-77-upgrade

1da86bd

# Conflicts: # ios/NewExpensifyTests/Info.plist

Merge branch 'main' into @wolewicki/rn-77-upgrade

7bab11d

# Conflicts: # ios/NewExpensifyTests/Info.plist

Merge branch 'main' into @wolewicki/rn-77-upgrade

8bb2ede

# Conflicts: # ios/NewExpensifyTests/Info.plist

shubham1206agra approved these changes Mar 19, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny March 19, 2025 13:31

Merge branch 'main' into @wolewicki/rn-77-upgrade

a77c0dc

# Conflicts: # ios/NewExpensifyTests/Info.plist # package-lock.json # package.json

mountiny approved these changes Mar 20, 2025

View reviewed changes

mountiny merged commit 70fb7e3 into Expensify:main Mar 20, 2025
23 of 24 checks passed

github-actions bot mentioned this pull request Mar 20, 2025

Deploy Checklist: New Expensify 2025-03-20 #58801

Closed

72 tasks

brunovjk mentioned this pull request Mar 28, 2025

[HOLD React Native 0.76] [$250] iOS Workspace - Invite message field does not auto-focus #53346

Closed

8 tasks

Conversation

WoLewicki commented Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Patches

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 28, 2025

Uh oh!

github-actions bot commented Jan 28, 2025

Uh oh!

This comment has been minimized.

github-actions bot commented Jan 28, 2025

Uh oh!

github-actions bot commented Jan 28, 2025

Uh oh!

shubham1206agra commented Jan 28, 2025

Uh oh!

github-actions bot commented Jan 28, 2025

Uh oh!

github-actions bot commented Jan 28, 2025

Uh oh!

github-actions bot commented Jan 29, 2025

Uh oh!

github-actions bot commented Jan 29, 2025

Uh oh!

mountiny commented Jan 29, 2025

Uh oh!

shubham1206agra commented Mar 18, 2025

Uh oh!

github-actions bot commented Mar 18, 2025

Uh oh!

war-in commented Mar 19, 2025

Uh oh!

shubham1206agra commented Mar 19, 2025

Uh oh!

war-in commented Mar 19, 2025

Uh oh!

github-actions bot commented Mar 19, 2025

Uh oh!

shubham1206agra commented Mar 19, 2025

Uh oh!

github-actions bot commented Mar 19, 2025

Uh oh!

war-in commented Mar 19, 2025

Uh oh!

shubham1206agra commented Mar 19, 2025

Reviewer Checklist

Uh oh!

github-actions bot commented Mar 20, 2025

Uh oh!

Uh oh!

OSBotify commented Mar 20, 2025

Uh oh!

mvtglobally commented Mar 20, 2025

Uh oh!

mountiny commented Mar 20, 2025

Uh oh!

github-actions bot commented Mar 20, 2025

Uh oh!

mvtglobally commented Mar 21, 2025

Uh oh!

mountiny commented Mar 21, 2025

Uh oh!

github-actions bot commented Mar 21, 2025

Uh oh!

eh2077 commented Sep 29, 2025

Uh oh!

war-in commented Oct 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

WoLewicki commented Jan 28, 2025 •

edited

Loading