Travel - Enable trip room renaming by blazejkustra · Pull Request #55936 · Expensify/App

blazejkustra · 2025-01-29T10:13:03Z

Explanation of Change

@rlinoz added new command for renaming trip rooms on the backend. This is FE part of this so that users can rename trip rooms.

Fixed Issues

$ #54539
PROPOSAL: N/A

Tests

Precondition - book a travel from olddot within a workspace that doesn't support chats (you can check it in the console)

Policy.getCurrent().policy.isPolicyExpenseChatEnabled

Open the URL: https://staging.expensify.com/
Log in with an account
Click on Travel > Book or manage travel
Book a hotel can be any (On payment filter select: 'Pay at property')
After your booking is successful, go to https://staging.expensify.com/
Click on 'Reports'
Click the booked hotel report > Click on 'Submit' > Click on 'Send'
Open the chat of the booked hotel
Click on the room header
Verify that changing trip room name is working

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Check web and ios

Android: mWeb Chrome

Check web and ios

iOS: Native

ios.mp4

iOS: mWeb Safari

Check web and ios

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

Check web and ios

melvin-bot · 2025-01-29T15:50:17Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra · 2025-01-31T18:43:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-02-01.at.12.10.17.AM.mov

Android: mWeb Chrome

Screen.Recording.2025-01-31.at.11.53.27.PM.mov

iOS: Native

Screen.Recording.2025-02-01.at.12.05.05.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-01-31.at.11.48.05.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-01-31.at.11.39.34.PM.mov

MacOS: Desktop

Screen.Recording.2025-01-31.at.11.57.16.PM.mov

rlinoz

Tests well, just one minor comment

rlinoz · 2025-02-04T17:11:04Z

src/pages/TripChatNameEditPage.tsx

+    const validate = useCallback(
+        (values: FormOnyxValues<typeof ONYXKEYS.FORMS.NEW_CHAT_NAME_FORM>): Errors => {
+            const errors: Errors = {};
+            if (!isValidReportName(values[INPUT_IDS.NEW_CHAT_NAME] ?? '')) {


Can we also validate the case for empty room name? The group chat has a default name that is why we let it be empty, but trip rooms don't I think

Good one, changed 👌

rlinoz

Thanks!

OSBotify · 2025-02-04T18:59:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-06T22:01:49Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.0.95-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

izarutskaya · 2025-02-07T07:51:56Z

@blazejkustra QA encountered with issue #54567 on all platforms

https://platform.applause.com/services/links/v1/external/26befd1bec72fd37f617b95aaf77d20805921aa3dc530ecd97683169161e8baa

github-actions · 2025-02-11T02:13:08Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.95-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

ZhenjaHorbach · 2025-02-19T08:52:37Z

src/pages/NewChatConfirmPage.tsx

    const {translate} = useLocalize();
    const styles = useThemeStyles();
    const personalData = useCurrentUserPersonalDetails();
+    const [newGroupDraft] = useOnyx(ONYXKEYS.NEW_GROUP_CHAT_DRAFT);


Came from this issue
Looks like using useOnyx instead withOnyx called this issue

To fix this we updated a condition here to call readFileAsync after the onyx value is loaded completely

Pujan92 · 2025-06-16T16:36:23Z

src/pages/TripChatNameEditPage.tsx

+                updateChatName(reportID, values[INPUT_IDS.NEW_CHAT_NAME] ?? '', CONST.REPORT.CHAT_TYPE.TRIP_ROOM);
+            }
+
+            return Navigation.setNavigationActionToMicrotaskQueue(() => Navigation.goBack(ROUTES.REPORT_SETTINGS.getRoute(reportID)));


The backRoute param value is incorrect and caused issue #62972

blazejkustra added 11 commits January 8, 2025 16:24

Add trip room check to disable rename functionality

527be86

Reuse group name edit functionality

f374547

Merge branch 'main' into fix/rename-trip-room

f7fb55f

Bring back old changes

c31b02d

Revert shouldDisableRename changes

701567e

Add new command nad params

104c5f6

Update group chat name edit page navigation and translation

872911e

Add TripChatNameEditPage for editing trip chat names

99d1068

Refactor chat name update functions to use a single method

f918383

Refactor NewChatConfirmPage to use hooks and simplify imports

b8c450d

Fix lint

0c0d85c

sumo-slonik approved these changes Jan 29, 2025

View reviewed changes

blazejkustra marked this pull request as ready for review January 29, 2025 15:50

blazejkustra requested a review from a team as a code owner January 29, 2025 15:50

melvin-bot bot requested review from shubham1206agra and removed request for a team January 29, 2025 15:50

blazejkustra mentioned this pull request Jan 29, 2025

[Due for payment 2025-02-18] Trip - Room name field does not include left parenthesis of the trip room name #54539

Closed

8 tasks

blazejkustra changed the title ~~Add trip room check to disable rename functionality~~ Travel - Enable trip room renaming Jan 29, 2025

Merge branch 'main' into fix/rename-trip-room

ef69fc9

shubham1206agra approved these changes Jan 31, 2025

View reviewed changes

melvin-bot bot requested a review from stitesExpensify January 31, 2025 18:43

Merge branch 'main' into fix/rename-trip-room

16ba20d

rlinoz requested changes Feb 4, 2025

View reviewed changes

blazejkustra added 2 commits February 4, 2025 09:22

Merge branch 'main' into fix/rename-trip-room

47f7f1b

Add validation for empty chat name in TripChatNameEditPage

1f1d9c1

blazejkustra requested a review from rlinoz February 4, 2025 18:37

rlinoz approved these changes Feb 4, 2025

View reviewed changes

rlinoz merged commit 69557c8 into Expensify:main Feb 4, 2025
14 checks passed

github-actions bot mentioned this pull request Feb 6, 2025

Deploy Checklist: New Expensify 2025-02-06 #56482

Closed

nkdengineer mentioned this pull request Feb 10, 2025

Revert "Travel - Enable trip room renaming" #56596

Closed

ZhenjaHorbach reviewed Feb 19, 2025

View reviewed changes

mkzie2 mentioned this pull request May 29, 2025

[Due for payment 2025-06-16] [Due for payment 2025-06-13] [$250] Trip - After edited room name, tap "save" button return to setting instead of details #62972

Closed

8 tasks

Pujan92 reviewed Jun 16, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Travel - Enable trip room renaming#55936

Travel - Enable trip room renaming#55936
rlinoz merged 15 commits intoExpensify:mainfrom
software-mansion-labs:fix/rename-trip-room

blazejkustra commented Jan 29, 2025 •

edited

Loading

Uh oh!

melvin-bot bot commented Jan 29, 2025

Uh oh!

shubham1206agra commented Jan 31, 2025

Uh oh!

rlinoz left a comment

Uh oh!

rlinoz Feb 4, 2025

Uh oh!

blazejkustra Feb 4, 2025

Uh oh!

rlinoz left a comment

Uh oh!

Uh oh!

OSBotify commented Feb 4, 2025

Uh oh!

github-actions bot commented Feb 6, 2025

Uh oh!

izarutskaya commented Feb 7, 2025

Uh oh!

github-actions bot commented Feb 11, 2025

Uh oh!

ZhenjaHorbach Feb 19, 2025

Uh oh!

Pujan92 Jun 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

blazejkustra commented Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 29, 2025

Uh oh!

shubham1206agra commented Jan 31, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

rlinoz left a comment

Choose a reason for hiding this comment

Uh oh!

rlinoz Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

blazejkustra Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

rlinoz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Feb 4, 2025

Uh oh!

github-actions bot commented Feb 6, 2025

Uh oh!

izarutskaya commented Feb 7, 2025

Uh oh!

github-actions bot commented Feb 11, 2025

Uh oh!

ZhenjaHorbach Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

Pujan92 Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

blazejkustra commented Jan 29, 2025 •

edited

Loading