[No Q/A] Adding updated commercial feed HelpDot images#55987
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
@jjcoffee @VictoriaExpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@VictoriaExpensify no concierge review needed here as this is just adding images. |
|
@jjcoffee you can approve to go to internal reviewer |
|
A preview of your ExpensifyHelp changes have been deployed to https://4b1fbb25.helpdot.pages.dev ⚡️ |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@blimpich @michaelkwardrop One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
Hi 👋🏼 Due to an unfortunate mistake, this code has been deleted, and this PR needs to be re-created from scratch. There are some additional details in slack here. Feel free to tag me in slack if you have questions. Apologies for the inconvenience 🙇🏼 |
Explanation of Change
Adding updated images for commercial feeds help article
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/439387
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videosundefined