fix: Workflows - Street doesn't get automatically filled out for a specific address. by Krishna2323 · Pull Request #55996 · Expensify/App

Krishna2323 · 2025-01-29T19:54:51Z

Explanation of Change

Fixed Issues

$ #55295
PROPOSAL: #55295 (comment)

Tests

Go to Settings > Profile > Address
Type "1132" on street address
Click on "1132 Murphy Ridge Rd" from the options
Verify street address gets filled out automatically

Verify that no errors appear in the JS console

Offline tests

Go to Settings > Profile > Address
Type "1132" on street address
Click on "1132 Murphy Ridge Rd" from the options
Verify street address gets filled out automatically

QA Steps

Go to Settings > Profile > Address
Type "1132" on street address
Click on "1132 Murphy Ridge Rd" from the options
Verify street address gets filled out automatically

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…ecific address. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot · 2025-01-29T19:54:55Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot · 2025-01-30T07:52:15Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2025-01-30T17:15:53Z

Thanks for the PR. I'll have it reviewed by tomorrow.

mananjadhav · 2025-01-30T20:47:25Z

src/components/AddressSearch/index.tsx

+            country: countryFallbackLongName = '',
+            state: stateAutoCompleteFallback = '',
+            city: cityAutocompleteFallback = '',
+            street: streetAutocompleteFallback,


Any reason we shouldn't be setting the default value for the fallback here and the next line?

No reason for that, I just added default value.

mananjadhav · 2025-01-31T17:22:37Z

@Krishna2323 You might need to force push the latest main due to an issue.

Krishna2323 · 2025-01-31T17:41:35Z

@mananjadhav, do I still need to do that? After merging main I don't see any extra commits and all tests are passing.

mananjadhav · 2025-01-31T17:57:45Z

Yeah I verified, the problematic commit doesn't exist in this branch.

git log | grep 4310fd82c4a3c20e5b61148a41ff675c7bb1b2e6

mananjadhav · 2025-01-31T18:17:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web-street-name.mov

MacOS: Desktop

desktop-street-name.mov

github-actions · 2025-02-03T23:34:18Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.0.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-02-06T21:57:15Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.94-25 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2025-02-06T22:39:06Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.94-25 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

…23/issue/55295" This reverts commit f60c647, reversing changes made to 7ef3254.

mananjadhav · 2025-05-22T15:59:28Z

Adding a fallback caused showing duplicate street name. The original bug doesn't seem to be reproducible anymore. We fixed it here. #60795

fix: Workflows - Street doesn't get automatically filled out for a sp…

d42fb2c

…ecific address. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix jest test.

fbbe23b

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 marked this pull request as ready for review January 30, 2025 07:52

Krishna2323 requested a review from a team as a code owner January 30, 2025 07:52

melvin-bot bot requested review from mananjadhav and removed request for a team January 30, 2025 07:52

Merge branch 'Expensify:main' into krishna2323/issue/55295

ec88458

Krishna2323 mentioned this pull request Jan 30, 2025

[Due for payment 2025-05-22] [Due for payment 2025-02-13] [$250] Workflows - Street doesn't get automatically filled out for a specific address #55295

Closed

8 tasks

mananjadhav reviewed Jan 30, 2025

View reviewed changes

Add default value for street and street number

5c48cfc

Merge branch 'Expensify:main' into krishna2323/issue/55295

5b774a8

mananjadhav approved these changes Jan 31, 2025

View reviewed changes

melvin-bot bot requested a review from mjasikowski January 31, 2025 18:18

mjasikowski approved these changes Feb 3, 2025

View reviewed changes

mjasikowski merged commit f60c647 into Expensify:main Feb 3, 2025
15 checks passed

github-actions bot mentioned this pull request Feb 3, 2025

Deploy Checklist: New Expensify 2025-02-03 #56280

Closed

95 tasks

bernhardoj mentioned this pull request Apr 24, 2025

[Due for payment 2025-05-22] [$250] Profile- Setting address, select a suggested address, street name displays duplicate #60795

Closed

8 tasks

bernhardoj added a commit to bernhardoj/Expensify that referenced this pull request May 2, 2025

Revert "Merge pull request Expensify#55996 from Krishna2323/krishna23…

cd8bb7b

…23/issue/55295" This reverts commit f60c647, reversing changes made to 7ef3254.

Conversation

Krishna2323 commented Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 29, 2025

Uh oh!

melvin-bot bot commented Jan 30, 2025

Uh oh!

mananjadhav commented Jan 30, 2025

Uh oh!

mananjadhav Jan 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Jan 31, 2025

Choose a reason for hiding this comment

Uh oh!

mananjadhav commented Jan 31, 2025

Uh oh!

Krishna2323 commented Jan 31, 2025

Uh oh!

mananjadhav commented Jan 31, 2025

Uh oh!

mananjadhav commented Jan 31, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions bot commented Feb 3, 2025

Uh oh!

github-actions bot commented Feb 6, 2025

Uh oh!

github-actions bot commented Feb 6, 2025

Uh oh!

mananjadhav commented May 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Krishna2323 commented Jan 29, 2025 •

edited

Loading

mananjadhav Jan 30, 2025 •

edited

Loading