Fix Netsuite - App crashes when tapping on export settings after disconnecting with another device by hoangzinh · Pull Request #56021 · Expensify/App

hoangzinh · 2025-01-30T01:41:45Z

Explanation of Change

Fixed Issues

$ #55723
PROPOSAL: #55723 (comment)

Tests

Same as QA

Verify that no errors appear in the JS console

Offline tests

N/A this can't be test when network is offline

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Prerequisite

An account with a workspace connected to NetSuite

Sign in to the account on 2 devices
On 1st device, open Accounting > NetSuite > Export (Stay on this page)
On 2nd device, navigate to Accounting > NetSuite > Three dot option > Disconnect
Verify that "Not here" page is displayed and the app doesn't crash

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-30.at.18.52.07.android.mov

Android: mWeb Chrome

Screen.Recording.2025-01-30.at.18.53.33.android.chrome.mov

iOS: Native

Screen.Recording.2025-01-30.at.17.28.02.ios.mov

iOS: mWeb Safari

Screen.Recording.2025-01-30.at.17.30.54.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2025-01-30.at.08.49.43.web.-.test1.mov

MacOS: Desktop

Screen.Recording.2025-01-30.at.08.54.01.desktop.mov

…suite

…-on-another-device

melvin-bot · 2025-01-30T12:10:07Z

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ahmedGaber93 · 2025-01-31T13:18:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

a.mp4

Android: mWeb Chrome

aw.mp4

iOS: Native

I failed to build the iOS on my environment, but this fix not limited to iOS, so the above videos is enough

iOS: mWeb Safari

iw.mp4

MacOS: Chrome / Safari

w.mp4

MacOS: Desktop

d.mp4

ahmedGaber93 · 2025-01-31T20:07:45Z

@hoangzinh I think we need to fix those places also, because they can crash with the same root cause (policy?.connections?.netsuite is null)

hoangzinh · 2025-02-01T00:55:04Z

Because it's a util, so I guess it will be caught somewhere before 👀

ahmedGaber93 · 2025-02-01T20:59:59Z

@hoangzinh That is mostly correct, but I think it not 100% because it depends on where we use it in.
I think make every function Independent and don't be affected by the place where it is used in looks more safe and clean. So I propose fixing them.

…-on-another-device

…suite

hoangzinh · 2025-02-03T08:57:01Z

@hoangzinh That is mostly correct, but I think it not 100% because it depends on where we use it in. I think make every function Independent and don't be affected by the place where it is used in looks more safe and clean. So I propose fixing them.

@ahmedGaber93 sure. I updated in this commit fe7d499. But it's failing test of CalendarPickerTest. There is a report in Slack here https://expensify.slack.com/archives/C01GTK53T8Q/p1738397681223439

ahmedGaber93 · 2025-02-03T13:56:41Z

The failing test will fix here #56229

ahmedGaber93 · 2025-02-03T21:13:05Z

@hoangzinh test should work now, let's merge main.

…-on-another-device

hoangzinh · 2025-02-04T09:03:19Z

@ahmedGaber93 Done. All checklist are passed

ahmedGaber93

LGTM!

ahmedGaber93 · 2025-02-05T14:30:01Z

@hoangzinh It looks we have git conflict here, please resolve it. Thanks!

…-on-another-device

hoangzinh · 2025-02-05T15:33:06Z

Done @ahmedGaber93

dangrous

nearly there! We need to update those policyID defaults to match the new style, but otherwise looking good.

dangrous · 2025-02-05T17:50:22Z

src/pages/workspace/accounting/netsuite/advanced/NetSuiteCollectionAccountSelectPage.tsx

    const {translate} = useLocalize();

-    const policyID = policy?.id ?? '-1';
+    const policyID = policy?.id ?? `${CONST.DEFAULT_NUMBER_ID}`;


I believe we shouldn't default this value anymore - https://github.com/Expensify/App/blob/main/contributingGuides/STYLE.md#default-value-for-inexistent-ids - "To address both problems, string IDs should not have a default value."

src/pages/workspace/accounting/netsuite/advanced/NetSuiteApprovalAccountSelectPage.tsx

...ages/workspace/accounting/netsuite/advanced/NetSuiteExpenseReportApprovalLevelSelectPage.tsx

src/pages/workspace/accounting/netsuite/advanced/NetSuiteVendorBillApprovalLevelSelectPage.tsx

hoangzinh · 2025-02-06T10:24:37Z

@dangrous, can you help confirm if reimbursablePayableAccount and payableAcct of Netsuite config are not nullable/undefined value and the default value is always an empty string in BE?

App/src/types/onyx/Policy.ts

Lines 976 to 977 in a8daefb

    
           /** Credit account for reimbursable transactions */ 
        
           reimbursablePayableAccount: string;

App/src/types/onyx/Policy.ts

Lines 1000 to 1001 in a8daefb

    
           /** Credit account for Non-reimbursables (not applicable to expense report entry) */ 
        
           payableAcct: string;

I would like to get confirmation to fix TS error here

App/src/pages/workspace/accounting/netsuite/export/NetSuiteExportExpensesPayableAccountSelectPage.tsx

Lines 43 to 45 in a8daefb

    
               Connections.updateNetSuiteReimbursablePayableAccount(policyID, value, currentPayableAccountID ?? ''); 
        
           } else { 
        
               Connections.updateNetSuitePayableAcct(policyID, value, currentPayableAccountID ?? '');

dangrous · 2025-02-06T19:22:00Z

checking! It looks like payableAcct will definitely exist, with an empty string as the default. Not yet sure about reimbursablePayableAccount, but I think it will also be at least an empty string.

dangrous · 2025-02-07T00:38:41Z

hey @hoangzinh I'm still not 100% sure but I think we can move forward with assuming reimbursablePayableAccount will always be there - you can blame any bugs due to that on me 😉

hoangzinh · 2025-02-07T08:21:28Z

Perfect. Thank you @dangrous

hoangzinh · 2025-02-07T09:58:58Z

Hey @dangrous @ahmedGaber93 I fixed type-check for "Default value for inexistent IDs" in this commit. Reg. reimbursablePayableAccount and payableAcct, I trust you @dangrous but I think it's better if we can keep current behavior, I fixed it in this commit

Feel free to review this PR again. I tried to test as much as I can

Screen.Recording.2025-02-07.at.16.05.31.mov

dangrous · 2025-02-10T20:23:29Z

Would it make more sense to update the getRoute methods to check for invalid policyIDs (like this one) rather than having to add the policyID && checks everywhere?

Let us know what you think when you take another look, too, @ahmedGaber93

ahmedGaber93 · 2025-02-11T00:55:15Z

...ages/workspace/accounting/netsuite/export/NetSuiteExportExpensesPayableAccountSelectPage.tsx

-    const currentPayableAccountID = config?.[currentSettingName];
+    const currentPayableAccountID = config?.[currentSettingName] ?? CONST.NETSUITE_PAYABLE_ACCOUNT_DEFAULT_VALUE;
    const netsuitePayableAccountOptions = useMemo<SelectorType[]>(() => getNetSuitePayableAccountOptions(policy ?? undefined, currentPayableAccountID), [currentPayableAccountID, policy]);

    const initiallyFocusedOptionKey = useMemo(() => netsuitePayableAccountOptions?.find((mode) => mode.isSelected)?.keyForList, [netsuitePayableAccountOptions]);

    const updatePayableAccount = useCallback(
        ({value}: SelectorType) => {
-            if (currentPayableAccountID !== value) {
+            if (currentPayableAccountID !== value && policyID) {
                if (isReimbursable) {
-                    Connections.updateNetSuiteReimbursablePayableAccount(policyID, value, currentPayableAccountID ?? '');
+                    updateNetSuiteReimbursablePayableAccount(policyID, value, currentPayableAccountID);


I think we shouldn't worry about this change, and no bugs can come from it, because we just pass the ESLint here.
Default to ?? CONST.NETSUITE_PAYABLE_ACCOUNT_DEFAULT_VALUE is the same as with default to ?? ''.

yes, it's @ahmedGaber93

ahmedGaber93 · 2025-02-11T01:04:17Z

...pace/accounting/netsuite/export/NetSuiteExportExpensesJournalPostingPreferenceSelectPage.tsx

-            if (row.value !== config?.journalPostingPreference) {
-                Connections.updateNetSuiteJournalPostingPreference(policyID, row.value, config?.journalPostingPreference);
+            if (row.value !== config?.journalPostingPreference && policyID) {
+                updateNetSuiteJournalPostingPreference(policyID, row.value, config?.journalPostingPreference);


Like #56021 (comment), would returning early inside updateNetSuiteJournalPostingPreference cleaner than using && policyID? Also for all places we check for && policyID?

In my opinion, either way is the same and fine for LOCs above.

@dangrous please correct me if I'm wrong but I'm interpreting what you mentioned #56021 (comment) here is this line

App/src/pages/workspace/accounting/netsuite/export/NetSuiteExportExpensesJournalPostingPreferenceSelectPage.tsx

Line 51 in 6668710

Navigation.goBack(policyID && ROUTES.POLICY_ACCOUNTING_NETSUITE_EXPORT_EXPENSES.getRoute(policyID, params.expenseType));

I'm open - haha, I just don't like Navigation.goBack(policyID && ... so anything that removes as many of those policy && and && policy as possible is ideal. Up to you which you prefer!

The reason why I don't prefer this, because eventually, getRoute will return something like settings/workspaces/undefined/accounting, which is an invalid route.

Therefore, in my opinion, in case policyID is undefined/null, we should not pass fallbackRoute into Navigation.goBack, something like:

if (!policyID) { Navigation.goBack() } else { Navigation.goBack(ROUTES.POLICY_ACCOUNTING_NETSUITE_EXPORT_EXPENSES.getRoute(policyID, params.expenseType)); }

which Navigation.goBack(policyID && ... is equivalent. What do you guys think?

Yeah I don't mind that. What do you think @ahmedGaber93

sorry was OOO! So looking again through the codebase, I think we have two patterns that we can match:

early return if no policyID, as @ahmedGaber93 suggests. Example here though I didn't find m/any that were purely just goBack without an operation before hand.

Within the route itself, allow for the bad route (.../undefined/...) but log an error. Example [here] (but there are a lot more) (

App/src/ROUTES.ts

Lines 1811 to 1819 in ed25f23

POLICY_ACCOUNTING_NETSUITE_SUBSIDIARY_SELECTOR: {

route: 'settings/workspaces/:policyID/accounting/netsuite/subsidiary-selector',

getRoute: (policyID: string | undefined) => {

if (!policyID) {

Log.warn('Invalid policyID is used to build the POLICY_ACCOUNTING_NETSUITE_SUBSIDIARY_SELECTOR route');

}

return `settings/workspaces/${policyID}/accounting/netsuite/subsidiary-selector` as const;

},

},

).

I think I'd still prefer the latter, because it'll be more clear to us when something is going wrong, and that seems to be what we've done most of the time - even specifically with NetSuite.

I'm fine with 2nd option @dangrous. Do you agree with 2nd option? @ahmedGaber93

Yeah, I'm fine with both. And I agree that the 2nd option is more clear to us when something is going wrong.

Cool. I will try to update it today

Done. Feel free to give another review @ahmedGaber93 @dangrous

…-on-another-device

ahmedGaber93

LGTM!

dangrous

Awesome! Thanks for your patience with this one - it looks great,

OSBotify · 2025-02-25T22:08:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-26T00:22:34Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.1.6-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-02-26T10:42:54Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.1.6-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-02-26T22:40:13Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.6-1 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

hoangzinh added 5 commits January 30, 2025 08:38

Use optional chaining for netsuite?.options to handle nullable of net…

d34e0b5

…suite

Subcribe policy in Onyx

466bc26

Fix Eslint

6836029

Fix eslint

fb872cd

Merge branch 'main' into 55723-fix-app-crash-when-disconnect-netsuite…

d0a79d2

…-on-another-device

hoangzinh marked this pull request as ready for review January 30, 2025 12:10

hoangzinh requested a review from a team as a code owner January 30, 2025 12:10

melvin-bot bot requested review from ahmedGaber93 and removed request for a team January 30, 2025 12:10

hoangzinh added 4 commits February 2, 2025 22:15

Merge branch 'main' into 55723-fix-app-crash-when-disconnect-netsuite…

ce52ff4

…-on-another-device

Use optional chaining for netsuite?.options to handle nullable of net…

fe7d499

…suite

Fix eslint

17046f8

Trigger Build

34a4a3c

Merge branch 'main' into 55723-fix-app-crash-when-disconnect-netsuite…

35f9dcc

…-on-another-device

ahmedGaber93 approved these changes Feb 5, 2025

View reviewed changes

melvin-bot bot requested a review from dangrous February 5, 2025 14:28

Merge branch 'main' into 55723-fix-app-crash-when-disconnect-netsuite…

361395b

…-on-another-device

ahmedGaber93 approved these changes Feb 5, 2025

View reviewed changes

dangrous requested changes Feb 5, 2025

View reviewed changes

Fix typecheck of Default value for inexistent IDs

4a479d6

hoangzinh added 2 commits February 7, 2025 15:14

Fix typecheck of Default value of netsuite payable account value

0d485c0

Fix wrong method call

6668710

ahmedGaber93 reviewed Feb 11, 2025

View reviewed changes

ahmedGaber93 approved these changes Feb 14, 2025

View reviewed changes

melvin-bot bot requested a review from dangrous February 14, 2025 00:50

ahmedGaber93 mentioned this pull request Feb 24, 2025

[Due for payment 2025-03-05] [$250] Netsuite - App crashes when tapping on export settings after disconnecting with another device #55723

Closed

8 tasks

hoangzinh added 4 commits February 25, 2025 19:56

Merge branch 'main' into 55723-fix-app-crash-when-disconnect-netsuite…

5508fc0

…-on-another-device

Revert change

cb0f24f

Handle undefined value in getRoute functions

4220c2c

Revert change

c711462

ahmedGaber93 approved these changes Feb 25, 2025

View reviewed changes

dangrous approved these changes Feb 25, 2025

View reviewed changes

dangrous merged commit 0ef5301 into Expensify:main Feb 25, 2025
18 checks passed

github-actions bot mentioned this pull request Feb 25, 2025

Deploy Checklist: New Expensify 2025-02-25 #57435

Closed

49 tasks

	POLICY_ACCOUNTING_NETSUITE_SUBSIDIARY_SELECTOR: {
	route: 'settings/workspaces/:policyID/accounting/netsuite/subsidiary-selector',
	getRoute: (policyID: string \| undefined) => {
	if (!policyID) {
	Log.warn('Invalid policyID is used to build the POLICY_ACCOUNTING_NETSUITE_SUBSIDIARY_SELECTOR route');
	}
	return `settings/workspaces/${policyID}/accounting/netsuite/subsidiary-selector` as const;
	},
	},

Conversation

hoangzinh commented Jan 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 30, 2025

Uh oh!

ahmedGaber93 commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ahmedGaber93 commented Jan 31, 2025

Uh oh!

hoangzinh commented Feb 1, 2025

Uh oh!

ahmedGaber93 commented Feb 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hoangzinh commented Feb 3, 2025

Uh oh!

ahmedGaber93 commented Feb 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahmedGaber93 commented Feb 3, 2025

Uh oh!

hoangzinh commented Feb 4, 2025

Uh oh!

ahmedGaber93 left a comment

Choose a reason for hiding this comment

Uh oh!

ahmedGaber93 commented Feb 5, 2025

Uh oh!

hoangzinh commented Feb 5, 2025

Uh oh!

dangrous left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hoangzinh commented Feb 6, 2025

Uh oh!

dangrous commented Feb 6, 2025

Uh oh!

dangrous commented Feb 7, 2025

Uh oh!

hoangzinh commented Feb 7, 2025

Uh oh!

hoangzinh commented Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dangrous commented Feb 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hoangzinh Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

hoangzinh commented Jan 30, 2025 •

edited

Loading

ahmedGaber93 commented Jan 31, 2025 •

edited

Loading

ahmedGaber93 commented Feb 1, 2025 •

edited

Loading

ahmedGaber93 commented Feb 3, 2025 •

edited

Loading

hoangzinh commented Feb 7, 2025 •

edited

Loading

hoangzinh Feb 25, 2025 •

edited

Loading