Merged
Conversation
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
melvin-bot
bot
requested review from
shubham1206agra
and removed request for
a team
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
|
@perunt I believe we need to replace all DatePicker component usage with new DatePicker. |
Contributor
Author
|
@shubham1206agra Good point. I just replaced it and removed the old component. Testing throughout the app, and it looks good. Can you help me with it? There were around 10 places with the calendar component |
grgia
reviewed
Apr 11, 2025
Contributor
grgia
left a comment
grgia
left a comment
There was a problem hiding this comment.
Would you add QA steps to the PR description?
Contributor
|
NAB but some weird behavior while resizing Screen.Recording.2025-04-11.at.1.48.58.PM.mov |
grgia
approved these changes
Apr 11, 2025
Contributor
grgia
left a comment
grgia
left a comment
There was a problem hiding this comment.
Approving as NAB comment. Please add QA steps before we merge 😁
shubham1206agra
approved these changes
Apr 11, 2025
grgia
approved these changes
Apr 14, 2025
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
github-actions
bot
added
the
DeployBlockerCash
Contributor
Performance Comparison Report 📊 (1/10)Significant Changes To Duration
Show details
|
Contributor
Performance Comparison Report 📊 (10/10)Meaningless Changes To Duration (9/9)Show entries
Show details
|
Contributor
Performance Comparison Report 📊 (2/10)Meaningless Changes To Duration (1/9)Show entries
Show details
|
Contributor
Performance Comparison Report 📊 (3/10)Meaningless Changes To Duration (2/9)Show entries
Show details
|
Contributor
Performance Comparison Report 📊 (4/10)Meaningless Changes To Duration (3/9)Show entries
Show details
|
Contributor
Performance Comparison Report 📊 (5/10)Meaningless Changes To Duration (4/9)Show entries
Show details
|
Contributor
Performance Comparison Report 📊 (6/10)Meaningless Changes To Duration (5/9)Show entries
Show details
|
Contributor
Performance Comparison Report 📊 (7/10)Meaningless Changes To Duration (6/9)Show entries
Show details
|
Contributor
Performance Comparison Report 📊 (8/10)Meaningless Changes To Duration (7/9)Show entries
Show details
|
Contributor
Performance Comparison Report 📊 (9/10)Meaningless Changes To Duration (8/9)Show entries
Show details
|
Contributor
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
Contributor
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.1.28-0 🚀
|
8 tasks
Contributor
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.28-15 🚀
|
8 tasks
| formID, | ||
| autoFocus = false, | ||
| shouldHideClearButton = false, | ||
| }: DateInputWithPickerProps) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #52621
PROPOSAL:
Tests
Offline tests
QA Steps
Test Case 1: Manual Date Selection and Clear Functionality
Steps:
Test Case 2: Auto-Opening Date Picker in Settings Flow
The date picker should be automatically opened on the next screen:
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
2025-01-30.09.52.24.mp4
Android: mWeb Chrome
2025-01-30.15.41.05.mp4
iOS: Native
RPReplay_Final1738170552.MP4
iOS: mWeb Safari
MacOS: Chrome / Safari
Untitled.mov
MacOS: Desktop
Untitled.2.mov