New user workspace tasks by ishpaul777 · Pull Request #56141 · Expensify/App

ishpaul777 · 2025-01-31T10:05:03Z

Explanation of Change

Fixed Issues

$ #53509
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Sign up with new account and choose "Track and budget expense" in onboarding user intent.
Track a expense
in Selfdm choose to categorize it or share it with my accountant complete the flow.
Verify in you conceriege chat there are new tasks and with a message "Here are some important tasks to help get your team’s expenses under control." and a video

Test 2

Sign up with new account and choose any other option than "Manage my team's expense" in onboarding flow user intent.
Create a new worksapce
Verify in you conceriege chat there are new tasks and with a message "Here are some important tasks to help get your team’s expenses under control." and a video

Offline tests

QA Steps

Same as test steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-17.at.11.43.00.PM.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2025-01-18.at.3.24.19.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-01-18.at.3.41.30.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-01-17.at.3.53.34.AM.mov

MacOS: Desktop

Screen.Recording.2025-01-30.at.1.26.58.AM.mov

Screen.Recording.2025-01-30.at.1.31.24.AM.mov

…upData being empty

melvin-bot · 2025-01-31T10:08:58Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2025-01-31T10:10:43Z

@allroundexperts PLEASE IGNORE, @mananjadhav will take care of this

mananjadhav · 2025-01-31T11:35:37Z

I'll be reviewing this today.

francoisl

This is the same as #55302, see #55302 (comment) for extra context

francoisl · 2025-01-31T18:11:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

github-actions · 2025-02-03T23:34:44Z

🚀 Deployed to staging by https://github.com/francoisl in version: 9.0.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

IuliiaHerets · 2025-02-04T11:21:54Z

This PR is failing because of issues #56325 and #56328

github-actions · 2025-02-06T21:57:45Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.94-25 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2025-02-06T22:39:36Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.94-25 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

parasharrajat · 2025-04-02T13:54:19Z

src/libs/actions/Policy/Policy.ts

    };

+    if (!introSelected?.createWorkspace && engagementChoice && shouldAddOnboardingTasks) {
+        const onboardingData = ReportUtils.prepareOnboardingOnyxData(engagementChoice, CONST.ONBOARDING_MESSAGES[engagementChoice], adminsChatReportID, policyID);


We are now using prepareOnboardingOnyxData while creating the workspace, which is also used while onboarding. This function sets onboarding related information as well. When a workspace creation failed, it resets the onboarding state to null which should not happen while creating the workspace.

This caused #57499

ishpaul777 and others added 28 commits January 15, 2025 23:51

add tasks for new user first workspace

1002d3b

prettier

7014f2d

replace meetSetupSpecialist task with meetGuideTask and fix guidedSet…

c9b2f4f

…upData being empty

fix upgrade workspace case

61609ec

Fix merge conflicts before merging main

2f8e673

namespace imports lint failure

4921332

fix Do not default string IDs lint failure

1063cfa

update onboarding task posting logic for TRACK_WORKSPACE action

85c73bb

workaround for failing lint

d83382d

fix: update to correct adminsChatReportID param

06e71bc

merge main

9fa9862

Merge branch 'main' into new-user-workspace-tasks

e177668

fi onboarding accounting page not showing

b315040

fix: post tasks in admin room

bb02e14

reverse uninteded change

eb483d1

Merge branch 'Expensify:main' into new-user-workspace-tasks

8f8c6ec

fix: eslint

c509fd5

fix tests

e757aa3

Merge branch 'main' into new-user-workspace-tasks

385fd67

fix type

70b455f

revert submodule update

65dd712

Merge branch 'Expensify:main' into new-user-workspace-tasks

2eeafd0

fix typing

69b6333

fix more type error

fa48e46

fix report message not sent in payload

98dbb52

Merge branch 'Expensify:main' into new-user-workspace-tasks

40c93f0

fix copy

0e2565a

merge main

142545d

ishpaul777 mentioned this pull request Jan 31, 2025

add tasks for new user first workspace #55302

Merged

50 tasks

ishpaul777 marked this pull request as ready for review January 31, 2025 10:08

ishpaul777 requested a review from a team as a code owner January 31, 2025 10:08

melvin-bot bot requested review from allroundexperts and removed request for a team January 31, 2025 10:08

francoisl approved these changes Jan 31, 2025

View reviewed changes

francoisl removed the request for review from allroundexperts January 31, 2025 18:11

francoisl merged commit bbe16fa into Expensify:main Jan 31, 2025
28 of 29 checks passed

github-actions bot mentioned this pull request Feb 3, 2025

Deploy Checklist: New Expensify 2025-02-03 #56280

Closed

95 tasks

NJ-2020 mentioned this pull request Feb 4, 2025

Onboarding - "Invite your team" task description is not styled correctly #56308

Closed

8 tasks

IuliiaHerets mentioned this pull request Feb 4, 2025

Concierge - Message after tracking expense ends with "your workspace set up" #56325

Closed

8 tasks

This was referenced Feb 4, 2025

Concierge - Video is missing after tracking the first expense #56328

Closed

No intro message before tasks when workspace is created from "Share it with my accountant" #56360

Closed

melvin-bot bot mentioned this pull request Feb 6, 2025

[$500] [Due for payment 2025-02-13] [Add onboarding for new workspaces being created] Create new setup tasks when users create a workspace #53509

Closed

parasharrajat mentioned this pull request Feb 28, 2025

[Due for payment 2025-03-31] [$250] Onboarding modal is shown to the user on creating workspace. #57499

Closed

8 tasks

parasharrajat reviewed Apr 2, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New user workspace tasks#56141

New user workspace tasks#56141
francoisl merged 28 commits intoExpensify:mainfrom
ishpaul777:new-user-workspace-tasks

ishpaul777 commented Jan 31, 2025 •

edited

Loading

Uh oh!

melvin-bot bot commented Jan 31, 2025

Uh oh!

ishpaul777 commented Jan 31, 2025

Uh oh!

mananjadhav commented Jan 31, 2025

Uh oh!

francoisl left a comment

Uh oh!

francoisl commented Jan 31, 2025

Uh oh!

Uh oh!

github-actions bot commented Feb 3, 2025

Uh oh!

IuliiaHerets commented Feb 4, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Feb 6, 2025

Uh oh!

github-actions bot commented Feb 6, 2025

Uh oh!

parasharrajat Apr 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

ishpaul777 commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 31, 2025

Uh oh!

ishpaul777 commented Jan 31, 2025

Uh oh!

mananjadhav commented Jan 31, 2025

Uh oh!

francoisl left a comment

Choose a reason for hiding this comment

Uh oh!

francoisl commented Jan 31, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions bot commented Feb 3, 2025

Uh oh!

IuliiaHerets commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 6, 2025

Uh oh!

github-actions bot commented Feb 6, 2025

Uh oh!

parasharrajat Apr 2, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ishpaul777 commented Jan 31, 2025 •

edited

Loading

IuliiaHerets commented Feb 4, 2025 •

edited

Loading