[NoQA] Unsubscribe from Broadcast receiver task by gedu · Pull Request #56169 · Expensify/App

gedu · 2025-01-31T15:29:20Z

Explanation of Change

When Pressing R to reload the app from Metro, the app crash, need to unregister from the ghost task that gets linked to the destroyed RN bridge.

Fixed Issues

$ #56175
PROPOSAL: -

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13420

Tests

Run the Android App
Go to the Metro console
Press R so it reloads the app
It should load the app back again
Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_background.mp4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-01-31T17:05:49Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

gedu · 2025-02-05T17:16:27Z

@mountiny do I need to do something here?

mountiny · 2025-02-05T23:24:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

gedu · 2025-02-14T18:19:46Z

@mountiny Any updates here?

mountiny · 2025-02-17T10:01:48Z

https://github.com/Expensify/Mobile-Expensify/pull/13420 being reviewed

github-actions · 2025-02-17T10:02:34Z

🚧 @mountiny has triggered a test hybrid app build. You can view the workflow run here.

github-actions · 2025-02-18T12:45:27Z

🚧 @mountiny has triggered a test hybrid app build. You can view the workflow run here.

github-actions · 2025-02-18T13:17:44Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/56169/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
N/A	N/A
N/A	N/A

👀 View the workflow run that generated this build 👀

mountiny · 2025-02-18T13:20:39Z

@gedu seems like the failure is related:

Error: 'expensify-react-native-background-task/RNBackgroundTaskManager.h' file not found (in target 'Expensify' from project 'Expensify')

gedu · 2025-02-18T13:22:33Z

@gedu seems like the failure is related:

Error: 'expensify-react-native-background-task/RNBackgroundTaskManager.h' file not found (in target 'Expensify' from project 'Expensify')

Ok, I will take a look at it

gedu · 2025-02-18T16:23:50Z

@mountiny that error is from the standalone app?

mountiny · 2025-02-19T10:41:54Z

@gedu no that workflow is from building hybrid

github-actions · 2025-02-19T10:42:06Z

🚧 @mountiny has triggered a test hybrid app build. You can view the workflow run here.

# Conflicts: # .gitignore # Mobile-Expensify

gedu · 2025-02-19T13:18:49Z

I can't reproduce that error, it is working for me, is it a way to replicate that process locally? @mountiny

# Conflicts: # Mobile-Expensify

mountiny · 2025-02-20T09:18:42Z

Not sure @staszekscp @WoLewicki do you have any tips?

github-actions · 2025-02-20T09:19:11Z

🚧 @mountiny has triggered a test hybrid app build. You can view the workflow run here.

WoLewicki · 2025-02-20T09:34:54Z

I will look at it now.

staszekscp · 2025-02-20T09:54:24Z

Cache restored successfully could be the reason - in that case the file mentioned in the error may not have been included

WoLewicki · 2025-02-20T10:18:25Z

The error says Error: 'expensify-react-native-background-task/RNBackgroundTaskManager.h' file not found (in target 'Expensify' from project 'Expensify').

I have the same error when trying to add import in ExpensifyAppDelegate.m since it does not see that import. I am curious about your setup @gedu, don't you have any additional changes locally and you are sure that you are building OD?
I suggest it might be connected to building OD as frameworks. The change works for me if I change the import to #import <expensify_react_native_background_task/RNBackgroundTaskManager.h> ( _ instead of -). It is typical problem for frameworks so hopefully it is enough.

gedu · 2025-02-20T12:10:11Z

@WoLewicki

No additional setup. What do you mean building the OldDot? I'm running the hybrid as normal
I can try locally and see

WoLewicki · 2025-02-20T13:05:55Z

No additional setup. What do you mean building the OldDot? I'm running the hybrid as normal

Yeah, sorry I meant the HybridApp. So it's weird that it works locally on some machines and on some doesn't 😅

I can try locally and see

Would be perfect 🤞

gedu · 2025-02-20T15:49:34Z

I changed on both root, ios and in Mobile-Expensify and still working, I don't have the crash as here, so maybe I can change from - to _ that seems to be working here?

# Conflicts: # Mobile-Expensify

github-actions · 2025-02-21T15:26:11Z

⚠️ This PR is possibly changing native code, it may cause problems with HybridApp. Please run an AdHoc build to verify that HybridApp will not break. ⚠️

gedu · 2025-02-21T15:26:56Z

Updated and checked with szymon and he gave me greenlight

mountiny

https://github.com/Expensify/Mobile-Expensify/pull/13420 was merged so merging this one too

OSBotify · 2025-02-24T12:23:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…ound_invalidate [NoQA] Unsubscribe from Broadcast receiver task (cherry picked from commit eda939c) (CP triggered by mountiny)

github-actions · 2025-02-24T14:15:03Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.4-2 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2025-02-24T14:59:57Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.4-2 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2025-02-24T19:42:32Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.4-4 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

Unsubscribe from Broadcast receiver task

0b58bc8

gedu marked this pull request as ready for review January 31, 2025 17:05

gedu requested a review from a team as a code owner January 31, 2025 17:05

melvin-bot bot requested a review from c3024 January 31, 2025 17:05

melvin-bot bot removed the request for review from a team January 31, 2025 17:05

gedu mentioned this pull request Jan 31, 2025

[Due for payment 2025-03-11] [Due for payment 2025-03-05] [Due for payment 2025-03-03] [dev] native app is crashing when reloaded in development #56175

Closed

mountiny assigned gedu Feb 5, 2025

mountiny changed the title ~~Unsubscribe from Broadcast receiver task~~ [NoQA] Unsubscribe from Broadcast receiver task Feb 5, 2025

mountiny self-requested a review February 5, 2025 23:51

gedu mentioned this pull request Feb 6, 2025

[HOLD for 51257] "An Error Occurred" Android 13 Expensify Classic mobile app #56383

Closed

8 tasks

Merge branch 'main' into gedu/android_background_invalidate

c62fb07

mountiny added the Ready To Build label Feb 17, 2025

This comment has been minimized.

Sign in to view

Merge branch 'main' into gedu/android_background_invalidate

9eb578a

Merge branch 'main' into gedu/android_background_invalidate

34f37f9

removed tmp.xcconfig and ignore it

a456699

gedu mentioned this pull request Feb 19, 2025

feat: setup background task from scratch on iOS #53834

Merged

48 tasks

Merge branch 'main' into gedu/android_background_invalidate

273f5b7

# Conflicts: # .gitignore # Mobile-Expensify

Merge branch 'main' into gedu/android_background_invalidate

d8ea400

# Conflicts: # Mobile-Expensify

Merge branch 'main' into gedu/android_background_invalidate

241c89b

# Conflicts: # Mobile-Expensify

mountiny approved these changes Feb 24, 2025

View reviewed changes

mountiny merged commit eda939c into Expensify:main Feb 24, 2025
15 checks passed

OSBotify pushed a commit that referenced this pull request Feb 24, 2025

Merge pull request #56169 from callstack-internal/gedu/android_backgr…

f586932

…ound_invalidate [NoQA] Unsubscribe from Broadcast receiver task (cherry picked from commit eda939c) (CP triggered by mountiny)

github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Feb 24, 2025

github-actions bot mentioned this pull request Feb 24, 2025

Deploy Checklist: New Expensify 2025-02-21 #57263

Closed

29 tasks

mountiny mentioned this pull request Feb 24, 2025

[CP Staging] Revert "[NoQA] Unsubscribe from Broadcast receiver task" #57325

Merged

Conversation

gedu commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 31, 2025

Uh oh!

gedu commented Feb 5, 2025

Uh oh!

mountiny commented Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

gedu commented Feb 14, 2025

Uh oh!

mountiny commented Feb 17, 2025

Uh oh!

github-actions bot commented Feb 17, 2025

Uh oh!

This comment has been minimized.

github-actions bot commented Feb 18, 2025

Uh oh!

github-actions bot commented Feb 18, 2025

Uh oh!

mountiny commented Feb 18, 2025

Uh oh!

gedu commented Feb 18, 2025

Uh oh!

gedu commented Feb 18, 2025

Uh oh!

mountiny commented Feb 19, 2025

Uh oh!

github-actions bot commented Feb 19, 2025

Uh oh!

gedu commented Feb 19, 2025

Uh oh!

mountiny commented Feb 20, 2025

Uh oh!

github-actions bot commented Feb 20, 2025

Uh oh!

WoLewicki commented Feb 20, 2025

Uh oh!

staszekscp commented Feb 20, 2025

Uh oh!

WoLewicki commented Feb 20, 2025

Uh oh!

gedu commented Feb 20, 2025

Uh oh!

WoLewicki commented Feb 20, 2025

Uh oh!

gedu commented Feb 20, 2025

Uh oh!

github-actions bot commented Feb 21, 2025

Uh oh!

gedu commented Feb 21, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Feb 24, 2025

Uh oh!

github-actions bot commented Feb 24, 2025

Uh oh!

github-actions bot commented Feb 24, 2025

Uh oh!

github-actions bot commented Feb 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

gedu commented Jan 31, 2025 •

edited

Loading

mountiny commented Feb 5, 2025 •

edited

Loading