[No QA] Enable profiling PR builds by jnowakow · Pull Request #56237 · Expensify/App

jnowakow · 2025-02-03T13:10:46Z

cc @mountiny @war-in

Explanation of Change

Thanks to this change we can check impact of proposed changes on Android build times.

Fixed Issues

$ N/A
PROPOSAL: N/A

Tests

Trigger workflow with arguments
Verify that comments with link to workflow where added to PRs

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-02-03T13:11:15Z

@tgolen Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jnowakow · 2025-02-03T13:29:37Z

@mountiny to test those changes you would have to copy them and open your own PR, right? Could you do this?

tgolen · 2025-02-03T16:29:01Z

.github/workflows/compareNDandODbuilds.yml

  workflow_dispatch:
+    inputs:
+      PULL_REQUEST_NUMBER:
+        description: Pull Request number for correct placement of app


What does "placement of app" mean?

It means that we want to build app from given commit

OK, what about changing this description this?

Pull request number to build the app from

Good idea, thanks!

mountiny · 2025-02-06T02:29:46Z

@jnowakow testing here https://github.com/Expensify/App/actions/runs/13170614196

jnowakow · 2025-02-06T13:45:12Z

Thanks @mountiny! I've pushed fixed so would be nice if you had minute to test it :)

mountiny · 2025-02-06T20:29:13Z

@jnowakow updated https://github.com/Expensify/App/actions/runs/13187331466

jnowakow · 2025-02-10T09:37:57Z

@mountiny if you could test this PR again it would be great 🙏

github-actions · 2025-02-14T01:44:21Z

🚧 @mountiny has triggered build profiling. You can view the workflow run here.

mountiny · 2025-02-14T02:06:35Z

Kicked it off

jnowakow · 2025-02-17T12:04:29Z

@mountiny can we give it another try? 🙏

github-actions · 2025-02-17T14:22:54Z

🚧 @mountiny has triggered build profiling. You can view the workflow run here.

jnowakow · 2025-02-19T07:01:04Z

@mountiny I think it's ready to be merged 🎉

mountiny · 2025-02-19T07:31:00Z

.github/workflows/compareNDandODbuilds.yml

+          GITHUB_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }}
+
+
+  postGitHubCommentBuildStarted:


This is now reused in three flows (testBuild, testHybridBuild and this one) could we create a composite action for it?

It's good idea! I'll open new PR for that - it will be cleaner

How do you think @mountiny?

@jnowakow yeah we dont have to do it here

.github/workflows/compareNDandODbuilds.yml

Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>

mountiny · 2025-02-19T08:41:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

mountiny

Changes look good to me @jnowakow can you please update the PR body with explanation/ motivation for this change?

mountiny · 2025-02-19T08:42:09Z

@tgolen all yours

OSBotify · 2025-02-19T16:02:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-20T03:07:20Z

🚀 Deployed to staging by https://github.com/tgolen in version: 9.1.2-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-02-20T22:00:34Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.1.2-1 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

Enable profiling PR builds

971eb9a

jnowakow requested a review from a team as a code owner February 3, 2025 13:10

jnowakow marked this pull request as draft February 3, 2025 13:10

melvin-bot bot requested review from tgolen and removed request for a team February 3, 2025 13:11

war-in approved these changes Feb 3, 2025

View reviewed changes

Fix workflow syntax

c98a41d

jnowakow changed the title ~~Enable profiling PR builds~~ [No QA] Enable profiling PR builds Feb 3, 2025

tgolen reviewed Feb 3, 2025

View reviewed changes

Update descriptions and fix syntax error

e1cd0c9

Fix checkout step

287b4c2

jnowakow marked this pull request as ready for review February 11, 2025 08:28

jnowakow added 3 commits February 14, 2025 08:19

Update workflow

57460cc

Merge branch 'main' into jnowakow/profile-arbitrary-build

5345bed

Merge branch 'main' into jnowakow/profile-arbitrary-build

497212e

mountiny assigned jnowakow Feb 17, 2025

Use correct keystore

7d5629b

mountiny requested changes Feb 19, 2025

View reviewed changes

Update description

d8534d7

Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>

Update description

801c432

Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>

mountiny approved these changes Feb 19, 2025

View reviewed changes

tgolen approved these changes Feb 19, 2025

View reviewed changes

tgolen merged commit d2b16d2 into Expensify:main Feb 19, 2025
9 of 11 checks passed

github-actions bot mentioned this pull request Feb 20, 2025

Deploy Checklist: New Expensify 2025-02-20 #57146

Closed

30 tasks

jnowakow mentioned this pull request Feb 21, 2025

[No QA] Move postGitHubCommentBuildStarted to separate file #57234

Merged

50 tasks

		GITHUB_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }}


		postGitHubCommentBuildStarted:

Conversation

jnowakow commented Feb 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 3, 2025

Uh oh!

jnowakow commented Feb 3, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mountiny commented Feb 6, 2025

Uh oh!

jnowakow commented Feb 6, 2025

Uh oh!

mountiny commented Feb 6, 2025

Uh oh!

jnowakow commented Feb 10, 2025

Uh oh!

github-actions bot commented Feb 14, 2025

Uh oh!

mountiny commented Feb 14, 2025

Uh oh!

jnowakow commented Feb 17, 2025

Uh oh!

github-actions bot commented Feb 17, 2025

Uh oh!

jnowakow commented Feb 19, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mountiny commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny commented Feb 19, 2025

Uh oh!

Uh oh!

OSBotify commented Feb 19, 2025

Uh oh!

github-actions bot commented Feb 20, 2025

Uh oh!

github-actions bot commented Feb 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jnowakow commented Feb 3, 2025 •

edited

Loading

mountiny commented Feb 19, 2025 •

edited

Loading