Skip to content

Fix new message not auto scrolled in search RHP #56293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndrewGable merged 3 commits into from
Feb 6, 2025
Merged

Fix new message not auto scrolled in search RHP #56293

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d6519c
Fix report auto scroll in search panel
wildan-m Jan 22, 2025
ea881cc
Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…
wildan-m Jan 24, 2025
811238e
Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…
wildan-m Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/home/report/ReportActionsList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ function ReportActionsList({
setIsFloatingMessageCounterVisible(false);
// If a new comment is added and it's from the current user scroll to the bottom otherwise leave the user positioned where
// they are now in the list.
if (!isFromCurrentUser || !isReportScreenTopmostCentralPane()) {
if (!isFromCurrentUser || (!isReportScreenTopmostCentralPane() && !Navigation.getReportRHPActiveRoute())) {
return;
}
if (!hasNewestReportActionRef.current) {
Comment on lines 464 to 467
Copy link
Contributor

@rayane-d rayane-d Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, This caused this issue: #56729
Fixed in this PR: #56749

Expand Down