Add Expensify Card promoting banner to Company cards page by ikevin127 · Pull Request #56561 · Expensify/App

ikevin127 · 2025-02-07T22:57:04Z

Explanation of Change

We want to make sure we promote the Expensify Card to customers who have the company cards or seeking this setup, this PR implements a promotional banner to the Company cards page such that:

when the admin clicks on the Learn more button we should take them to Expensify Card page
if the feature is not enabled, also optimistically enable it and call the api to enable the feature, then navigate to the Expensify Card page

Fixed Issues

$ #56485
PROPOSAL: #56485 (comment)

Tests

Precondition: Login and create a new workspace.

Test A (Expensify Card - Disabled)

Navigate to workspace settings > More features > enable Company cards.
Navigate to Company cards and notice the new Expensify Card promoting banner.
Tap on the banner's Learn more button.
Verify that this will enable the workspace's Expensify Card feature and navigate the user to it.

Test B (Expensify Card - Enabled)

Navigate to workspace settings > More features > enable both Company cards and Expensify Card features.
Navigate to Company cards and notice the new Expensify Card promoting banner.
Tap on the banner's Learn more button.
Verify that this will navigate the user to the already enabled workspace Expensify Card feature page.

Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.webm

Android: mWeb Chrome

android-mweb.webm

iOS: Native

ios.mp4

iOS: mWeb Safari

ios-mweb.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

…7-expensifyCardPromotion

melvin-bot · 2025-02-07T22:57:09Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ikevin127 · 2025-02-07T22:57:54Z

♻ Here's something to sort out before we merge this: currently I am using Onyx to store a boolean value locally based on which I decide to show / hide the banner - this value is set to true whenever the banner's Learn more button is pressed the first time.

⚠ Issue with this is:

the variable is global, meaning once the banner Learn more button was pressed on Workspace A and the variable becomes true, the banner won't show up again in any workspace (even a newly created one)

I. Since this 'has already been clicked' logic wasn't mentioned or required in the issue's OP, we can:

Remove the logic, therefore always showing the banner even after the Learn more button was pressed.
Keep the logic, but make it workspace specific - meaning we will store both policyID and the boolean value in order to fix the issue mentioned above.
(current behaviour) Keep the current logic as described above in the (⚠ Issue).

II. With this local Onyx variable there's one more thing to consider: when the user will press Settings > Trubleshooting > Clear cache and restart this will clear all local Onyx data, (depending on what we decide above) do we want to:

Add the new key to KEYS_TO_PRESERVE in order to maintain the data and keep the Expensify Card promoting banner hidden even after user performs Clear cache and restart.
(current behaviour) Don't preserve the new key, which will show the Expensify Card promoting banner after user performs Clear cache and restart.

cc @mountiny @c3024

shawnborton · 2025-02-07T22:59:38Z

Nice! The videos look pretty good to me 👍

dubielzyk-expensify · 2025-02-07T23:18:46Z

This looks great. Can I ask what the back stack is? If you click back after clicking Learn more Expensify Card, then you go back to Company Card again? Part of me was wondering if we should make it so you click back to More Features, but maybe that's weird or needlessly complicated

dannymcclain · 2025-02-07T23:25:51Z

One question for @Expensify/design is if we want to theme these banners for light and dark mode?

For the subscription banners, we do have different styles for light vs dark—do we want to carry that through here as well?

dubielzyk-expensify · 2025-02-07T23:28:33Z

Yeah I kinda think we should theme it cause it's VERY bright in dark mode there. I like that Danny!

ikevin127 · 2025-02-07T23:29:02Z

If you click back after clicking Learn more Expensify Card, then you go back to Company Card again?

@dubielzyk-expensify Correct, that's how it works on all platforms - seems logical to me in terms of navigation flow.

Screen.Recording.2025-02-07.at.15.20.45.mov

Part of me was wondering if we should make it so you click back to More Features, but maybe that's weird or needlessly complicated

I'm sure it can be done by replacing the Company cards route in the navigation stack with the More features route , just not sure that's what we want in this case, but if we decide for that let me know and I'll get to it.

shawnborton · 2025-02-07T23:29:26Z

Super down with that!

ikevin127 · 2025-02-08T00:14:28Z

@Expensify/design Does this look good ? I noticed that the title / subtitle text color in the issue's OP (this design) is a dark green, whereas with what you can see below: I used already existing styles that we use in the SubscriptionBillingBanner illustrated in #56561 (comment) (which must be the design).

dubielzyk-expensify · 2025-02-08T01:05:46Z

Let's just make both pieces of text be text-primary color:

cc @Expensify/design

shawnborton · 2025-02-08T01:09:17Z

I agree with that!

c3024 · 2025-02-08T07:31:08Z

~~@vit~~ @mountiny

W.r.t @ikevin127’s comment here, the OP does not specify whether we remove the banner after a user clicks on “Learn more” once. We keep the banner on the Company Cards page even after the user clicks on “Learn more,” right?

c3024 · 2025-02-08T06:53:18Z

src/libs/PolicyUtils.ts

 }

+function navigateToExpensifyCardPage(policyID: string) {
+    setTimeout(() => {


Suggested change

setTimeout(() => {

I think we need not use setTimeout here. It looks like we are using setTimeout for navigating the user back to workspace initial page with goBackWhenEnableFeature only for narrow layouts after enabling a feature. setTimeout does not seem to serve any purpose here.

c3024 · 2025-02-08T06:54:17Z

src/libs/actions/Policy/Policy.ts


+    if (enabled && shouldNavigateToExpensifyCardPage) {
+        navigateToExpensifyCardPage(policyID);
+        setHasSeenExpensifyCardPromotionBanner();


Suggested change

setHasSeenExpensifyCardPromotionBanner();

We are already calling setHasSeenExpensifyCardPromotionBanner in navigateToExpensifyCardPage.

c3024 · 2025-02-08T07:01:37Z

src/libs/actions/Policy/Policy.ts

 }

-function enableExpensifyCard(policyID: string, enabled: boolean) {
+/**


We can omit these JSDoc comments that are redundant with TypeScript.

c3024 · 2025-02-08T07:12:57Z

src/pages/workspace/companyCards/WorkspaceCompanyCardPageEmptyState.tsx

-        CompanyCards.clearAddNewCardFlow();
-        Navigation.navigate(ROUTES.WORKSPACE_COMPANY_CARDS_ADD_NEW.getRoute(policy?.id ?? '-1'));
+        clearAddNewCardFlow();
+        Navigation.navigate(ROUTES.WORKSPACE_COMPANY_CARDS_ADD_NEW.getRoute(policy?.id ?? String(CONST.DEFAULT_NUMBER_ID)));


Do not default string IDs to any value.

src/libs/PolicyUtils.ts

ikevin127 · 2025-02-09T00:13:10Z

@Expensify/design Addressed the latest text style change request, here's how it looks now:

@c3024 Addressed all code related change requests (👍), all that's left to decide regarding the logic is what I asked in #56561 (comment) and you reiterated in #56561 (comment).

mountiny · 2025-02-09T20:48:32Z

the OP does not specify whether we remove the banner after a user clicks on “Learn more” once. We keep the banner on the Company Cards page even after the user clicks on “Learn more,” right?

Right, I dont think we need this logic, we should show the banner all the time until they add a card feed - then the ui changes and we would not promote for the card with this pattern (we could add something more later but that is not in scope of this project)

…7-expensifyCardPromotion

ikevin127 · 2025-02-10T02:59:55Z

Right, I dont think we need this logic, we should show the banner all the time until they add a card feed - then the ui changes and we would not promote for the card with this pattern (we could add something more later but that is not in scope of this project)

✅ Done, makes total sense - thanks for jumping in over the weekend 🚀

☑️ all previous PR review comments / change requests are implemented
☑️ #56561 (comment) was resolved, we decided to remove local Onyx variable and show the banner at all times in the WorkspaceCompanyCardPageEmptyState page
☑️ design changes requested in #56561 (comment) are now up to date and implemented as displayed in #56561 (comment)

@c3024 PR is 💯% ready for review!

dubielzyk-expensify · 2025-02-10T05:30:33Z

@Expensify/design Addressed the latest text style change request, here's how it looks now:

That looks løvely! Thank you!

c3024 · 2025-02-10T06:19:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

bannerAndroid.mov

Android: mWeb Chrome

bannerAndroidmWeb.mp4

iOS: Native

banneriOS1.mov

banneriOS2.mov

iOS: mWeb Safari

banneriOSmWeb.MP4

MacOS: Chrome / Safari

bannerChrome.mov

MacOS: Desktop

bannerDesktop.mov

c3024

Thanks. LGTM!

c3024 · 2025-02-10T06:23:43Z

@ikevin127

~~Navigate back to the Company cards page and verify that the banner doesn't show up anymore.~~

Please update the tests.

ikevin127 · 2025-02-11T08:30:01Z

✅ PR tests section updated - ready to be merged.

@mountiny Ready for your review!

…7-expensifyCardPromotion

luacmartins

LGTM

…7-expensifyCardPromotion

OSBotify · 2025-02-12T22:58:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-17T09:23:58Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.99-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-02-18T06:16:01Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.99-2 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

ikevin127 added 3 commits February 6, 2025 20:34

Add Expensify Promoting banner to the Company cards page

e07f982

Update - Add Expensify Card promoting banner to Company cards page

620fb1c

Merge branch 'main' of https://github.com/Expensify/App into ikevin12…

bff5be5

…7-expensifyCardPromotion

ikevin127 requested review from a team as code owners February 7, 2025 22:57

melvin-bot bot requested a review from c3024 February 7, 2025 22:57

melvin-bot bot removed the request for review from a team February 7, 2025 22:57

ikevin127 added 2 commits February 7, 2025 15:11

addressed lint issues

e66af34

addressed lint issues

0675be5

c3024 suggested changes Feb 8, 2025

View reviewed changes

src/libs/PolicyUtils.ts Show resolved Hide resolved

ikevin127 added 2 commits February 8, 2025 15:56

code review & design adjustments

43c6973

addressed lint issues

14249fb

ikevin127 added 2 commits February 9, 2025 18:43

Merge branch 'main' of https://github.com/Expensify/App into ikevin12…

fcb30f3

…7-expensifyCardPromotion

code review adjustments

7d91ce9

c3024 approved these changes Feb 10, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny February 10, 2025 06:21

ikevin127 mentioned this pull request Feb 11, 2025

[Due for payment 2025-03-05] [Due for payment 2025-02-25] [$250] Add Expensify Promoting banner to the Company cards page #56485

Closed

Merge branch 'main' of https://github.com/Expensify/App into ikevin12…

8471815

…7-expensifyCardPromotion

luacmartins approved these changes Feb 12, 2025

View reviewed changes

Merge branch 'main' of https://github.com/Expensify/App into ikevin12…

56c5f26

…7-expensifyCardPromotion

luacmartins merged commit fb2eb3f into Expensify:main Feb 12, 2025
15 checks passed

github-actions bot mentioned this pull request Feb 17, 2025

Deploy Checklist: New Expensify 2025-02-17 #56922

Closed

46 tasks

mountiny mentioned this pull request Feb 17, 2025

[Due for payment 2025-02-28] Expensify Card tab is highlighted every time coming back from the promotional banner #56937

Closed

8 tasks

This was referenced Feb 19, 2025

Promotional Banner: Fix workspace enabled feature highlight #57061

Merged

Expensify Card promotion banner conditional display #57218

Merged

Conversation

ikevin127 commented Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 7, 2025

Uh oh!

ikevin127 commented Feb 7, 2025

Uh oh!

shawnborton commented Feb 7, 2025

Uh oh!

dubielzyk-expensify commented Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dannymcclain commented Feb 7, 2025

Uh oh!

dubielzyk-expensify commented Feb 7, 2025

Uh oh!

ikevin127 commented Feb 7, 2025

Uh oh!

shawnborton commented Feb 7, 2025

Uh oh!

ikevin127 commented Feb 8, 2025

Uh oh!

dubielzyk-expensify commented Feb 8, 2025

Uh oh!

shawnborton commented Feb 8, 2025

Uh oh!

c3024 commented Feb 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

c3024 Feb 8, 2025

Choose a reason for hiding this comment

Uh oh!

c3024 Feb 8, 2025

Choose a reason for hiding this comment

Uh oh!

c3024 Feb 8, 2025

Choose a reason for hiding this comment

Uh oh!

c3024 Feb 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ikevin127 commented Feb 9, 2025

Uh oh!

mountiny commented Feb 9, 2025

Uh oh!

ikevin127 commented Feb 10, 2025

Uh oh!

dubielzyk-expensify commented Feb 10, 2025

Uh oh!

c3024 commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

c3024 left a comment

Choose a reason for hiding this comment

Uh oh!

c3024 commented Feb 10, 2025

Uh oh!

ikevin127 commented Feb 11, 2025

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Feb 12, 2025

Uh oh!

github-actions bot commented Feb 17, 2025

Uh oh!

github-actions bot commented Feb 18, 2025

Uh oh!

ikevin127 commented Feb 7, 2025 •

edited

Loading

dubielzyk-expensify commented Feb 7, 2025 •

edited

Loading

c3024 commented Feb 8, 2025 •

edited

Loading

c3024 commented Feb 10, 2025 •

edited

Loading