Implement the React-Native Pusher library for iOS and Android by VickyStash · Pull Request #56610 · Expensify/App

VickyStash · 2025-02-10T16:36:00Z

Explanation of Change

Update the Pusher module to use @pusher/pusher-websocket-react-native lib on mobile platforms.

Fixed Issues

$ #56480
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Chat messages receiving

Login as User A on one device
Login as User B on another device
Chat with each other and verify each user is receiving messages from another one.

Expenses

Login as User A - workspace admin - on one device.
Login as User B - workspace member - on another device.
From User B submit the expense to the workspace. Make sure it starts to display for User A.
From User A approve and pay expense. Make sure updates are visible for User B.

Make sure "is typing" indicator is working

Login as User A on one device
Login as User B on another device
Start typing the message to User B from User A, User B should see "is typing" note
Start typing the message to User A from User B, User A should see "is typing" note

Room Leaving

Login as User A to two devices.
On both devices open a room.
On Device 1 click room details > Leave Room.
The user should leave the room on both devices.

Offline tests

N/A

QA Steps

Verify that no errors appear in the JS console

Same, as in the Tests section

PR Author Checklist

Screenshots/Videos

Android: Native

android1.mp4

Android: mWeb Chrome

android_web1.mp4

iOS: Native

ios_pt01.mp4

ios_pt02.mp4

iOS: mWeb Safari

ios_web_pt1.mp4

ios_web_pt2.mp4

MacOS: Chrome / Safari + MacOS: Desktop

web+desktop_pt01.mp4

web+desktop_pt2.mp4

…-native lib

VickyStash · 2025-02-12T15:35:03Z

Failing Verify HybridApp build / Comment on all PRs that are forks (pull_request) check is a known issue and isn't related to the PR.

melvin-bot · 2025-02-13T11:20:47Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

fabioh8010

Just NABs. Great work here 🚀

__mocks__/@pusher/pusher-websocket-react-native/index.ts

fabioh8010 · 2025-02-14T11:03:34Z

src/libs/Pusher/index.native.ts

+const MobilePusher: PusherModule = {
+    init,
+    subscribe,
+    unsubscribe,
+    getChannel,
+    isSubscribed,
+    isAlreadySubscribing,
+    sendEvent,
+    disconnect,
+    reconnect,
+    registerSocketEventCallback,
+    TYPE,
+    getPusherSocketID,
+};


I saw you changed the import structure so you can do like this Pusher.getPusherSocketID() in other files, please make sure this isn't creating cycle dependencies.

Yep, I've updated it to follow project rules of file organization for platform-specific implementations.
I believe we have import/no-cycle eslint rule turned on, so if cycle dependencies were the case the eslint check would fail.

Yep, I've updated it to follow project rules of file organization for platform-specific implementations.

Oh yes you are right, we should do this way 👍

I believe we have import/no-cycle eslint rule turned on, so if cycle dependencies were the case the eslint check would fail.

Unfortunately import/no-cycle is not that reliable to catch cycle dependencies, the best way is to check by yourself by running the Android or iOS app with Metro and checking the logs during startup.

I've just checked ios metro logs and there are no cycle warnings related to this PR 👌

VickyStash · 2025-02-17T07:48:35Z

@shubham1206agra any ETA on reviewing this one?

shubham1206agra · 2025-02-17T08:01:15Z

@VickyStash I will pick this up today.

shubham1206agra · 2025-02-18T07:24:36Z

@VickyStash Have you verified this does not happen pusher/pusher-websocket-react-native#154 in our code?

VickyStash · 2025-02-18T07:30:47Z

@VickyStash Have you verified this does not happen pusher/pusher-websocket-react-native#154 in our code?

I didn't have it during the testing. Did it crash for you?

github-actions · 2025-02-19T17:47:30Z

🚧 @mountiny has triggered a test hybrid app build. You can view the workflow run here.

github-actions · 2025-02-19T18:28:13Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android//index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios//index.html

Desktop 💻	Web 🕸️
N/A	N/A
N/A	N/A

👀 View the workflow run that generated this build 👀

shubham1206agra · 2025-02-20T07:43:38Z

I tested this on real device and it's working fine. I will post the checklist in few hours.

shubham1206agra · 2025-02-20T14:30:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-02-20.at.7.57.39.PM.mov

iOS: Native

Screen.Recording.2025-02-20.at.7.48.15.PM.mov

tgolen

Really nicely done with this! Thank you!

melvin-bot · 2025-02-20T17:14:41Z

@tgolen looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

tgolen · 2025-02-20T17:16:19Z

Failing Verify HybridApp build / Comment on all PRs that are forks (pull_request) check is a #56417 and isn't related to the PR.

OSBotify · 2025-02-20T17:25:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-20T22:19:09Z

🚀 Deployed to staging by https://github.com/tgolen in version: 9.1.3-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-02-21T22:51:45Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.1.3-4 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

VickyStash added 4 commits February 10, 2025 14:22

Initial updates to migrate mobile platforms to pusher-websocket-react…

82b4613

…-native lib

Reuse existing authenticatePusher function

2a56b1c

Fix channel resubscribing

879da13

Update Pusher folder structure

5e95a4d

VickyStash mentioned this pull request Feb 10, 2025

[Due for payment 2025-02-28] Implement the React-Native Pusher library for iOS and Android #56480

Closed

VickyStash added 11 commits February 11, 2025 10:29

TS fixes

0efbb8f

Code improvements

8385b85

Lint fixes

0a6be56

Add pusher-websocket-react-native mock to fix tests

625df9a

Code clean-up

5cd43fa

Minor fixes

ea403e0

Remove unnecessary mock

7cf37cd

Remove unnecessary pusher-js-mock lib

863a59a

Update Pusher module export since now it's platform-specific

dbd0421

Merge branch 'refs/heads/main' into VickyStash/refactor/rn-pusher-sdk

5389241

Re-run checks

416b9bf

VickyStash changed the title ~~[WIP] Implement the React-Native Pusher library for iOS and Android~~ Implement the React-Native Pusher library for iOS and Android Feb 13, 2025

Android: fix event trigger

4a6e373

VickyStash marked this pull request as ready for review February 13, 2025 11:20

VickyStash requested a review from a team as a code owner February 13, 2025 11:20

melvin-bot bot requested review from shubham1206agra and removed request for a team February 13, 2025 11:20

fabioh8010 approved these changes Feb 14, 2025

View reviewed changes

Minor update

0b975b1

fabioh8010 approved these changes Feb 14, 2025

View reviewed changes

tgolen mentioned this pull request Feb 14, 2025

[CRITICAL] Not receiving realtime updates to desktop/web session #52437

Closed

8 tasks

mountiny added the Ready To Build label Feb 19, 2025

shubham1206agra approved these changes Feb 20, 2025

View reviewed changes

melvin-bot bot requested a review from tgolen February 20, 2025 14:31

tgolen approved these changes Feb 20, 2025

View reviewed changes

tgolen merged commit d847b4a into Expensify:main Feb 20, 2025
21 of 25 checks passed

melvin-bot bot added the Emergency label Feb 20, 2025

tgolen removed the Emergency label Feb 20, 2025

github-actions bot mentioned this pull request Feb 20, 2025

Deploy Checklist: New Expensify 2025-02-20 #57207

Closed

36 tasks

blazejkustra mentioned this pull request Feb 20, 2026

[BATCH 5] Migrate to requestIdleCallback #83066

Open

Conversation

VickyStash commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

VickyStash commented Feb 12, 2025

Uh oh!

melvin-bot bot commented Feb 13, 2025

Uh oh!

fabioh8010 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fabioh8010 Feb 14, 2025

Choose a reason for hiding this comment

Uh oh!

VickyStash Feb 14, 2025

Choose a reason for hiding this comment

Uh oh!

fabioh8010 Feb 14, 2025

Choose a reason for hiding this comment

Uh oh!

VickyStash Feb 14, 2025

Choose a reason for hiding this comment

Uh oh!

VickyStash commented Feb 17, 2025

Uh oh!

shubham1206agra commented Feb 17, 2025

Uh oh!

shubham1206agra commented Feb 18, 2025

Uh oh!

VickyStash commented Feb 18, 2025

Uh oh!

github-actions bot commented Feb 19, 2025

Uh oh!

github-actions bot commented Feb 19, 2025

Uh oh!

shubham1206agra commented Feb 20, 2025

Uh oh!

shubham1206agra commented Feb 20, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

tgolen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melvin-bot bot commented Feb 20, 2025

Uh oh!

tgolen commented Feb 20, 2025

Uh oh!

OSBotify commented Feb 20, 2025

Uh oh!

github-actions bot commented Feb 20, 2025

Uh oh!

github-actions bot commented Feb 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

VickyStash commented Feb 10, 2025 •

edited

Loading