[No QA]Allow to build adhoc hybrid app from ND main and OD PR by jnowakow · Pull Request #56655 · Expensify/App

jnowakow · 2025-02-11T10:01:22Z

Explanation of Change

It's follow-up to hybrid adhoc builds. Thanks to this PR Expensify internals will be able to run adhoc build from ND's main and arbitrary PR in Mobile-Expensify. I got rid of the Ready to build label as it was leftover from initial works on this feature.

Fixed Issues

$ #56848
PROPOSAL: #51636 (comment)

Tests

Preparation steps:

Create PR in App repo
Create two PRs in Mobile-Expensify repo

Test scenario 1:

Trigger Build and deploy hybrid apps for testing passing only ND PR.
Verify that workflow checkout out to correct PR in App and main in Mobile-Expensify
Verify that comment with information about started build is added for App PR

Test scenario 2:

Trigger Build and deploy hybrid apps for testing passing only OD PR.
Verify that workflow checkout out to correct PR in Mobile-Expensify and main in App
Verify that comment with information about started build is added for Mobile-Expensify PR

Test scenario 3:

Trigger Build and deploy hybrid apps for testing passing both OD and ND PRs.
Verify that workflow checkout out to correct PRs in Mobile-Expensify and App repos.
Verify that comment with information about started build is added for both App and Mobile-Expensify PRs

Test scenario 4:

Add MOBILE-EXPENSIFY: OD_PR_NUMBER1 to PR's description in App repo.
Trigger Build and deploy hybrid apps for testing passing only ND PR.
Verify that workflow checkout out to correct PRs in Mobile-Expensify and App repos.
Verify that comment with information about started build is added for both App and Mobile-Expensify PRs

Test scenario 5:

Add MOBILE-EXPENSIFY: OD_PR_NUMBER1 to PR's description in App repo.
Trigger Build and deploy hybrid apps for testing passing both ND and OD (second) PR.
Verify that workflow checkout out to correct PRs in Mobile-Expensify and App repos.
Verify that comment with information about started build is added for both App and Mobile-Expensify PRs
OD PR that was passed to workflow dispatch should take precedence over one from description.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
N/A

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-02-11T10:01:27Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

.github/workflows/testBuildHybrid.yml

Co-authored-by: Marcin Warchoł <61014013+war-in@users.noreply.github.com>

Julesssss · 2025-02-11T21:20:40Z

.github/workflows/testBuildHybrid.yml

+          if [[ -z "${{ github.event.inputs.PULL_REQUEST_NUMBER }}" && -z "${{ github.event.inputs.OLD_DOT_PULL_REQUEST_NUMBER }}" ]]; then
+            echo "Invalid input. You have to pass at least one PR number"


I guess this is the workaround because Github doesn't allow us to specify that one of the param fields must be passed.

And we're still using PR number rather than URL for now?

I think that is totally fine, just want to check

Yeah, to it's to be sure at least one PR is added so we have place to put comments.

And we're still using PR number rather than URL for now?

Now two options are valid. You as internal can add OD PR number while dispatching workflow and we as externals can add link to ND PR description. The one passed during dispatch has higher priority.
I think it's handy because OD PR can be used to trigger build when there are only changes in Mobile-Expensify. And if some developer works on changes that require both ND and OD then they can link PRs and internals don't have to remember to pass two PRs when dispatching workflow

.github/workflows/testBuildHybrid.yml

… of github.com:software-mansion-labs/expensify-app-fork into jnowakow/build-hybrid-adhoc-from-mobile-expensify-only

Julesssss

Okay, it's looking good. Could you please write a small bit of documentation for external/internal engineers to understand how this works? I think a section in the main readme is fine for now.

jnowakow · 2025-02-13T15:05:44Z

@Julesssss can you take a look added documentation?

Julesssss

Perfect, thanks

Julesssss · 2025-02-13T18:48:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…nsify-only

jnowakow · 2025-02-18T13:05:01Z

@Julesssss can we proceed with this one? We can test it before merging but it would require you to copy those changes to your branch and trigger this workflow from it

Julesssss · 2025-02-18T21:46:33Z

Lets test it properly once live -- I ca CP or revert if necessary as this doesn't touch those workflows.

OSBotify · 2025-02-18T21:55:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-19T03:41:22Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.1.1-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

mountiny · 2025-02-19T10:02:45Z

@jnowakow the hybrid adhoc workflow is broken https://github.com/Expensify/App/actions/runs/13409919729

Julesssss · 2025-02-19T18:59:12Z

Seems to be working after the fix 🤞

github-actions · 2025-02-20T02:48:59Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.1.1-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

Allow to build adhoc hybrid app from ND main and OD PR

60558b5

jnowakow requested a review from a team as a code owner February 11, 2025 10:01

melvin-bot bot requested review from abdulrahuman5196 and removed request for a team February 11, 2025 10:01

war-in reviewed Feb 11, 2025

View reviewed changes

.github/workflows/testBuildHybrid.yml Outdated Show resolved Hide resolved

war-in approved these changes Feb 11, 2025

View reviewed changes

Update .github/workflows/testBuildHybrid.yml

8af0752

Co-authored-by: Marcin Warchoł <61014013+war-in@users.noreply.github.com>

Julesssss reviewed Feb 11, 2025

View reviewed changes

.github/workflows/testBuildHybrid.yml Show resolved Hide resolved

Julesssss reviewed Feb 11, 2025

View reviewed changes

.github/workflows/testBuildHybrid.yml Outdated Show resolved Hide resolved

jnowakow added 2 commits February 12, 2025 08:37

Rename inputs

6aa2f23

Merge branch 'jnowakow/build-hybrid-adhoc-from-mobile-expensify-only'…

dcb9883

… of github.com:software-mansion-labs/expensify-app-fork into jnowakow/build-hybrid-adhoc-from-mobile-expensify-only

jnowakow mentioned this pull request Feb 12, 2025

[No QA] build hybrid apps from Build and deploy apps for testing workflows #56769

Merged

50 tasks

Julesssss reviewed Feb 12, 2025

View reviewed changes

jnowakow added 2 commits February 13, 2025 15:58

Add documentation

bf0ff28

Fix syntax

eb50ca8

Julesssss previously approved these changes Feb 13, 2025

View reviewed changes

Fix workflow

8d1978d

jnowakow dismissed Julesssss’s stale review via 8d1978d February 14, 2025 07:45

jnowakow added 2 commits February 18, 2025 08:52

Merge branch 'main' into jnowakow/build-hybrid-adhoc-from-mobile-expe…

a633842

…nsify-only

Merge branch 'main' into jnowakow/build-hybrid-adhoc-from-mobile-expe…

b00c2ba

…nsify-only

Julesssss approved these changes Feb 18, 2025

View reviewed changes

Julesssss merged commit caadb2e into Expensify:main Feb 18, 2025
8 checks passed

github-actions bot mentioned this pull request Feb 19, 2025

Deploy Checklist: New Expensify 2025-02-19 #57066

Closed

56 tasks

jnowakow mentioned this pull request Feb 19, 2025

[NoQA] Add missing checkout to prep step in the hybrid adhoc test workflow #57089

Merged

50 tasks

melvin-bot bot mentioned this pull request Feb 20, 2025

HybridApp AdHoc test build improvements #56848

Closed

6 tasks

jnowakow mentioned this pull request Feb 20, 2025

[No QA] Fix commenting on Mobile-Expensify AdHoc workflow #57182

Merged

50 tasks

Julesssss mentioned this pull request Mar 5, 2025

[No QA] Fix calling workflow by using different syntax #57829

Merged

50 tasks

		if [[ -z "${{ github.event.inputs.PULL_REQUEST_NUMBER }}" && -z "${{ github.event.inputs.OLD_DOT_PULL_REQUEST_NUMBER }}" ]]; then
		echo "Invalid input. You have to pass at least one PR number"

Conversation

jnowakow commented Feb 11, 2025 • edited by Julesssss Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 11, 2025

Uh oh!

Uh oh!

Julesssss Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

Julesssss Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

Julesssss Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

jnowakow Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

jnowakow Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

jnowakow commented Feb 13, 2025

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

Julesssss commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

jnowakow commented Feb 18, 2025

Uh oh!

Julesssss commented Feb 18, 2025

Uh oh!

Uh oh!

OSBotify commented Feb 18, 2025

Uh oh!

github-actions bot commented Feb 19, 2025

Uh oh!

mountiny commented Feb 19, 2025

Uh oh!

Julesssss commented Feb 19, 2025

Uh oh!

github-actions bot commented Feb 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jnowakow commented Feb 11, 2025 •

edited by Julesssss

Loading

jnowakow Feb 12, 2025 •

edited

Loading

Julesssss commented Feb 13, 2025 •

edited

Loading