Remove beta categoryAndTagApprovers by Beamanator · Pull Request #56723 · Expensify/App

Beamanator · 2025-02-12T04:03:54Z

Explanation of Change

Removing beta now that everyone is on this beta as of 2 weeks ago & no issues have been found! (see linked issue)

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/431468

Tests

Make sure category & tag pages work fine with no console errors
Make sure you can assign & change category & tag approvers no problem (have to enable rules on the workspace first)

Verify that no errors appear in the JS console

Offline tests

Same as above, all while offline

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…a-categoryAndTagApprovers

melvin-bot · 2025-02-12T17:43:18Z

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2025-02-12T17:43:25Z

@s77rt @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Beamanator · 2025-02-12T17:45:55Z

Sorry @s77rt , assigned @allgandalf as he won the slack dice roll

allgandalf · 2025-02-12T17:52:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2025-02-12.at.11.47.18.PM.mov

Screen.Recording.2025-02-12.at.11.45.04.PM.mov

Screen.Recording.2025-02-12.at.11.49.12.PM.mov

MacOS: Desktop

Screen.Recording.2025-02-12.at.11.51.21.PM.mov

iOS: Native

Screen.Recording.2025-02-12.at.11.53.10.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-02-12.at.11.54.50.PM.mov

Android: Native

Screen.Recording.2025-02-12.at.11.57.38.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-02-12.at.11.59.42.PM.mov

allgandalf · 2025-02-12T18:05:57Z

src/pages/workspace/tags/TagSettingsPage.tsx

    const policy = usePolicy(policyID);
-    const hasAccountingConnections = PolicyUtils.hasAccountingConnections(policy);
-    const {canUseCategoryAndTagApprovers} = usePermissions();
+    const policyHasAccountingConnections = hasAccountingConnections(policy);


To trouble you a little, we have the following guideline:

import { specificMethod as specificMethodSpecificModule } from '@libs/SpecificModule';

if variable name and module name are the same, this is honestly NAB for me, but just saying as there was this slack post :

What do you think should we proceed as is or what ?

ooooooooooooooooooooooooooooo i absolutely missed that, that's delicious - I can update!

That's the right attitude ❤️ 😄

fixeddddddddddddddddddd

wizard back to workkkk

allgandalf

Tests well and LGTM!, lets kick the beta out 😎

melvin-bot · 2025-02-12T18:32:42Z

@blimpich Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2025-02-12T18:32:45Z

🎯 @allgandalf, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #56774.

blimpich · 2025-02-13T01:56:45Z

Didn't get to reviewing this today, will review first thing tomorrow morning!

blimpich

LGTM!

OSBotify · 2025-02-13T18:13:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-17T09:24:31Z

🚀 Deployed to staging by https://github.com/blimpich in version: 9.0.99-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-02-18T06:16:34Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.99-2 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

shubham1206agra · 2025-03-07T10:51:19Z

src/pages/workspace/tags/TagSettingsPage.tsx

+                        ? ROUTES.SETTINGS_TAG_GL_CODE.getRoute(policy?.id ?? `${CONST.DEFAULT_NUMBER_ID}`, orderWeight, tagName, backTo)
+                        : ROUTES.WORKSPACE_TAG_GL_CODE.getRoute(policy?.id ?? `${CONST.DEFAULT_NUMBER_ID}`, orderWeight, tagName),


Umm. This should violate the ESLint rule. https://expensify.slack.com/archives/C01GTK53T8Q/p1737913879440099

@Beamanator Can you run the fix here please?

ooohhhhhhh yeppppppppp

Remove beta categoryAndTagApprovers

25188b9

Beamanator self-assigned this Feb 12, 2025

Beamanator added 5 commits February 12, 2025 10:26

Remove default imports from category settings page

19bf51f

Fix import spacing and order

5ca5db1

Fix default imports on tag settings apge

5daa6b6

Fix a few more lint things

2c420b5

Merge branch 'main' of github.com:Expensify/App into beaman-removeBet…

12bbbe1

…a-categoryAndTagApprovers

Beamanator marked this pull request as ready for review February 12, 2025 17:43

Beamanator requested a review from a team as a code owner February 12, 2025 17:43

melvin-bot bot requested review from alitoshmatov and removed request for a team February 12, 2025 17:43

Beamanator requested review from a team and allgandalf and removed request for alitoshmatov February 12, 2025 17:43

melvin-bot bot requested review from s77rt and removed request for a team February 12, 2025 17:43

Beamanator removed the request for review from s77rt February 12, 2025 17:45

allgandalf reviewed Feb 12, 2025

View reviewed changes

Use correct approach for changing fn names

5165d3f

allgandalf approved these changes Feb 12, 2025

View reviewed changes

melvin-bot bot requested a review from blimpich February 12, 2025 18:32

melvin-bot bot mentioned this pull request Feb 12, 2025

[$250] [hold for payment 2025-02-25] Payment issue for E/App PR#56723 #56774

Closed

blimpich approved these changes Feb 13, 2025

View reviewed changes

blimpich merged commit e1547f6 into main Feb 13, 2025
17 of 19 checks passed

blimpich deleted the beaman-removeBeta-categoryAndTagApprovers branch February 13, 2025 18:04

github-actions bot mentioned this pull request Feb 17, 2025

Deploy Checklist: New Expensify 2025-02-17 #56922

Closed

46 tasks

mkzie2 mentioned this pull request Feb 17, 2025

[HOLD for payment 2025-02-26] Tag - GL code entered is not saved for tags. #56943

Closed

8 tasks

mjasikowski mentioned this pull request Feb 17, 2025

[CP Staging] Fixed GL code not being displayed in tag settings menu #56955

Merged

48 tasks

shubham1206agra reviewed Mar 7, 2025

View reviewed changes

Beamanator mentioned this pull request Mar 7, 2025

Remove invalid default for policyID #58009

Merged

50 tasks

		? ROUTES.SETTINGS_TAG_GL_CODE.getRoute(policy?.id ?? `${CONST.DEFAULT_NUMBER_ID}`, orderWeight, tagName, backTo)
		: ROUTES.WORKSPACE_TAG_GL_CODE.getRoute(policy?.id ?? `${CONST.DEFAULT_NUMBER_ID}`, orderWeight, tagName),

Conversation

Beamanator commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 12, 2025

Uh oh!

melvin-bot bot commented Feb 12, 2025

Uh oh!

Beamanator commented Feb 12, 2025

Uh oh!

allgandalf commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allgandalf Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Beamanator Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

allgandalf Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Beamanator Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

allgandalf Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

allgandalf left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Feb 12, 2025

Uh oh!

melvin-bot bot commented Feb 12, 2025

Uh oh!

blimpich commented Feb 13, 2025

Uh oh!

blimpich left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Feb 13, 2025

Uh oh!

github-actions bot commented Feb 17, 2025

Uh oh!

github-actions bot commented Feb 18, 2025

Uh oh!

shubham1206agra Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

Beamanator Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

Beamanator Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Beamanator commented Feb 12, 2025 •

edited

Loading

allgandalf commented Feb 12, 2025 •

edited

Loading

allgandalf Feb 12, 2025 •

edited

Loading

allgandalf Feb 12, 2025 •

edited

Loading