[Fix] Workspace - Inconsistent workspace subtitle when approver is changed in offline mode by JKobrynski · Pull Request #56770 · Expensify/App

JKobrynski · 2025-02-12T16:54:49Z

Explanation of Change

The options list has to be initialized on each render of MoneyRequestParticipantsSelector in order to reflect the latest changes, including changing the approver.

Fixed Issues

$ #56507
PROPOSAL: N/A

Tests

Go to staging.new.expensify.com
Create a new workspace.
Go to workspace settings > Members.
Invite a member to the workspace.
Go offline.
Go to workspace settings > Workflows.
Enable Add approvals.
Click on the existing workflow.
Click Approver.
Select the member invited in Step 5 as the new approver.
Save the workflow.
Go back to Inbox.
Open FAB > Create expense > Manual.
Enter amount > Next.
Make sure the workspace subtitle shows "Submits to [new approver]".
Click on the workspace.
Make sure the workspace subtitle shows "Submits to [new approver]".

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests section above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

web-compressed.mov

melvin-bot · 2025-02-12T17:01:06Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2025-02-12T17:11:17Z

src/components/OptionListContextProvider.tsx

    }, [personalDetails, reports]);

    const initializeOptions = useCallback(() => {
-        if (areOptionsInitialized.current) {


Would this cause any performance impact?

Good question! The way I see it is the following - this functionality was missing, and it needed to be added, so the app can function properly, it's not like we are compounding the performance of an existing functionality, we are adding one.

Previously, these options would only be initialized on the very first render of the MoneyRequestParticipantsList and stay that way until you relog/restart, ignoring changes made to the reports/policies made by you and others.

Yeah I don't have the best context on this one, so hence I am checking. May be @grgia could take a look as well.

I don't have the full context on why we needed this initially

mananjadhav · 2025-02-12T17:18:13Z

src/libs/OptionsListUtils.ts

-            const submitToAccountID = getSubmitToAccountID(policy, report);
-            const submitsToAccountDetails = allPersonalDetails?.[submitToAccountID];
-            const subtitle = submitsToAccountDetails?.displayName ?? submitsToAccountDetails?.login;
+            const subtitle = getChatRoomSubtitle(report, {isCreateExpenseFlow: true});


I am just trying to understand if something can break with the case with!subtitle || !config.isCreateExpenseFlow ?

You're right, I'm reverting that change

mananjadhav · 2025-02-12T17:21:14Z

src/pages/iou/request/MoneyRequestParticipantsSelector.tsx

        searchInServer(debouncedSearchTerm.trim());
    }, [debouncedSearchTerm]);

+    useEffect(() => {


does it cause any extra rerender? Do we have a way to check this?

Based on my testing, this just adds a function call

mananjadhav

Small comments. I'll also check if this PR solves the empty subtitle issue.

JKobrynski · 2025-02-14T13:57:46Z

@mananjadhav I checked and it looks like this PR won't solve #56609, it must be something else

github-actions · 2025-02-14T14:51:10Z

🚧 @grgia has triggered a test build. You can view the workflow run here.

github-actions · 2025-02-14T15:19:16Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/56770/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/56770/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/56770/NewExpensify.dmg	https://56770.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

mananjadhav · 2025-02-15T15:22:55Z

I am still testing this. Will have this completed before Monday.

mananjadhav · 2025-02-24T08:25:54Z

I did a basic test on the web. But I need to test this more across all platforms, which I will get done by today/tomorrow

…7-inconsistent-workspace-subtitle

JKobrynski · 2025-02-24T13:24:32Z

@mananjadhav I just updated the branch with the latest main, let me know if there's anything you'd like me to change here!

mananjadhav · 2025-02-25T05:30:58Z

I'll have the checklist updated today

mananjadhav · 2025-02-25T19:38:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-submits-to-offline.mov

Android: mWeb Chrome

mweb-chrome-submits-to-offline.mov

iOS: Native

ios-submits-to-offline.mov

iOS: mWeb Safari

mweb-safari-submits-to-offline.mov

MacOS: Chrome / Safari

desktop-submits-to-offline.mov

MacOS: Desktop

web-submits-to-offline.mov

mananjadhav · 2025-02-25T19:38:48Z

In the videos you'll notice an unrelated Mapbox error due to some keys. It's a problem with my local setup.

grgia

LGTM, As long as there are no major performance regressions, should be good to go

OSBotify · 2025-02-27T15:41:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-27T21:07:20Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.1.7-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-03-03T16:43:16Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.7-2 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

initialize options on MoneyRequestParticipantsSelector render

007a94a

JKobrynski marked this pull request as ready for review February 12, 2025 17:01

JKobrynski requested a review from a team as a code owner February 12, 2025 17:01

melvin-bot bot requested a review from mananjadhav February 12, 2025 17:01

melvin-bot bot removed the request for review from a team February 12, 2025 17:01

JKobrynski mentioned this pull request Feb 12, 2025

[Due for payment 2025-03-10] Workspace - Inconsistent workspace subtitle when approver is changed in offline mode #56507

Closed

8 tasks

mananjadhav reviewed Feb 12, 2025

View reviewed changes

revert subtitle logic in getReportOption

a4f6257

JKobrynski requested a review from mananjadhav February 13, 2025 09:32

JKobrynski mentioned this pull request Feb 14, 2025

[Due for payment 2025-03-17] [Create Expense] Submits To Display Name Missing #56609

Closed

grgia assigned grgia and unassigned grgia Feb 14, 2025

grgia added the Ready To Build label Feb 14, 2025

Merge remote-tracking branch 'upstream/main' into JKobrynski/fix/5650…

ea22c28

…7-inconsistent-workspace-subtitle

mananjadhav approved these changes Feb 25, 2025

View reviewed changes

melvin-bot bot requested a review from grgia February 25, 2025 19:39

grgia approved these changes Feb 27, 2025

View reviewed changes

grgia merged commit 124fd42 into Expensify:main Feb 27, 2025
18 checks passed

github-actions bot mentioned this pull request Feb 27, 2025

Deploy Checklist: New Expensify 2025-02-27 #57563

Closed

40 tasks

mitarachim mentioned this pull request Feb 28, 2025

[Due for payment 2025-04-14] [$250] Next Steps - Incorrect next steps is shown when submitting expense offline. #57574

Closed

8 tasks

Conversation

JKobrynski commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 12, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mananjadhav left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JKobrynski commented Feb 14, 2025

Uh oh!

github-actions bot commented Feb 14, 2025

Uh oh!

github-actions bot commented Feb 14, 2025

Uh oh!

mananjadhav commented Feb 15, 2025

Uh oh!

mananjadhav commented Feb 24, 2025

Uh oh!

JKobrynski commented Feb 24, 2025

Uh oh!

mananjadhav commented Feb 25, 2025

Uh oh!

mananjadhav commented Feb 25, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

mananjadhav commented Feb 25, 2025

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Feb 27, 2025

Uh oh!

github-actions bot commented Feb 27, 2025

Uh oh!

github-actions bot commented Mar 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JKobrynski commented Feb 12, 2025 •

edited

Loading

mananjadhav left a comment •

edited

Loading